Bug fixes

Author: jgauffin

src/Server/Coderr.Server.Api/Core/Incidents/Queries/FindIncidentsResultItem.cs

@@ -7,6 +7,8 @@ namespace Coderr.Server.Api.Core.Incidents.Queries
     /// </summary>
     public class FindIncidentsResultItem
     {
+        private string _name;
+
         /// <summary>
         ///     Creates new instance of <see cref="FindIncidentsResultItem" />.
         /// </summary>
@@ -53,6 +55,11 @@ protected FindIncidentsResultItem()
         /// </summary>
         public bool IsReOpened { get; set; }
 
+        /// <summary>
+        ///     When we recieved the last report.
+        /// </summary>
+        public DateTime LastReportReceivedAtUtc { get; set; }
+
         /// <summary>
         ///     When someone updated this incident (assigned/closed etc).
         /// </summary>
@@ -61,16 +68,20 @@ protected FindIncidentsResultItem()
         /// <summary>
         ///     Incident name
         /// </summary>
-        public string Name { get; private set; }
+        public string Name
+        {
+            set
+            {
+                if (value.Length > 40)
+                    value = value.Substring(0, 35) + "[...]";
+                _name = value;
+            }
+            get => _name;
+        }
 
         /// <summary>
         ///     Total number of received reports (increased even if the number of stored reports are at the limit)
         /// </summary>
         public int ReportCount { get; set; }
-
-        /// <summary>
-        /// When we recieved the last report.
-        /// </summary>
-        public DateTime LastReportReceivedAtUtc { get; set; }
     }
 }

src/Server/Coderr.Server.App/Coderr.Server.App.csproj

@@ -22,7 +22,7 @@
       <NoWarn>NU1701</NoWarn>
     </PackageReference>
     <PackageReference Include="DotNetCqs" Version="2.0.9" />
-    <PackageReference Include="Griffin.Framework" Version="2.0.0-alpha01" />
+    <PackageReference Include="Griffin.Framework" Version="2.0.1" />
     <PackageReference Include="log4net" Version="2.0.8" />
     <PackageReference Include="Markdig" Version="0.14.9" />
     <PackageReference Include="Newtonsoft.Json" Version="11.0.1" />

src/Server/Coderr.Server.App/Modules/MonthlyStats/CollectStatsJob.cs

@@ -36,14 +36,14 @@ public async Task ExecuteAsync()
                 return;
 
             var lastMonth = new DateTime(lastMonthDate.Year, lastMonthDate.Month, 1);
-            if (_config.Value.LatestUploadedMonth == null)
-            {
-                await ReportAllFoundMonths(lastMonth);
-                return;
-            }
+            //if (_config.Value.LatestUploadedMonth == null)
+            //{
+            //    await ReportAllFoundMonths(lastMonth);
+            //    return;
+            //}
 
-            if (_config.Value?.LatestUploadedMonth == lastMonth)
-                return;
+            //if (_config.Value?.LatestUploadedMonth == lastMonth)
+            //    return;
 
 
             await ReportMonth(lastMonth);
@@ -261,11 +261,14 @@ private async Task GetApps(Dictionary<int, ApplicationUsageStatisticsDto> apps)
                 {
                     while (await reader.ReadAsync())
                     {
+                        var estimatedNumberOfErrors = reader[1];
+                        var numberOfDevelopers = reader[2];
                         var item = new ApplicationUsageStatisticsDto()
                         {
                             ApplicationId = reader.GetInt32(0),
-                            EstimatedNumberOfErrors= reader.GetFieldValue<int?>(1),
-                            NumberOfDevelopers = reader.GetFieldValue<decimal?>(2)
+                            EstimatedNumberOfErrors =
+                                estimatedNumberOfErrors is DBNull ? 0 : (int) estimatedNumberOfErrors,
+                            NumberOfDevelopers = numberOfDevelopers is DBNull ? 0 : (decimal) numberOfDevelopers
                         };
                         apps[item.ApplicationId] = item;
                     }

src/Server/Coderr.Server.Infrastructure/Coderr.Server.Infrastructure.csproj

@@ -6,7 +6,7 @@
   </PropertyGroup>
   <ItemGroup>
     <PackageReference Include="DotNetCqs" Version="2.0.9" />
-    <PackageReference Include="Griffin.Framework" Version="2.0.0-alpha01" />
+    <PackageReference Include="Griffin.Framework" Version="2.0.1" />
     <PackageReference Include="log4net" Version="2.0.8" />
     <PackageReference Include="Newtonsoft.Json" Version="11.0.1" />
   </ItemGroup>

src/Server/Coderr.Server.ReportAnalyzer/Coderr.Server.ReportAnalyzer.csproj

@@ -10,7 +10,7 @@
     <PackageReference Include="DotNetCqs" Version="2.0.9" />
     <PackageReference Include="DotNetCqs.DependencyInjection.Microsoft" Version="1.0.0" />
     <PackageReference Include="DotNetCqs.Queues.AdoNet" Version="1.0.6" />
-    <PackageReference Include="Griffin.Framework" Version="2.0.0-alpha01" />
+    <PackageReference Include="Griffin.Framework" Version="2.0.1" />
     <PackageReference Include="log4net" Version="2.0.8" />
     <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="2.0.0" />
     <PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="2.0.0" />

src/Server/Coderr.Server.SqlServer/Coderr.Server.SqlServer.csproj

@@ -6,7 +6,7 @@
   </PropertyGroup>
   <ItemGroup>
   <PackageReference Include="DotNetCqs" Version="2.0.9" />
-  <PackageReference Include="Griffin.Framework" Version="2.0.0-alpha01" />
+  <PackageReference Include="Griffin.Framework" Version="2.0.1" />
   <PackageReference Include="log4net" Version="2.0.8" />
   <PackageReference Include="Newtonsoft.Json" Version="11.0.1" />
     <PackageReference Include="System.Data.SqlClient" Version="4.4.3" />
@@ -30,5 +30,6 @@
     <None Remove="Schema\Update.v13.sql" />
     <None Remove="Schema\Update.v14.sql" />
     <None Remove="Schema\Update.v15.sql" />
+    <None Remove="Schema\Update.v16.sql" />
   </ItemGroup>
 </Project>

src/Server/Coderr.Server.SqlServer/ReportAnalyzer/AnalyticsRepository.cs

@@ -120,8 +120,8 @@ public void AddMissedReport(DateTime date)
             {
                 cmd.CommandText =
                     @"update IgnoredReports set NumberOfReports=NumberOfReports+1 WHERE date = @date;
-                        IF @@ROWCOUNT=0 insert into IgnoredReports(NumberOfReports) values(1);";
-                cmd.AddParameter("date", date);
+                        IF @@ROWCOUNT=0 insert into IgnoredReports(NumberOfReports, Date) values(1, Convert(date, GetUtcDate()));";
+                cmd.AddParameter("date", date.Date);
                 cmd.ExecuteNonQuery();
             }
         }

src/Server/Coderr.Server.SqlServer/Schema/Update.v16.sql

@@ -0,0 +1,3 @@
+alter table applications alter column NumberOfFtes decimal(4,1) null;
+
+UPDATE DatabaseSchema SET Version = 16;

src/Server/Coderr.Server.Web/Boot/Modules/BackgroundJobs.cs

@@ -19,6 +19,7 @@ public void Start(StartContext context)
             var adapter = new DependencyInjectionAdapter(context.ServiceProvider);
 
             _backgroundJobManager = new BackgroundJobManager(adapter);
+            _backgroundJobManager.ExecuteSequentially = true;
             _backgroundJobManager.JobFailed += OnBackgroundJobFailed;
             _backgroundJobManager.StartInterval = TimeSpan.FromSeconds(Debugger.IsAttached ? 0 : 10);
             _backgroundJobManager.ExecuteInterval = TimeSpan.FromMinutes(3);

src/Server/Coderr.Server.Web/ClientApp/boot.ts

@@ -276,6 +276,9 @@ AppRoot.Instance.loadCurrentUser()
 
             }
         });
+        ourVue.$router.beforeEach((to, from, next) => {
+            next();
+        });
         ourVue.$router.afterEach((to, from) => {
             hooks.afterRoute(to.path, from.path);
         })