* Added guards against reporting clients with incorrectly configured clocks when receiving new reports

* The global dashboard can now handle/ignore future dates

Author: gauffininteractive

src/Server/OneTrueError.Api/Web/Overview/Queries/GetOverviewApplicationResult.cs

@@ -69,6 +69,11 @@ protected GetOverviewApplicationResult()
         public void AddValue(DateTime date, int value)
         {
             if (value < 0) throw new ArgumentOutOfRangeException("value");
+
+            //future date = malconfigured reporting clients.
+            if (!_index.ContainsKey(date))
+                return;
+            
             var indexPos = _index[date];
             Values[indexPos] = value;
         }

src/Server/OneTrueError.App.Tests/OneTrueError.App.Tests.csproj

@@ -111,6 +111,7 @@
     <Compile Include="ObjectExtensions.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
     <Compile Include="ReposExtensions.cs" />
+    <Compile Include="Web\Overview\Queries\GetOverviewApplicationResultTests.cs" />
   </ItemGroup>
   <ItemGroup />
   <ItemGroup>

src/Server/OneTrueError.App.Tests/Web/Overview/Queries/GetOverviewApplicationResultTests.cs

@@ -0,0 +1,34 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+using FluentAssertions;
+using OneTrueError.Api.Web.Overview.Queries;
+using Xunit;
+
+namespace OneTrueError.App.Tests.Web.Overview.Queries
+{
+   public  class GetOverviewApplicationResultTests
+    {
+
+        [Fact]
+        public void ignore_future_dates_to_allow_malconfigured_clients()
+        {
+
+            var sut = new GetOverviewApplicationResult("Label", DateTime.Today.AddDays(-30), 30);
+            sut.AddValue(DateTime.Today.AddDays(1), 10);
+
+        }
+
+        [Fact]
+        public void should_allow_dates_within_the_given_interval()
+        {
+
+            var sut = new GetOverviewApplicationResult("hello", DateTime.Today.AddDays(-30), 31);
+            sut.AddValue(DateTime.Today, 10);
+
+            sut.Values[sut.Values.Length - 1].Should().Be(10);
+        }
+    }
+}

src/Server/OneTrueError.SqlServer/Web/Overview/GetOverviewHandler.cs

@@ -49,6 +49,8 @@ private string ApplicationIds
 
         public async Task<GetOverviewResult> ExecuteAsync(GetOverview query)
         {
+            if (query.NumberOfDays == 0)
+                query.NumberOfDays = 30;
             var labels = CreateTimeLabels(query);
 
             if (!ClaimsPrincipal.Current.FindAll(x => x.Type == OneTrueClaims.Application).Any())
@@ -61,8 +63,6 @@ public async Task<GetOverviewResult> ExecuteAsync(GetOverview query)
                 };
             }
 
-            if (query.NumberOfDays == 0)
-                query.NumberOfDays = 30;
             if (query.NumberOfDays == 1)
                 return await GetTodaysOverviewAsync(query);
 
@@ -76,7 +76,8 @@ public async Task<GetOverviewResult> ExecuteAsync(GetOverview query)
 (
 	select Incidents.ApplicationId , cast(Incidents.CreatedAtUtc as date) as Date, count(Incidents.Id) as Count
 	from Incidents
-	where Incidents.CreatedAtUtc >= @minDate
+	where Incidents.CreatedAtUtc >= @minDate 
+    AND Incidents.CreatedAtUtc <= GetUtcDate()
 	AND Incidents.ApplicationId in ({ApplicationIds})
 	group by Incidents.ApplicationId, cast(Incidents.CreatedAtUtc as date)
 ) cte
@@ -139,6 +140,7 @@ private async Task GetStatSummary(GetOverview query, GetOverviewResult result)
             {
                 cmd.CommandText = string.Format(@"select count(id) from incidents 
 where CreatedAtUtc >= @minDate
+AND CreatedAtUtc <= GetUtcDate()
 AND Incidents.ApplicationId IN ({0})
 AND Incidents.IgnoreReports = 0 
 AND Incidents.IsSolved = 0;
@@ -149,12 +151,14 @@ AND ApplicationId IN ({0})
 
 select count(distinct emailaddress) from IncidentFeedback
 where CreatedAtUtc >= @minDate
+AND CreatedAtUtc <= GetUtcDate()
 AND ApplicationId IN ({0})
 AND emailaddress is not null
 AND DATALENGTH(emailaddress) > 0;
 
 select count(*) from IncidentFeedback 
 where CreatedAtUtc >= @minDate
+AND CreatedAtUtc <= GetUtcDate()
 AND ApplicationId IN ({0})
 AND Description is not null
 AND DATALENGTH(Description) > 0;", ApplicationIds);
@@ -208,6 +212,7 @@ private async Task<GetOverviewResult> GetTodaysOverviewAsync(GetOverview query)
 	select Incidents.ApplicationId , DATEPART(HOUR, Incidents.CreatedAtUtc) as Date, count(Incidents.Id) as Count
 	from Incidents
 	where Incidents.CreatedAtUtc >= @minDate
+    AND CreatedAtUtc <= GetUtcDate()
     AND Incidents.ApplicationId IN ({0})
 	group by Incidents.ApplicationId, DATEPART(HOUR, Incidents.CreatedAtUtc)
 ) cte

src/Server/OneTrueError.Web/Areas/Receiver/Helpers/SaveReportHandler.cs

@@ -59,6 +59,11 @@ public async Task BuildReportAsync(string appKey, string signatureProvidedByTheC
             }
 
             var report = DeserializeBody(reportBody);
+
+            //fix malconfigured clients
+            if (report.CreatedAtUtc > DateTime.UtcNow)
+                report.CreatedAtUtc = DateTime.UtcNow;
+
             var internalDto = new ReceivedReportDTO
             {
                 ApplicationId = application.Id,

src/Server/OneTrueError.Web/Content/ote_bootstrap.css

@@ -414,7 +414,7 @@ th { padding: 0; }
 @font-face {
     font-family: 'Glyphicons Halflings';
     src: url('fonts/glyphicons-halflings-regular.eot');
-    src: url('fonts/glyphicons-halflings-regular.eot?#iefix') format('embedded-opentype'), url('fonts/glyphicons-halflings-regular.woff2') format('woff2'), url('fonts/glyphicons-halflings-regular.woff') format('woff'), url('fonts/glyphicons-halflings-regular.ttf') format('truetype'), url('fonts/glyphicons-halflings-regular.svg#glyphicons_halflingsregular') format('svg');
+    src: url('fonts/glyphicons-halflings-regular.eot?#iefix') format('embedded-opentype'), url('../fonts/glyphicons-halflings-regular.woff2') format('woff2'), url('fonts/glyphicons-halflings-regular.woff') format('woff'), url('fonts/glyphicons-halflings-regular.ttf') format('truetype'), url('fonts/glyphicons-halflings-regular.svg#glyphicons_halflingsregular') format('svg');
 }
 
 .glyphicon {