Skip to content
This repository was archived by the owner on Nov 8, 2022. It is now read-only.

Commit f4cf71f

Browse files
committed
chore: Merge branch 'fix/sticky-sidebar' into dev
2 parents 1e02225 + 8114574 commit f4cf71f

File tree

10 files changed

+16
-14
lines changed

10 files changed

+16
-14
lines changed

containers/JobContent/styles/index.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,9 @@ export const MainWrapper = styled.div`
2424
width: 100%;
2525
`};
2626
`
27-
export const SidebarWrapper = styled.div``
27+
export const SidebarWrapper = styled.div`
28+
min-width: 250px;
29+
`
2830
/* background: ${theme('preview.articleBg')}; */
2931
export const ArticleWrapper = styled.div`
3032
font-size: 1.1rem;

containers/JobContent/styles/side_cards.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import { cs } from '@utils'
44

55
export const Wrapper = styled.div`
66
${cs.flexColumn()};
7-
width: 90%;
87
min-width: 250px;
98
${cs.media.tablet`display: none`};
109
`

containers/PostContent/styles/index.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,16 +25,16 @@ export const MainWrapper = styled.div`
2525
width: 100%;
2626
`};
2727
`
28-
export const SidebarWrapper = styled.div``
29-
28+
export const SidebarWrapper = styled.div`
29+
min-width: 250px;
30+
`
3031
/* background: ${theme('preview.articleBg')}; */
3132
export const ArticleWrapper = styled.div`
3233
font-size: 1.1rem;
3334
margin-right: 1.6vw;
3435
background: ${theme('preview.articleBg')};
3536
border-radius: 5px;
3637
padding: 35px 40px;
37-
min-height: 60vh;
3838
box-shadow: 0 1px 4px rgba(0, 0, 0, 0.04);
3939
${cs.media.mobile`
4040
padding: 30px 20px;

containers/PostContent/styles/side_cards.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import { cs } from '@utils'
44

55
export const Wrapper = styled.div`
66
${cs.flexColumn()};
7-
width: 90%;
87
min-width: 250px;
98
${cs.media.tablet`display: none`};
109
`

containers/Preview/store.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,11 +98,11 @@ const PreviewStore = t
9898
return stripMobx(self.attUser)
9999
},
100100
get modalVisible() {
101-
return self.visible && Global.innerWidth > cs.mediaBreakPoints.desktop
101+
return self.visible && Global.innerWidth > cs.mediaBreakPoints.desktopL
102102
},
103103

104104
get slideVisible() {
105-
return self.visible && Global.innerWidth < cs.mediaBreakPoints.desktop
105+
return self.visible && Global.innerWidth <= cs.mediaBreakPoints.desktopL
106106
},
107107
}))
108108
.actions(self => ({

containers/RepoContent/styles/index.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,9 @@ export const MainWrapper = styled.div`
2424
width: 100%;
2525
`};
2626
`
27-
export const SidebarWrapper = styled.div``
28-
27+
export const SidebarWrapper = styled.div`
28+
min-width: 250px;
29+
`
2930
/* background: ${theme('preview.articleBg')}; */
3031
export const ArticleWrapper = styled.div`
3132
font-size: 1.1rem;

containers/RepoContent/styles/side_cards.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import { cs } from '@utils'
44

55
export const Wrapper = styled.div`
66
${cs.flexColumn()};
7-
width: 90%;
87
min-width: 250px;
98
${cs.media.tablet`display: none`};
109
`

containers/VideoContent/styles/index.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,9 @@ export const MainWrapper = styled.div`
2424
width: 100%;
2525
`};
2626
`
27-
export const SidebarWrapper = styled.div``
28-
27+
export const SidebarWrapper = styled.div`
28+
min-width: 250px;
29+
`
2930
export const ArticleWrapper = styled.div`
3031
font-size: 1.1rem;
3132
margin-right: 1.6vw;

containers/VideoContent/styles/side_cards.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import { cs } from '@utils'
55

66
export const Wrapper = styled.div`
77
${cs.flexColumn()};
8-
width: 90%;
98
min-width: 250px;
109
${cs.media.tablet`display: none`};
1110
`

utils/common_styles.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,8 @@ export const mediaBreakPoints = {
102102
tablet: 768,
103103
laptop: 992,
104104
desktop: 1600,
105+
// currently used as forms of preview content (slideout/modal)
106+
desktopL: 1920,
105107
// laptopL: '1440px',
106108
// desktop: '2560px'
107109
}

0 commit comments

Comments
 (0)