refactor(router): move onClient to ssr_helper & rename for convention

rename to isClientSide

Author: mydearxym

containers/Route/store.js

@@ -8,7 +8,13 @@ import R from 'ramda'
 // import Router from 'next/router'
 
 import { PAGE_SIZE } from '@config'
-import { Global, onClient, markStates, buildLog, serializeQuery } from '@utils'
+import {
+  Global,
+  isClientSide,
+  markStates,
+  buildLog,
+  serializeQuery,
+} from '@utils'
 
 /* eslint-disable-next-line */
 const log = buildLog('S:RouteStore')
@@ -42,7 +48,7 @@ const RouteStore = t
     // TODO:  if current url is subdomain, then we should
     // reload to that page directly
     markRoute(query) {
-      if (!onClient) return false
+      if (!isClientSide) return false
       const { mainPath, subPath, page } = query
       query = R.pickBy(v => !R.isEmpty(v), query)
 

pages/community.js

@@ -59,8 +59,8 @@ async function fetchData(props, opt) {
   const { asPath } = props
   // schema
 
-  const { mainPath, subPath: topic } = parseURL(props)
-  const community = akaTranslate(mainPath)
+  const { communityPath, threadPath: topic } = parseURL(props)
+  const community = akaTranslate(communityPath)
   const thread = extractThreadFromPath(props)
 
   let filter = addTopicIfNeed(
@@ -105,9 +105,9 @@ async function fetchData(props, opt) {
 
 export default class CommunityPage extends React.Component {
   static async getInitialProps(props) {
-    if (!isServerSide()) return {}
+    if (!isServerSide) return {}
 
-    const { mainPath, subPath } = parseURL(props)
+    const { communityPath, threadPath } = parseURL(props)
     const thread = extractThreadFromPath(props)
 
     let resp
@@ -119,7 +119,7 @@ export default class CommunityPage extends React.Component {
       } else {
         return {
           statusCode: 404,
-          target: mainPath,
+          target: communityPath,
           viewing: { community: {} },
           route: {},
         }
@@ -156,7 +156,12 @@ export default class CommunityPage extends React.Component {
           repo: {},
           user: {},
         },
-        route: { mainPath: community.raw, subPath },
+        route: {
+          communityPath: community.raw,
+          mainPath: community.raw,
+          threadPath,
+          subPath: threadPath,
+        },
         tagsBar: { tags: partialTags },
       },
       contentsThread
@@ -179,7 +184,7 @@ export default class CommunityPage extends React.Component {
       viewing: { community },
       route,
     } = this.props
-    const { mainPath, subPath } = route
+    const { communityPath, threadPath } = route
 
     const seoTitle =
       community.raw === 'home'
@@ -200,7 +205,7 @@ export default class CommunityPage extends React.Component {
               <React.Fragment>
                 <NextSeo
                   config={{
-                    url: `${SITE_URL}/${mainPath}/${subPath}`,
+                    url: `${SITE_URL}/${communityPath}/${threadPath}`,
                     title: seoTitle,
                     description: `${community.desc}`,
                   }}

utils/functions.js

@@ -9,7 +9,6 @@ import { nilOrEmpty } from './validator'
 /* eslint-disable */
 // TODO: document ?
 export const Global = typeof window !== 'undefined' ? window : global
-export const onClient = typeof window !== 'undefined' ? true : false
 /* eslint-enable */
 
 // see https://github.com/ramda/ramda/issues/1361

utils/index.js

@@ -13,7 +13,6 @@ export {
   mapKeys,
   getRandomInt,
   Global,
-  onClient,
   cutFrom,
   prettyNum,
   numberWithCommas,
@@ -81,6 +80,7 @@ export {
 
 export {
   isServerSide,
+  isClientSide,
   getJwtToken,
   ssrPagedSchema,
   ssrPagedFilter,

utils/route_helper.js

@@ -61,7 +61,7 @@ const getThirdPath = args => {
  */
 const parseSubDomain = args => {
   let communityPath = ''
-  if (isServerSide()) {
+  if (isServerSide) {
     // on server side
     const { subdomains } = args.req
     console.log('subdomains: ', subdomains)
@@ -94,20 +94,24 @@ export const parseURL = args => {
   let subPath = ''
   let thridPath = ''
   let communityPath = parseSubDomain(args)
+  let threadPath = ''
 
   if (communityPath === '') {
     mainPath = getMainPath(args)
     subPath = getSubPath(args)
     thridPath = getThirdPath(args)
     communityPath = mainPath
+    threadPath = subPath
   } else {
     mainPath = communityPath
     subPath = getMainPath(args)
     thridPath = getSubPath(args)
+    threadPath = subPath
   }
 
   return {
     communityPath,
+    threadPath,
     mainPath,
     subPath,
     thridPath,

utils/ssr_helper.js

@@ -8,15 +8,13 @@ import BStore from './bstore'
 /*
  * check if current is on server side
  */
-export const isServerSide = () => {
-  const isOnserver = typeof window === 'undefined'
-  return isOnserver
-}
+export const isServerSide = typeof window === 'undefined'
+export const isClientSide = !isServerSide
 
 // get jwt from cookie or localStorage
 // props has to be getInitialProps's arg
 export const getJwtToken = props => {
-  if (isServerSide()) return BStore.cookie.from_req(props.req, 'jwtToken')
+  if (isServerSide) return BStore.cookie.from_req(props.req, 'jwtToken')
 
   return BStore.get('token')
 }