add eslint-watch && clean up eslint warnings

mydearxym · mydearxym · commit 8d62205c813a · 2017-10-28T09:09:58.000+08:00
diff --git a/containers/Body/index.js b/containers/Body/index.js
@@ -98,7 +98,7 @@ class ContentContainer extends React.Component {
 
   render() {
     const { route } = this.props
-    console.log('route: ', route)
+    debug('route: ', route)
     return (
       <Body id="whereCallShowDoraemon">
         <AppHeader />
diff --git a/containers/Doraemon/helper/swissArmyKnife.js b/containers/Doraemon/helper/swissArmyKnife.js
@@ -42,7 +42,9 @@ export class SwissArmyKnife {
       })
       /* eslint-enable no-undef */
     } catch (e) {
+      /* eslint-disable no-console */
       console.error('bad selector in scrollIntoViewIfNeeded', e)
+      /* eslint-enable no-console */
     }
   }
 
diff --git a/containers/Doraemon/logic.js b/containers/Doraemon/logic.js
@@ -50,13 +50,13 @@ const initCmdResolver = () => {
     {
       match: SAK.stepOneCmd('hforward'),
       action: () => {
-        console.log('SAK.stepOneCmd hforward')
+        debug('SAK.stepOneCmd hforward')
       },
     },
     {
       match: SAK.stepOneCmd('hbackward'),
       action: () => {
-        console.log('SAK.stepOneCmd hbackward')
+        debug('SAK.stepOneCmd hbackward')
       },
     },
     {
diff --git a/containers/GithubSearchPanel/Pigeon.js b/containers/GithubSearchPanel/Pigeon.js
@@ -50,7 +50,9 @@ export default class SearchService {
       .distinctUntilChanged()
       .switchMap(getGithubRepos)
       .catch(error => {
+        /* eslint-disable no-console */
         console.error(error)
+        /* eslint-enable no-console */
         return Observable.of([])
       })
   }
diff --git a/package.json b/package.json
@@ -3,8 +3,9 @@
   "version": "0.0.1",
   "license": "MIT",
   "scripts": {
-    "dev": "cross-env NODE_ENV=dev run-p server ",
+    "dev": "cross-env NODE_ENV=dev run-p server lint:watch",
     "lint": "eslint pages/**/*.js components/**/* containers/**/* stores/**/*",
+    "lint:watch": "esw -w pages/**/*.js components/**/* containers/**/* stores/**/*",
     "pretest": "npm run lint",
     "test": "cross-env NODE_ENV=test jest",
     "test:watch": "npm run test -- --watch",
@@ -136,6 +137,7 @@
     "eslint-plugin-jsx-a11y": "^6.0.2",
     "eslint-plugin-prettier": "^2.2.0",
     "eslint-plugin-react": "7.4.0",
+    "eslint-watch": "^3.1.3",
     "husky": "^0.14.3",
     "jest": "^21.0.2",
     "lint-staged": "^4.0.4",
diff --git a/yarn.lock b/yarn.lock
@@ -1068,6 +1068,14 @@ babel-plugin-transform-strict-mode@^6.24.1:
     babel-runtime "^6.22.0"
     babel-types "^6.24.1"
 
+babel-polyfill@^6.20.0:
+  version "6.26.0"
+  resolved "http://r.cnpmjs.org/babel-polyfill/download/babel-polyfill-6.26.0.tgz#379937abc67d7895970adc621f284cd966cf2153"
+  dependencies:
+    babel-runtime "^6.26.0"
+    core-js "^2.5.0"
+    regenerator-runtime "^0.10.5"
+
 babel-preset-env@1.6.0:
   version "1.6.0"
   resolved "http://r.cnpmjs.org/babel-preset-env/download/babel-preset-env-1.6.0.tgz#2de1c782a780a0a5d605d199c957596da43c44e4"
@@ -1296,6 +1304,10 @@ block-stream@*:
   dependencies:
     inherits "~2.0.0"
 
+bluebird@^3.5.1:
+  version "3.5.1"
+  resolved "http://r.cnpmjs.org/bluebird/download/bluebird-3.5.1.tgz#d9551f9de98f1fcda1e683d17ee91a0602ee2eb9"
+
 bn.js@^4.0.0, bn.js@^4.1.0, bn.js@^4.1.1, bn.js@^4.4.0:
   version "4.11.8"
   resolved "http://r.cnpmjs.org/bn.js/download/bn.js-4.11.8.tgz#2cde09eb5ee341f484746bb0309b3253b1b1442f"
@@ -1593,7 +1605,7 @@ cheerio@^1.0.0-rc.2:
     lodash "^4.15.0"
     parse5 "^3.0.1"
 
-chokidar@^1.7.0:
+chokidar@^1.4.3, chokidar@^1.7.0:
   version "1.7.0"
   resolved "http://r.cnpmjs.org/chokidar/download/chokidar-1.7.0.tgz#798e689778151c8076b4b360e5edd28cda2bb468"
   dependencies:
@@ -2629,6 +2641,23 @@ eslint-scope@^3.7.1:
     esrecurse "^4.1.0"
     estraverse "^4.1.1"
 
+eslint-watch@^3.1.3:
+  version "3.1.3"
+  resolved "http://r.cnpmjs.org/eslint-watch/download/eslint-watch-3.1.3.tgz#e3882a93f02ba4d8a797562fa9c3815e3181c4ba"
+  dependencies:
+    babel-polyfill "^6.20.0"
+    bluebird "^3.5.1"
+    chalk "^2.1.0"
+    chokidar "^1.4.3"
+    debug "^3.0.1"
+    keypress "^0.2.1"
+    lodash "^4.17.4"
+    optionator "^0.8.2"
+    source-map-support "^0.5.0"
+    strip-ansi "^4.0.0"
+    text-table "^0.2.0"
+    unicons "0.0.3"
+
 eslint@^4.6.1:
   version "4.6.1"
   resolved "http://r.cnpmjs.org/eslint/download/eslint-4.6.1.tgz#ddc7fc7fd70bf93205b0b3449bb16a1e9e7d4950"
@@ -4469,6 +4498,10 @@ junk@^1.0.1:
   version "1.0.3"
   resolved "http://r.cnpmjs.org/junk/download/junk-1.0.3.tgz#87be63488649cbdca6f53ab39bec9ccd2347f592"
 
+keypress@^0.2.1:
+  version "0.2.1"
+  resolved "http://r.cnpmjs.org/keypress/download/keypress-0.2.1.tgz#1e80454250018dbad4c3fe94497d6e67b6269c77"
+
 kind-of@^3.0.2:
   version "3.2.2"
   resolved "http://r.cnpmjs.org/kind-of/download/kind-of-3.2.2.tgz#31ea21a734bab9bbb0f32466d893aea51e4a3c64"
@@ -6550,7 +6583,7 @@ regenerate@^1.2.1:
   version "1.3.2"
   resolved "http://r.cnpmjs.org/regenerate/download/regenerate-1.3.2.tgz#d1941c67bad437e1be76433add5b385f95b19260"
 
-regenerator-runtime@^0.10.0:
+regenerator-runtime@^0.10.0, regenerator-runtime@^0.10.5:
   version "0.10.5"
   resolved "http://r.cnpmjs.org/regenerator-runtime/download/regenerator-runtime-0.10.5.tgz#336c3efc1220adcedda2c9fab67b5a7955a33658"
 
@@ -7072,6 +7105,12 @@ source-map-support@^0.4.15:
   dependencies:
     source-map "^0.5.6"
 
+source-map-support@^0.5.0:
+  version "0.5.0"
+  resolved "http://r.cnpmjs.org/source-map-support/download/source-map-support-0.5.0.tgz#2018a7ad2bdf8faf2691e5fddab26bed5a2bacab"
+  dependencies:
+    source-map "^0.6.0"
+
 source-map@0.5.6:
   version "0.5.6"
   resolved "http://r.cnpmjs.org/source-map/download/source-map-0.5.6.tgz#75ce38f52bf0733c5a7f0c118d81334a2bb5f412"
@@ -7086,7 +7125,7 @@ source-map@^0.5.3, source-map@^0.5.6, source-map@~0.5.1, source-map@~0.5.3, sour
   version "0.5.7"
   resolved "http://r.cnpmjs.org/source-map/download/source-map-0.5.7.tgz#8a039d2d1021d22d1ea14c80d8ea468ba2ef3fcc"
 
-source-map@^0.6.1:
+source-map@^0.6.0, source-map@^0.6.1:
   version "0.6.1"
   resolved "http://r.cnpmjs.org/source-map/download/source-map-0.6.1.tgz#74722af32e9614e9c287a8d0bbde48b5e2f1a263"
 
@@ -7445,7 +7484,7 @@ text-extensions@^1.0.0:
   version "1.7.0"
   resolved "http://r.cnpmjs.org/text-extensions/download/text-extensions-1.7.0.tgz#faaaba2625ed746d568a23e4d0aacd9bf08a8b39"
 
-text-table@~0.2.0:
+text-table@^0.2.0, text-table@~0.2.0:
   version "0.2.0"
   resolved "http://r.cnpmjs.org/text-table/download/text-table-0.2.0.tgz#7f5ee823ae805207c00af2df4a84ec3fcfa570b4"
 
@@ -7677,6 +7716,10 @@ unfetch@3.0.0:
   version "3.0.0"
   resolved "http://r.cnpmjs.org/unfetch/download/unfetch-3.0.0.tgz#8d1e0513a4ecd0e5ff2d41a6ba77771aae8b6482"
 
+unicons@0.0.3:
+  version "0.0.3"
+  resolved "http://r.cnpmjs.org/unicons/download/unicons-0.0.3.tgz#6e6a7a1a6eaebb01ca3d8b12ad9687279eaba524"
+
 universalify@^0.1.0:
   version "0.1.1"
   resolved "http://r.cnpmjs.org/universalify/download/universalify-0.1.1.tgz#fa71badd4437af4c148841e3b3b165f9e9e590b7"

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,9 @@ export class SwissArmyKnife {`
`42`	`42`	`})`
`43`	`43`	`/* eslint-enable no-undef */`
`44`	`44`	`} catch (e) {`
	`45`	`+ /* eslint-disable no-console */`
`45`	`46`	`console.error('bad selector in scrollIntoViewIfNeeded', e)`
	`47`	`+ /* eslint-enable no-console */`
`46`	`48`	`}`
`47`	`49`	`}`
`48`	`50`
Original file line number	Diff line number	Diff line change
`@@ -50,13 +50,13 @@ const initCmdResolver = () => {`
`50`	`50`	`{`
`51`	`51`	`match: SAK.stepOneCmd('hforward'),`
`52`	`52`	`action: () => {`
`53`		`- console.log('SAK.stepOneCmd hforward')`
	`53`	`+ debug('SAK.stepOneCmd hforward')`
`54`	`54`	`},`
`55`	`55`	`},`
`56`	`56`	`{`
`57`	`57`	`match: SAK.stepOneCmd('hbackward'),`
`58`	`58`	`action: () => {`
`59`		`- console.log('SAK.stepOneCmd hbackward')`
	`59`	`+ debug('SAK.stepOneCmd hbackward')`
`60`	`60`	`},`
`61`	`61`	`},`
`62`	`62`	`{`