refactor: move user default c11n settings to schema

Author: mydearxym

lib/groupher_server/accounts/customization.ex

@@ -2,14 +2,18 @@ defmodule GroupherServer.Accounts.Customization do
   @moduledoc false
 
   alias __MODULE__
-
   use Ecto.Schema
+
+  import Helper.Utils, only: [get_config: 2]
   import Ecto.Changeset
+
   alias GroupherServer.Accounts.User
 
   @required_fields ~w(user_id)a
   @optional_fields ~w(theme sidebar_layout sidebar_communities_index community_chart brainwash_free banner_layout contents_layout content_divider content_hover mark_viewed display_density)a
 
+  @default_customization get_config(:customization, :all)
+
   @type t :: %Customization{}
   schema "customizations" do
     belongs_to(:user, User)
@@ -38,4 +42,6 @@ defmodule GroupherServer.Accounts.Customization do
     |> validate_required(@required_fields)
     |> foreign_key_constraint(:user_id)
   end
+
+  def default, do: @default_customization |> Enum.into(%{})
 end

lib/groupher_server/accounts/delegates/customization.ex

@@ -3,16 +3,14 @@ defmodule GroupherServer.Accounts.Delegate.Customization do
   customization for user
   """
   import Ecto.Query, warn: false
-  import Helper.Utils, only: [get_config: 2, map_atom_value: 2]
+  import Helper.Utils, only: [map_atom_value: 2]
   import ShortMaps
 
-  alias Helper.ORM
   alias GroupherServer.Accounts
+  alias Helper.ORM
 
-  alias Accounts.{User, Customization}
-  alias Accounts.Delegate.Achievements
-
-  @default_customization get_config(:customization, :all) |> Enum.into(%{})
+  alias Accounts.{Customization, Delegate, User}
+  alias Delegate.Achievements
 
   def upgrade_by_plan(%User{} = user, :donate) do
     Achievements.set_member(user, :donate)
@@ -37,10 +35,10 @@ defmodule GroupherServer.Accounts.Delegate.Customization do
     case ORM.find_by(Customization, user_id: user_id) do
       {:ok, customization} ->
         customization = customization |> Map.from_struct() |> filter_nil_value
-        {:ok, Map.merge(@default_customization, customization)}
+        {:ok, Map.merge(Customization.default(), customization)}
 
       {:error, _} ->
-        {:ok, @default_customization}
+        {:ok, Customization.default()}
     end
   end
 
@@ -96,12 +94,12 @@ defmodule GroupherServer.Accounts.Delegate.Customization do
     end
   end
 
-  defp extract_cur_c11n(nil), do: @default_customization
+  defp extract_cur_c11n(nil), do: Customization.default()
 
   defp extract_cur_c11n(%Customization{} = customization) do
     customization = customization |> Map.from_struct() |> filter_nil_value
 
-    Map.merge(@default_customization, customization)
+    Map.merge(Customization.default(), customization)
   end
 
   # defp c11n_item_setable?(:theme, %{

test/groupher_server_web/query/accounts/customization_test.exs

@@ -1,8 +1,7 @@
 defmodule GroupherServer.Test.Query.Account.Customization do
   use GroupherServer.TestTools
-  import Helper.Utils, only: [get_config: 2]
 
-  @default_customization get_config(:customization, :all) |> Enum.into(%{})
+  alias GroupherServer.Accounts.Customization
 
   setup do
     {:ok, user} = db_insert(:user)
@@ -35,13 +34,14 @@ defmodule GroupherServer.Test.Query.Account.Customization do
       results = user_conn |> query_result(@query, %{}, "user")
 
       assert results["id"] == to_string(user.id)
-      assert results["customization"]["theme"] == @default_customization |> Map.get(:theme)
+      assert results["customization"]["theme"] == Customization.default() |> Map.get(:theme)
 
       assert results["customization"]["bannerLayout"] ==
-               @default_customization |> Map.get(:banner_layout)
+               Customization.default()
+               |> Map.get(:banner_layout)
 
       assert results["customization"]["contentsLayout"] ==
-               @default_customization |> Map.get(:contents_layout)
+               Customization.default() |> Map.get(:contents_layout)
     end
   end
 end