chore(typo): modal -> model

Author: mydearxym

cover/excoveralls.json

@@ -6,13 +6,13 @@ defmodule Helper.ErrorHandler do
   alias GroupherServerWeb.Gettext, as: Translator
 
   def not_found_formater(queryable, id) when is_integer(id) or is_binary(id) do
-    modal = queryable |> to_string |> String.split(".") |> List.last()
+    model = queryable |> to_string |> String.split(".") |> List.last()
 
-    Translator |> Gettext.dgettext("404", "#{modal}(%{id}) not found", id: id)
+    Translator |> Gettext.dgettext("404", "#{model}(%{id}) not found", id: id)
   end
 
   def not_found_formater(queryable, clauses) do
-    modal = queryable |> to_string |> String.split(".") |> List.last()
+    model = queryable |> to_string |> String.split(".") |> List.last()
 
     detail =
       clauses
@@ -21,6 +21,6 @@ defmodule Helper.ErrorHandler do
       |> List.first()
       |> to_string
 
-    Translator |> Gettext.dgettext("404", "#{modal}(%{name}) not found", name: detail)
+    Translator |> Gettext.dgettext("404", "#{model}(%{name}) not found", name: detail)
   end
 end

lib/helper/error_handler.ex

@@ -186,10 +186,10 @@ defmodule Helper.ORM do
   #   query |> Ecto.Query.where(^where) |> Repo.update_all(inc: changes)
   # end
 
-  def create(modal, attrs) do
-    modal
+  def create(model, attrs) do
+    model
     |> struct
-    |> modal.changeset(attrs)
+    |> model.changeset(attrs)
     |> Repo.insert()
   end
 

lib/helper/orm.ex

@@ -18,7 +18,7 @@ defmodule GroupherServer.Test.Billing do
   end
 
   describe "[billing curd]" do
-    @tag :wip2
+    @tag :wip
     test "create bill record with valid attrs", ~m(user valid_attrs)a do
       {:ok, record} = Billing.create_record(user, valid_attrs)
 

test/groupher_server/billing/billing_test.exs

@@ -19,6 +19,25 @@ defmodule GroupherServer.Test.Helper.ORMTest do
     {:ok, post: post}
   end
 
+  # def send_email(to \\ "someone") do 
+  #   IO.inspect "send email.. #{to}"
+  # end 
+
+  # describe "orm hooks" do
+  #   @tag :wip2
+  #   test "create hooks" do 
+  #     user_attrs = mock_attrs(:user)
+  #     user_attrs2 = mock_attrs(:user)
+
+  #     {:ok, _} = ORM.create(User, user_attrs, %{after_success: [&send_email/1, ["me"] ]})
+  #     {:ok, _} = ORM.create(User, user_attrs2, %{after_success: &send_email/0})
+
+  #     ORM.create(User, user_attrs, %{after_success: [&Email.notify_admin/2, [user, :new_register] ]  })
+
+  #     true
+  #   end 
+  # end
+
   describe "[find/x find_by]" do
     test "find/2 should work, and not preload fields", %{post: post} do
       {:ok, found} = ORM.find(Post, post.id)