refactor(cms-macros): more macros for cms articles && community (#361)

* refactor(cms-macros): missing doc

* refactor: wip

* refactor: wip

* refactor: wip, macro in macro

* refactor: general_article_fields wip

* refactor: general_article_fields wip

* refactor: general_article_fields wip

* refactor: add doc for general_article_fields

* refactor: fmt

* refactor: job

* refactor: job fix

* refactor: repo

* refactor: repo fix && missing tests

* refactor: post_communities macro

* refactor: community_article macro

* refactor: add some doc

* refactor: move article_thread config to config.ex

* refactor: rm unused warning

Author: mydearxym

config/config.exs

@@ -61,6 +61,8 @@ config :groupher_server, :customization,
   sidebar_communities_index: %{}
 
 config :groupher_server, :article,
+  # NOTE: do not change unless you know what you are doing
+  article_threads: [:post, :job, :repo],
   # NOTE: if you want to add/remove emotion, just edit the list below
   # and migrate the field to table "articles_users_emotions"
   supported_emotions: [

lib/groupher_server/application.ex

@@ -7,8 +7,6 @@ defmodule GroupherServer.Application do
   @spec start(any, any) :: {:error, any} | {:ok, pid}
   def start(_type, _args) do
     import Supervisor.Spec
-    import Cachex.Spec
-
     alias Helper.Cache
 
     # Define workers and child supervisors to be supervised

lib/groupher_server/cms/abuse_report.ex

@@ -4,14 +4,16 @@ defmodule GroupherServer.CMS.AbuseReport do
 
   use Ecto.Schema
   use Accessible
+
   import Ecto.Changeset
+  import Helper.Utils, only: [get_config: 2]
   import GroupherServer.CMS.Helper.Macros
   import GroupherServer.CMS.Helper.Utils, only: [articles_foreign_key_constraint: 1]
 
   alias GroupherServer.{Accounts, CMS}
   alias CMS.{ArticleComment, Embeds}
 
-  @article_threads CMS.Community.article_threads()
+  @article_threads get_config(:article, :article_threads)
 
   # @required_fields ~w(article_comment_id user_id recived_user_id)a
   @optional_fields ~w(article_comment_id account_id operate_user_id deal_with report_cases_count)a
@@ -31,7 +33,7 @@ defmodule GroupherServer.CMS.AbuseReport do
 
     field(:deal_with, :string)
 
-    article_belongs_to()
+    article_belongs_to_fields()
     timestamps(type: :utc_datetime)
   end
 

lib/groupher_server/cms/article_collect.ex

@@ -3,14 +3,16 @@ defmodule GroupherServer.CMS.ArticleCollect do
   alias __MODULE__
 
   use Ecto.Schema
+
   import Ecto.Changeset
+  import Helper.Utils, only: [get_config: 2]
   import GroupherServer.CMS.Helper.Macros
   import GroupherServer.CMS.Helper.Utils, only: [articles_foreign_key_constraint: 1]
 
   alias GroupherServer.{Accounts, CMS}
   alias Accounts.{User, CollectFolder}
 
-  @article_threads CMS.Community.article_threads()
+  @article_threads get_config(:article, :article_threads)
 
   @required_fields ~w(user_id)a
   @optional_fields ~w(thread)a
@@ -23,7 +25,7 @@ defmodule GroupherServer.CMS.ArticleCollect do
     belongs_to(:user, User, foreign_key: :user_id)
     embeds_many(:collect_folders, CollectFolder, on_replace: :delete)
 
-    article_belongs_to()
+    article_belongs_to_fields()
     timestamps(type: :utc_datetime)
   end
 

lib/groupher_server/cms/article_comment.ex

@@ -6,14 +6,15 @@ defmodule GroupherServer.CMS.ArticleComment do
   use Accessible
 
   import Ecto.Changeset
+  import Helper.Utils, only: [get_config: 2]
   import GroupherServer.CMS.Helper.Macros
   import GroupherServer.CMS.Helper.Utils, only: [articles_foreign_key_constraint: 1]
 
   alias GroupherServer.{Accounts, CMS}
   alias CMS.{Embeds, ArticleCommentUpvote}
 
   # alias Helper.HTML
-  @article_threads CMS.Community.article_threads()
+  @article_threads get_config(:article, :article_threads)
 
   @required_fields ~w(body_html author_id)a
   @optional_fields ~w(reply_to_id replies_count is_folded is_deleted floor is_article_author)a
@@ -77,7 +78,7 @@ defmodule GroupherServer.CMS.ArticleComment do
 
     has_many(:upvotes, {"articles_comments_upvotes", ArticleCommentUpvote})
 
-    article_belongs_to()
+    article_belongs_to_fields()
     timestamps(type: :utc_datetime)
   end
 

lib/groupher_server/cms/article_pinned_comment.ex

@@ -6,14 +6,15 @@ defmodule GroupherServer.CMS.ArticlePinnedComment do
   use Accessible
 
   import Ecto.Changeset
+  import Helper.Utils, only: [get_config: 2]
   import GroupherServer.CMS.Helper.Macros
   import GroupherServer.CMS.Helper.Utils, only: [articles_foreign_key_constraint: 1]
 
   alias GroupherServer.CMS
   alias CMS.ArticleComment
 
   # alias Helper.HTML
-  @article_threads CMS.Community.article_threads()
+  @article_threads get_config(:article, :article_threads)
 
   @required_fields ~w(article_comment_id)a
   # @optional_fields ~w(post_id job_id repo_id)a
@@ -24,7 +25,7 @@ defmodule GroupherServer.CMS.ArticlePinnedComment do
   schema "articles_pinned_comments" do
     belongs_to(:article_comment, ArticleComment, foreign_key: :article_comment_id)
 
-    article_belongs_to()
+    article_belongs_to_fields()
     timestamps(type: :utc_datetime)
   end
 

lib/groupher_server/cms/article_upvote.ex

@@ -3,14 +3,16 @@ defmodule GroupherServer.CMS.ArticleUpvote do
   alias __MODULE__
 
   use Ecto.Schema
+
   import Ecto.Changeset
+  import Helper.Utils, only: [get_config: 2]
   import GroupherServer.CMS.Helper.Macros
   import GroupherServer.CMS.Helper.Utils, only: [articles_foreign_key_constraint: 1]
 
   alias GroupherServer.{Accounts, CMS}
   alias Accounts.User
 
-  @article_threads CMS.Community.article_threads()
+  @article_threads get_config(:article, :article_threads)
 
   @required_fields ~w(user_id)a
   @optional_fields ~w(thread)a
@@ -22,7 +24,7 @@ defmodule GroupherServer.CMS.ArticleUpvote do
     field(:thread, :string)
     belongs_to(:user, User, foreign_key: :user_id)
 
-    article_belongs_to()
+    article_belongs_to_fields()
     timestamps(type: :utc_datetime)
   end
 

lib/groupher_server/cms/article_user_emotion.ex

@@ -29,7 +29,7 @@ defmodule GroupherServer.CMS.ArticleUserEmotion do
   alias GroupherServer.{Accounts, CMS}
 
   @supported_emotions get_config(:article, :supported_emotions)
-  @article_threads CMS.Community.article_threads()
+  @article_threads get_config(:article, :article_threads)
 
   @required_fields ~w(user_id recived_user_id)a
   @optional_fields Enum.map(@article_threads, &:"#{&1}_id") ++
@@ -41,7 +41,7 @@ defmodule GroupherServer.CMS.ArticleUserEmotion do
     belongs_to(:user, Accounts.User, foreign_key: :user_id)
 
     emotion_fields()
-    article_belongs_to()
+    article_belongs_to_fields()
     timestamps(type: :utc_datetime)
   end
 

lib/groupher_server/cms/community.ex

@@ -4,29 +4,25 @@ defmodule GroupherServer.CMS.Community do
 
   use Ecto.Schema
   import Ecto.Changeset
+  import GroupherServer.CMS.Helper.Macros
 
   alias GroupherServer.{Accounts, CMS}
 
   alias CMS.{
     Category,
-    Post,
-    Repo,
-    Job,
     CommunityThread,
     CommunitySubscriber,
     CommunityEditor,
     CommunityWiki,
     CommunityCheatsheet
   }
 
-  @article_threads [:post, :job, :repo]
   @max_pinned_article_count_per_thread 2
 
   @required_fields ~w(title desc user_id logo raw)a
   # @required_fields ~w(title desc user_id)a
   @optional_fields ~w(label geo_info index aka)a
 
-  def article_threads, do: @article_threads
   def max_pinned_article_count_per_thread, do: @max_pinned_article_count_per_thread
 
   schema "communities" do
@@ -59,30 +55,7 @@ defmodule GroupherServer.CMS.Community do
       # on_replace: :delete
     )
 
-    many_to_many(
-      :posts,
-      Post,
-      join_through: "communities_posts",
-      join_keys: [community_id: :id, post_id: :id]
-    )
-
-    many_to_many(
-      :repos,
-      Repo,
-      join_through: "communities_repos",
-      join_keys: [community_id: :id, repo_id: :id]
-    )
-
-    many_to_many(
-      :jobs,
-      Job,
-      join_through: "communities_jobs",
-      join_keys: [community_id: :id, job_id: :id]
-    )
-
-    # posts_managers
-    # jobs_managers
-    # tuts_managers
+    community_article_fields()
     #
     # posts_block_list ...
     timestamps(type: :utc_datetime)

lib/groupher_server/cms/delegates/abuse_report.ex

@@ -3,7 +3,7 @@ defmodule GroupherServer.CMS.Delegate.AbuseReport do
   CURD and operations for article comments
   """
   import Ecto.Query, warn: false
-  import Helper.Utils, only: [done: 1, strip_struct: 1]
+  import Helper.Utils, only: [done: 1, strip_struct: 1, get_config: 2]
 
   import GroupherServer.CMS.Helper.Matcher2
   import ShortMaps
@@ -17,9 +17,9 @@ defmodule GroupherServer.CMS.Delegate.AbuseReport do
 
   alias Ecto.Multi
 
+  @article_threads get_config(:article, :article_threads)
   @report_threshold_for_fold ArticleComment.report_threshold_for_fold()
 
-  @article_threads Community.article_threads()
   @export_author_keys [:id, :login, :nickname, :avatar]
   @export_article_keys [:id, :title, :digest, :upvotes_count, :views]
   @export_report_keys [