refactor(article-comments): add is_article_author && meta

Author: mydearxym

lib/groupher_server/cms/article_comment.ex

@@ -82,6 +82,7 @@ defmodule GroupherServer.CMS.ArticleComment do
     article_comment
     |> cast(attrs, @required_fields ++ @optional_fields)
     |> cast_embed(:emotions, required: true, with: &Embeds.ArticleCommentEmotion.changeset/2)
+    |> cast_embed(:meta, required: true, with: &Embeds.ArticleCommentMeta.changeset/2)
     |> validate_required(@required_fields)
     |> generl_changeset
   end
@@ -90,7 +91,7 @@ defmodule GroupherServer.CMS.ArticleComment do
   def update_changeset(%ArticleComment{} = article_comment, attrs) do
     article_comment
     |> cast(attrs, @required_fields ++ @updatable_fields)
-    # |> cast_embed(:emotions, required: false, with: &Embeds.ArticleCommentEmotion.changeset/2)
+    |> cast_embed(:meta, required: true, with: &Embeds.ArticleCommentMeta.changeset/2)
     |> generl_changeset
   end
 

lib/groupher_server/cms/author.ex

@@ -3,10 +3,11 @@ defmodule GroupherServer.CMS.Author do
   alias __MODULE__
 
   use Ecto.Schema
+  use Accessible
+
   import Ecto.Changeset
 
   alias GroupherServer.{Accounts, CMS}
-
   alias CMS.Post
 
   @type t :: %Author{}

lib/groupher_server/cms/delegates/article_comment.ex

@@ -8,6 +8,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleComment do
   import GroupherServer.CMS.Utils.Matcher2
   import ShortMaps
 
+  alias Helper.Types, as: T
   alias Helper.{ORM, QueryBuilder}
   alias GroupherServer.{Accounts, CMS, Repo}
 
@@ -33,6 +34,8 @@ defmodule GroupherServer.CMS.Delegate.ArticleComment do
   @delete_hint ArticleComment.delete_hint()
   @report_threshold_for_fold ArticleComment.report_threshold_for_fold()
 
+  @default_comment_meta Embeds.ArticleCommentMeta.default_meta()
+
   @doc """
   list paged article comments
   """
@@ -317,10 +320,10 @@ defmodule GroupherServer.CMS.Delegate.ArticleComment do
   end
 
   @doc "upvote a comment"
-  # TODO: user has upvoted logic, move to GraphQL
   def upvote_article_comment(comment_id, %User{id: user_id}) do
     with {:ok, comment} <- ORM.find(ArticleComment, comment_id),
          false <- comment.is_deleted do
+      # IO.inspect(comment, label: "the comment")
       Multi.new()
       |> Multi.run(:create_comment_upvote, fn _, _ ->
         ORM.create(ArticleCommentUpvote, %{article_comment_id: comment.id, user_id: user_id})
@@ -330,15 +333,68 @@ defmodule GroupherServer.CMS.Delegate.ArticleComment do
         upvotes_count = Repo.aggregate(count_query, :count)
         ORM.update(comment, %{upvotes_count: upvotes_count})
       end)
+      |> Multi.run(:check_article_author_upvoted, fn _, _ ->
+        with {:ok, article} = get_full_comment(comment_id) do
+          is_article_author_upvoted = article.author.id == user_id
+
+          case is_article_author_upvoted do
+            true ->
+              new_meta =
+                comment.meta
+                |> Map.from_struct()
+                |> Map.merge(%{is_article_author_upvoted: true})
+
+              comment |> ORM.update(%{meta: new_meta})
+
+            false ->
+              {:ok, :pass}
+          end
+        end
+      end)
       |> Repo.transaction()
       |> upsert_comment_result()
     end
   end
 
+  @spec get_full_comment(String.t()) :: {:ok, T.article_info()} | {:error, nil}
+  defp get_full_comment(comment_id) do
+    query = from(c in ArticleComment, where: c.id == ^comment_id, preload: :post, preload: :job)
+
+    with {:ok, comment} <- Repo.one(query) |> done() do
+      extract_article_info(comment)
+    end
+  end
+
+  defp extract_article_info(%ArticleComment{post: %Post{} = post}) when not is_nil(post) do
+    do_extract_article_info(:post, post)
+  end
+
+  defp extract_article_info(%ArticleComment{job: %Job{} = job}) when not is_nil(job) do
+    do_extract_article_info(:job, job)
+  end
+
+  @spec do_extract_article_info(T.article_thread(), T.article_common()) :: {:ok, T.article_info()}
+  defp do_extract_article_info(thread, article) do
+    with {:ok, article_with_author} <- Repo.preload(article, author: :user) |> done(),
+         article_author <- get_in(article_with_author, [:author, :user]) do
+      #
+      article_info = %{title: article.title}
+
+      author_info = %{
+        id: article_author.id,
+        login: article_author.login,
+        nickname: article_author.nickname
+      }
+
+      {:ok, %{thread: thread, article: article_info, author: author_info}}
+    end
+  end
+
   # creat article comment for parent or reply
   # set floor
   # TODO: parse editor-json
   # set default emotions
+  # TODO: meta
   defp do_create_comment(
          content,
          foreign_key,
@@ -358,7 +414,8 @@ defmodule GroupherServer.CMS.Delegate.ArticleComment do
           body_html: content,
           emotions: @default_emotions,
           floor: floor,
-          is_article_author: user_id == article_author_id
+          is_article_author: user_id == article_author_id,
+          meta: @default_comment_meta
         },
         foreign_key,
         article_id

lib/groupher_server/cms/embeds/article_comment_meta.ex

@@ -3,14 +3,14 @@ defmodule GroupherServer.CMS.Embeds.ArticleCommentMeta do
   general article comment meta info
   """
   use Ecto.Schema
+  import Ecto.Changeset
 
-  alias CMS.Embeds
+  @optional_fields ~w(is_article_author_upvoted is_solution report_count)a
 
   @default_meta %{
     is_article_author_upvoted: false,
     is_solution: false,
-    report_count: 0,
-    report_users: []
+    report_count: 0
   }
 
   @doc "for test usage"
@@ -21,6 +21,10 @@ defmodule GroupherServer.CMS.Embeds.ArticleCommentMeta do
     field(:is_solution, :boolean, default: false)
 
     field(:report_count, :integer, default: 0)
-    embeds_many(:report_users, Embeds.User, on_replace: :delete)
+  end
+
+  def changeset(struct, params) do
+    struct
+    |> cast(params, @optional_fields)
   end
 end

lib/groupher_server/cms/job.ex

@@ -3,6 +3,8 @@ defmodule GroupherServer.CMS.Job do
   alias __MODULE__
 
   use Ecto.Schema
+  use Accessible
+
   import Ecto.Changeset
 
   alias GroupherServer.CMS

lib/groupher_server/cms/post.ex

@@ -3,6 +3,8 @@ defmodule GroupherServer.CMS.Post do
   alias __MODULE__
 
   use Ecto.Schema
+  use Accessible
+
   import Ecto.Changeset
 
   alias GroupherServer.{CMS, Accounts}

lib/helper/types.ex

@@ -28,6 +28,19 @@ defmodule Helper.Types do
           company: nil | String.t()
         }
 
+  @type article_thread :: :post | :job
+  @type article_info :: %{
+          thread: article_thread,
+          article: %{
+            title: String.t()
+          },
+          author: %{
+            id: Integer.t(),
+            login: String.t(),
+            nickname: String.t()
+          }
+        }
+
   @typedoc """
   editor.js's header tool data format
   """

test/groupher_server/cms/article_comment_test.exs

@@ -4,12 +4,13 @@ defmodule GroupherServer.Test.CMS.ArticleComment do
   use GroupherServer.TestTools
 
   alias Helper.ORM
-  alias GroupherServer.CMS
+  alias GroupherServer.{Accounts, CMS}
 
-  alias CMS.{ArticleComment, Post, Job}
+  alias CMS.{ArticleComment, Embeds, Post, Job}
 
   @delete_hint CMS.ArticleComment.delete_hint()
   @report_threshold_for_fold ArticleComment.report_threshold_for_fold()
+  @default_comment_meta Embeds.ArticleCommentMeta.default_meta()
 
   setup do
     {:ok, user} = db_insert(:user)
@@ -21,7 +22,6 @@ defmodule GroupherServer.Test.CMS.ArticleComment do
   end
 
   describe "[basic article comment]" do
-    @tag :wip2
     test "post, job are supported by article comment.", ~m(user post job)a do
       post_comment_1 = "post_comment 1"
       post_comment_2 = "post_comment 2"
@@ -40,6 +40,12 @@ defmodule GroupherServer.Test.CMS.ArticleComment do
       assert List.first(post.article_comments).body_html == post_comment_1
       assert List.first(job.article_comments).body_html == job_comment_1
     end
+
+    @tag :wip2
+    test "comment should have default meta after create", ~m(user post)a do
+      {:ok, comment} = CMS.create_article_comment(:post, post.id, "post comment", user)
+      assert comment.meta |> Map.from_struct() |> Map.delete(:id) == @default_comment_meta
+    end
   end
 
   describe "[article comment floor]" do
@@ -112,6 +118,18 @@ defmodule GroupherServer.Test.CMS.ArticleComment do
       assert List.first(comment.upvotes).user_id == user.id
     end
 
+    @tag :wip2
+    test "article author upvote post comment will have flag", ~m(post user)a do
+      comment = "post_comment"
+      {:ok, comment} = CMS.create_article_comment(:post, post.id, comment, user)
+      {:ok, author_user} = ORM.find(Accounts.User, post.author.user.id)
+
+      CMS.upvote_article_comment(comment.id, author_user)
+
+      {:ok, comment} = ORM.find(ArticleComment, comment.id, preload: :upvotes)
+      assert comment.meta.is_article_author_upvoted
+    end
+
     @tag :wip
     test "user can upvote a job comment", ~m(user job)a do
       comment = "job_comment"
@@ -403,7 +421,7 @@ defmodule GroupherServer.Test.CMS.ArticleComment do
       {:ok, comment} = CMS.create_article_comment(:post, post.id, "commment", user)
       assert not comment.is_article_author
 
-      {:ok, author_user} = db_insert(:user, %{id: post.author_id})
+      {:ok, author_user} = db_insert(:user, %{id: post.author.user.id})
       {:ok, comment} = CMS.create_article_comment(:post, post.id, "commment", author_user)
       assert comment.is_article_author
     end