refactor(editor): adjust parent schema cast logic

Author: mydearxym

lib/helper/converter/editor_to_html/validator/editor_schema.ex

@@ -30,7 +30,7 @@ defmodule Helper.Converter.EditorToHTML.Validator.EditorSchema do
 
   def get("list") do
     [
-      parent: %{"mode" => [enum: @valid_list_mode]},
+      parent: %{"mode" => [enum: @valid_list_mode], "items" => [:list]},
       item: %{
         "checked" => [:boolean],
         "hideLabel" => [:boolean],

lib/helper/converter/editor_to_html/validator/index.ex

@@ -50,7 +50,7 @@ defmodule Helper.Converter.EditorToHTML.Validator do
   end
 
   # validate block which has mode and items
-  defp validate_block(%{"type" => type, "data" => %{"mode" => _, "items" => _} = data})
+  defp validate_block(%{"type" => type, "data" => data})
        when type in @complex_blocks do
     [parent: parent_schema, item: item_schema] = EditorSchema.get(type)
     validate_with(type, parent_schema, item_schema, data)
@@ -85,7 +85,8 @@ defmodule Helper.Converter.EditorToHTML.Validator do
   defp validate_with(block, parent_schema, item_schema, data) do
     case Schema.cast(parent_schema, data) do
       {:error, errors} ->
-        format_parse_error(block, errors)
+        {:error, message} = format_parse_error(block, errors)
+        raise %MatchError{term: {:error, message}}
 
       _ ->
         {:ok, :pass}

test/helper/converter/editor_to_html_test/header_test.exs

@@ -124,7 +124,7 @@ defmodule GroupherServer.Test.Helper.Converter.EditorToHTML.Header do
                }\">footer title content</div>\n</div>\n<div>"
     end
 
-    @tag :wip2
+    @tag :wip
     test "wrong header format data should have invalid hint" do
       json =
         Map.merge(@editor_json, %{

test/helper/converter/editor_to_html_test/index_test.exs

@@ -41,7 +41,7 @@ defmodule GroupherServer.Test.Helper.Converter.EditorToHTML do
       assert {:ok, _} = Parser.to_html(editor_string)
     end
 
-    @tag :wip2
+    @tag :wip
     test "invalid editorjs json fmt should raise error" do
       editor_json = %{
         "invalid_time" => 1_567_250_876_713,

test/helper/converter/editor_to_html_test/list_test.exs

@@ -39,6 +39,33 @@ defmodule GroupherServer.Test.Helper.Converter.EditorToHTML.List do
       IO.inspect(converted, label: "list converted")
     end
 
+    @editor_json %{
+      "time" => 1_567_250_876_713,
+      "blocks" => [
+        %{
+          "type" => "list",
+          "data" => %{
+            "invalid-mode" => "",
+            "items" => []
+          }
+        }
+      ],
+      "version" => "2.15.0"
+    }
+    @tag :wip2
+    test "invalid list mode parse should raise error message" do
+      {:ok, editor_string} = Jason.encode(@editor_json)
+      {:error, err_msg} = Parser.to_html(editor_string)
+
+      assert err_msg == [
+               %{
+                 block: "list",
+                 field: "mode",
+                 message: "should be: checklist | order_list | unorder_list"
+               }
+             ]
+    end
+
     @editor_json %{
       "time" => 1_567_250_876_713,
       "blocks" => [
@@ -61,7 +88,7 @@ defmodule GroupherServer.Test.Helper.Converter.EditorToHTML.List do
       ],
       "version" => "2.15.0"
     }
-    @tag :wip2
+    @tag :wip
     test "invalid list data parse should raise error message" do
       {:ok, editor_string} = Jason.encode(@editor_json)
       {:error, err_msg} = Parser.to_html(editor_string)