refactor: remove communitt_flag concept (#358)

* refactor: wip

* refactor: more tests

* fix: tests && warnings

Author: mydearxym

cover/excoveralls.json

@@ -80,7 +80,10 @@ defmodule GroupherServer.CMS do
   defdelegate paged_articles(queryable, filter, user), to: ArticleCURD
 
   defdelegate create_article(community, thread, attrs, user), to: ArticleCURD
-  defdelegate update_article(content, attrs), to: ArticleCURD
+  defdelegate update_article(article, attrs), to: ArticleCURD
+
+  defdelegate mark_delete_article(thread, id), to: ArticleCURD
+  defdelegate undo_mark_delete_article(thread, id), to: ArticleCURD
 
   defdelegate upvote_article(thread, article_id, user), to: ArticleUpvote
   defdelegate undo_upvote_article(thread, article_id, user), to: ArticleUpvote
@@ -99,11 +102,9 @@ defmodule GroupherServer.CMS do
 
   # ArticleCommunity
   # >> set flag on article, like: pin / unpin article
-  defdelegate set_community_flags(community_info, queryable, attrs), to: ArticleCommunity
   defdelegate pin_article(thread, id, community_id), to: ArticleCommunity
   defdelegate undo_pin_article(thread, id, community_id), to: ArticleCommunity
-
-  defdelegate lock_article_comment(content), to: ArticleCommunity
+  defdelegate lock_article_comment(article), to: ArticleCommunity
 
   # >> tag: set / unset
   defdelegate set_tag(thread, tag, content_id), to: ArticleCommunity

lib/groupher_server/cms/cms.ex

@@ -14,19 +14,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleCommunity do
   alias Helper.Types, as: T
   alias Helper.ORM
 
-  alias GroupherServer.CMS.{
-    Embeds,
-    Community,
-    Post,
-    PostCommunityFlag,
-    Job,
-    JobCommunityFlag,
-    RepoCommunityFlag,
-    Tag,
-    PinnedArticle
-  }
-
-  alias GroupherServer.CMS.Repo, as: CMSRepo
+  alias GroupherServer.CMS.{Embeds, Community, Tag, PinnedArticle}
   alias GroupherServer.Repo
 
   alias Ecto.Multi
@@ -68,41 +56,6 @@ defmodule GroupherServer.CMS.Delegate.ArticleCommunity do
   ########
   ########
   ########
-  ########
-  ########
-
-  @doc """
-  trash / untrash articles
-  """
-  def set_community_flags(%Community{id: cid}, content, attrs) do
-    with {:ok, content} <- ORM.find(content.__struct__, content.id),
-         {:ok, record} <- insert_flag_record(content, cid, attrs) do
-      {:ok, struct(content, %{trash: record.trash})}
-    end
-  end
-
-  def set_community_flags(community_id, content, attrs) do
-    with {:ok, content} <- ORM.find(content.__struct__, content.id),
-         {:ok, community} <- ORM.find(Community, community_id),
-         {:ok, record} <- insert_flag_record(content, community.id, attrs) do
-      {:ok, struct(content, %{trash: record.trash})}
-    end
-  end
-
-  defp insert_flag_record(%Post{id: post_id}, community_id, attrs) do
-    clauses = ~m(post_id community_id)a
-    PostCommunityFlag |> ORM.upsert_by(clauses, Map.merge(attrs, clauses))
-  end
-
-  defp insert_flag_record(%Job{id: job_id}, community_id, attrs) do
-    clauses = ~m(job_id community_id)a
-    JobCommunityFlag |> ORM.upsert_by(clauses, Map.merge(attrs, clauses))
-  end
-
-  defp insert_flag_record(%CMSRepo{id: repo_id}, community_id, attrs) do
-    clauses = ~m(repo_id community_id)a
-    RepoCommunityFlag |> ORM.upsert_by(clauses, Map.merge(attrs, clauses))
-  end
 
   @doc """
   mirror article to other community