refactor(article-curd): update tags

Author: mydearxym

lib/groupher_server/cms/delegates/article_curd.ex

@@ -95,50 +95,6 @@ defmodule GroupherServer.CMS.Delegate.ArticleCURD do
     end
   end
 
-  #  for create content step in Multi.new
-  defp exec_create_content(target, attrs, %Author{id: aid}, %Community{id: cid}) do
-    target
-    |> struct()
-    |> target.changeset(attrs)
-    |> Ecto.Changeset.put_change(:author_id, aid)
-    |> Ecto.Changeset.put_change(:origial_community_id, integerfy(cid))
-    |> Repo.insert()
-  end
-
-  defp exec_set_topic(thread, id, %{topic: topic}) do
-    ArticleOperation.set_topic(%Topic{title: topic}, thread, id)
-  end
-
-  # if topic is not provide, use posts as default
-  defp exec_set_topic(thread, id, _attrs) do
-    ArticleOperation.set_topic(%Topic{title: "posts"}, thread, id)
-  end
-
-  defp exec_set_tag(thread, id, %{tags: tags}) do
-    try do
-      Enum.each(tags, fn tag ->
-        {:ok, _} = ArticleOperation.set_tag(thread, %Tag{id: tag.id}, id)
-      end)
-
-      {:ok, "psss"}
-    rescue
-      _ -> {:error, [message: "set tag", code: ecode(:create_fails)]}
-    end
-  end
-
-  defp exec_set_tag(_thread, _id, _attrs), do: {:ok, :pass}
-
-  # TODO:  flag 逻辑似乎有问题
-  defp exec_set_community_flag(%Community{} = community, content, %{flag: _flag}) do
-    ArticleOperation.set_community_flags(community, content, %{
-      trash: false
-    })
-  end
-
-  defp exec_set_community_flag(_community, _content, _action) do
-    {:ok, :pass}
-  end
-
   @doc """
   update a content(post/job ...)
   """
@@ -148,7 +104,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleCURD do
       ORM.update(content, args)
     end)
     |> Multi.run(:update_tag, fn _, _ ->
-      update_tags(content, args.tags)
+      exec_update_tags(content, args.tags)
     end)
     |> Repo.transaction()
     |> update_content_result()
@@ -446,60 +402,85 @@ defmodule GroupherServer.CMS.Delegate.ArticleCURD do
     {:error, [message: "log action", code: ecode(:create_fails)]}
   end
 
-  defp update_tags(_content, tags_ids) when length(tags_ids) == 0, do: {:ok, :pass}
+  # except Job, other content will just pass, should use set_tag function instead
+  # defp exec_update_tags(_, _tags_ids), do: {:ok, :pass}
 
-  # Job is special, the tags in job only represent city, so everytime update
-  # tags on job content, should be override the old ones, in this way, every
-  # communiies contains this job will have the same city info
-  defp update_tags(%CMS.Job{} = content, tags_ids) do
-    with {:ok, content} <- ORM.find(CMS.Job, content.id, preload: :tags) do
-      concat_tags(content, tags_ids)
-    end
+  defp update_content_result({:ok, %{update_content: result}}), do: {:ok, result}
+  defp update_content_result({:error, :update_content, result, _steps}), do: {:error, result}
+  defp update_content_result({:error, :update_tag, result, _steps}), do: {:error, result}
+
+  defp content_id(:post, id), do: %{post_id: id}
+  defp content_id(:job, id), do: %{job_id: id}
+  defp content_id(:repo, id), do: %{repo_id: id}
+  defp content_id(:video, id), do: %{video_id: id}
+
+  #  for create content step in Multi.new
+  defp exec_create_content(target, attrs, %Author{id: aid}, %Community{id: cid}) do
+    target
+    |> struct()
+    |> target.changeset(attrs)
+    |> Ecto.Changeset.put_change(:author_id, aid)
+    |> Ecto.Changeset.put_change(:origial_community_id, integerfy(cid))
+    |> Repo.insert()
   end
 
-  defp update_tags(%CMS.Post{} = content, tags_ids) do
-    with {:ok, content} <- ORM.find(CMS.Post, content.id, preload: :tags) do
-      concat_tags(content, tags_ids)
-    end
+  defp exec_set_topic(thread, id, %{topic: topic}) do
+    ArticleOperation.set_topic(%Topic{title: topic}, thread, id)
   end
 
-  defp update_tags(%CMS.Video{} = content, tags_ids) do
-    with {:ok, content} <- ORM.find(CMS.Video, content.id, preload: :tags) do
-      concat_tags(content, tags_ids)
-    end
+  # if topic is not provide, use posts as default
+  defp exec_set_topic(thread, id, _attrs) do
+    ArticleOperation.set_topic(%Topic{title: "posts"}, thread, id)
   end
 
-  # except Job, other content will just pass, should use set_tag function instead
-  defp update_tags(_, _tags_ids), do: {:ok, :pass}
+  defp exec_set_tag(thread, id, %{tags: tags}) do
+    try do
+      Enum.each(tags, fn tag ->
+        {:ok, _} = ArticleOperation.set_tag(thread, %Tag{id: tag.id}, id)
+      end)
 
-  defp concat_tags(content, tags_ids) do
-    tags =
-      Enum.reduce(tags_ids, [], fn t, acc ->
-        {:ok, tag} = ORM.find(Tag, t.id)
+      {:ok, "psss"}
+    rescue
+      _ -> {:error, [message: "set tag", code: ecode(:create_fails)]}
+    end
+  end
 
-        case tag.title == "refined" do
-          true ->
-            acc
+  defp exec_set_tag(_thread, _id, _attrs), do: {:ok, :pass}
 
-          false ->
-            acc ++ [tag]
-        end
-      end)
+  # TODO:  flag 逻辑似乎有问题
+  defp exec_set_community_flag(%Community{} = community, content, %{flag: _flag}) do
+    ArticleOperation.set_community_flags(community, content, %{
+      trash: false
+    })
+  end
 
-    content
-    |> Ecto.Changeset.change()
-    |> Ecto.Changeset.put_assoc(:tags, tags)
-    |> Repo.update()
+  defp exec_set_community_flag(_community, _content, _action) do
+    {:ok, :pass}
   end
 
-  defp update_content_result({:ok, %{update_content: result}}), do: {:ok, result}
-  defp update_content_result({:error, :update_content, result, _steps}), do: {:error, result}
-  defp update_content_result({:error, :update_tag, result, _steps}), do: {:error, result}
+  defp exec_update_tags(_content, tags_ids) when length(tags_ids) == 0, do: {:ok, :pass}
 
-  defp content_id(:post, id), do: %{post_id: id}
-  defp content_id(:job, id), do: %{job_id: id}
-  defp content_id(:repo, id), do: %{repo_id: id}
-  defp content_id(:video, id), do: %{video_id: id}
+  defp exec_update_tags(content, tags_ids) do
+    with {:ok, content} <- ORM.find(content.__struct__, content.id, preload: :tags) do
+      tags =
+        Enum.reduce(tags_ids, [], fn t, acc ->
+          {:ok, tag} = ORM.find(Tag, t.id)
+
+          case tag.title == "refined" do
+            true ->
+              acc
+
+            false ->
+              acc ++ [tag]
+          end
+        end)
+
+      content
+      |> Ecto.Changeset.change()
+      |> Ecto.Changeset.put_assoc(:tags, tags)
+      |> Repo.update()
+    end
+  end
 
   defp nofify_admin_new_content(%{id: id} = result) do
     target = result.__struct__