refactor(deploy): move guardian key to secret

Author: mydearxym

config/ci.exs

@@ -9,6 +9,10 @@ config :groupher_server, GroupherServerWeb.Endpoint,
 
 config :logger, :console, format: "[$level] $message\n"
 
+config :groupher_server, Helper.Guardian,
+  issuer: "groupher_server",
+  secret_key: "kSTPDbCUSRhiEmv86eYMUplL7xI5fDa/+6MWKzK2VYGxjwL0XGHHVJiSPNPe9hJe"
+
 config :phoenix, :stacktrace_depth, 20
 
 # Configure your database

config/config.exs

@@ -22,13 +22,7 @@ config :logger, :console,
 
 config :phoenix, :json_library, Jason
 
-# TODO move this config to secret later
-config :groupher_server, Helper.Guardian,
-  issuer: "groupher_server",
-  secret_key: "kSTPDbCUSRhiEmv86eYMUplL7xI5fDa/+6MWKzK2VYGxjwL0XGHHVJiSPNPe9hJe"
-
 config :groupher_server, :mix_test_watch, exclude: [~r/docs\/.*/, ~r/deps\/.*/, ~r/mix.exs/]
-# secret_key: {:system, "GUARDIAN_DEMO_SECRET_KEY"}
 
 config :pre_commit, commands: ["format"], verbose: false
 # Import environment specific config. This must remain at the bottom

config/dev.exs

@@ -41,6 +41,10 @@ config :phoenix, :stacktrace_depth, 20
 config :groupher_server, GroupherServerWeb.Endpoint,
   secret_key_base: System.get_env("SECRET_KEY_BASE")
 
+config :groupher_server, Helper.Guardian,
+  issuer: "groupher_server",
+  secret_key: System.get_env("GUARDIAN_KEY")
+
 # should use RDS 内网地址
 config :groupher_server, GroupherServer.Repo,
   adapter: Ecto.Adapters.Postgres,

config/prod.exs

@@ -68,6 +68,10 @@ config :logger, :console, format: "[$level] $message\n"
 config :groupher_server, GroupherServerWeb.Endpoint,
   secret_key_base: System.get_env("SECRET_KEY_BASE")
 
+config :groupher_server, Helper.Guardian,
+  issuer: "groupher_server",
+  secret_key: System.get_env("GUARDIAN_KEY")
+
 # You can generate a new secret by running:
 # mix phx.gen.secret
 # should use RDS 内网地址

config/test.exs

@@ -9,6 +9,10 @@ config :groupher_server, GroupherServerWeb.Endpoint,
 # Print only warnings and errors during test
 config :logger, level: :warn
 
+config :groupher_server, Helper.Guardian,
+  issuer: "groupher_server",
+  secret_key: "kSTPDbCUSRhiEmv86eYMUplL7xI5fDa/+6MWKzK2VYGxjwL0XGHHVJiSPNPe9hJe"
+
 config :groupher_server, :test,
   # 成都电信 ip, for test use
   remote_ip: "171.223.96.88"

lib/helper/guardian.ex

@@ -2,6 +2,8 @@ defmodule Helper.Guardian do
   @moduledoc """
   This module defines some helper function used by
   encode/decode jwt
+  NOTE:  You can use `mix guardian.gen.secret` to get one
+  see: https://github.com/ueberauth/guardian
   """
   use Guardian, otp_app: :groupher_server