feat(blog-thread): whole-workflow (#390)

* refactor(macros): basic table setup

* feat(blog-thread): basic blog tests

* feat(blog-thread): extract paged_macros

* feat(blog-thread): extract article in mock factory

* feat(blog-thread): fix broken test cause by match order

* feat(blog-thread): fix broken test

* feat(blog-thread): tests for blog

* feat(blog-thread): fix test

* feat(blog-thread): fix test

* feat(blog-thread): test wip

* feat(blog-thread): test wip

* feat(blog-thread): remove matcher old wip

* feat(blog-thread): remove matcher old wip

* feat(blog-thread): remove matcher old wip

* feat(blog-thread): remove matcher old debug

* feat(blog-thread): remove old post_comment && re-org PassportLoader

* feat(blog-thread): remove old publish comment & macther

* feat(blog-thread): wip

* feat(blog-thread): clean up old post-comment

* feat(blog-thread): clean up wip

* feat(blog-thread): clean up wip

* fix(passport): article preload loader

* chore: wip

* chore: wip

* chore: wip

* chore: wip

* refactor(blog-thread): add more test

* refactor(blog-thread): improve comment fold test

Author: mydearxym

config/config.exs

@@ -62,13 +62,14 @@ config :groupher_server, :customization,
 
 config :groupher_server, :article,
   # NOTE: do not change unless you know what you are doing
-  threads: [:post, :job, :repo],
+  threads: [:post, :job, :repo, :blog],
   # in this period, paged articles will sort front if non-article-author commented
   # 在此时间段内，一旦有非文章作者的用户评论，该文章就会排到前面
   active_period_days: %{
     post: 10,
     job: 10,
-    repo: 10
+    repo: 10,
+    blog: 10
   },
 
   # NOTE: if you want to add/remove emotion, just edit the list below

lib/groupher_server/accounts/accounts.ex

@@ -47,7 +47,6 @@ defmodule GroupherServer.Accounts do
 
   # publish
   defdelegate paged_published_articles(user, thread, filter), to: Publish
-  defdelegate published_comments(user, thread, filter), to: Publish
   defdelegate paged_published_article_comments(user, thread, filter), to: Publish
   defdelegate paged_published_article_comments(user, thread), to: Publish
   defdelegate update_published_states(user, thread), to: Publish

lib/groupher_server/accounts/delegates/publish.ex

@@ -8,7 +8,6 @@ defmodule GroupherServer.Accounts.Delegate.Publish do
   import ShortMaps
 
   import GroupherServer.CMS.Helper.Matcher
-  import GroupherServer.CMS.Helper.MatcherOld
 
   alias GroupherServer.Accounts.Model.{Embeds, User}
   alias GroupherServer.CMS.Model.ArticleComment
@@ -89,20 +88,4 @@ defmodule GroupherServer.Accounts.Delegate.Publish do
       |> done()
     end
   end
-
-  @doc """
-  get paged published comments of a user
-  """
-  def published_comments(%User{id: user_id}, thread, %{page: page, size: size} = filter) do
-    with {:ok, user} <- ORM.find(User, user_id),
-         {:ok, content} <- match_action(thread, :comment) do
-      content.reactor
-      |> join(:inner, [comment], author in assoc(comment, :author))
-      |> where([comment, author], author.id == ^user.id)
-      |> select([comment, author], comment)
-      |> QueryBuilder.filter_pack(filter)
-      |> ORM.paginater(~m(page size)a)
-      |> done()
-    end
-  end
 end

lib/groupher_server/accounts/models/collect_folder.ex

@@ -3,6 +3,7 @@ defmodule GroupherServer.Accounts.Model.CollectFolder do
   alias __MODULE__
 
   use Ecto.Schema
+  use Accessible
   import Ecto.Changeset
 
   alias GroupherServer.{Accounts, CMS}

lib/groupher_server/cms/cms.ex

@@ -18,7 +18,6 @@ defmodule GroupherServer.CMS do
     ArticleCommentAction,
     ArticleCommentEmotion,
     ArticleTag,
-    CommentCURD,
     CommunitySync,
     CommunityCURD,
     CommunityOperation,
@@ -162,14 +161,6 @@ defmodule GroupherServer.CMS do
   ###################
   ###################
   ###################
-  defdelegate create_comment(thread, content_id, args, user), to: CommentCURD
-  defdelegate update_comment(thread, id, args, user), to: CommentCURD
-  defdelegate delete_comment(thread, content_id), to: CommentCURD
-  defdelegate paged_replies(thread, comment, user), to: CommentCURD
-  defdelegate reply_comment(thread, comment, args, user), to: CommentCURD
-
-  defdelegate paged_comments(thread, content_id, filters), to: CommentCURD
-  defdelegate paged_comments_participators(thread, content_id, filters), to: CommentCURD
 
   # TODO: move report to abuse report module
   defdelegate report_article(thread, article_id, reason, attr, user), to: AbuseReport

lib/groupher_server/cms/delegates/article_comment.ex

@@ -3,7 +3,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleComment do
   CURD and operations for article comments
   """
   import Ecto.Query, warn: false
-  import Helper.Utils, only: [done: 1, ensure: 2, get_config: 2]
+  import Helper.Utils, only: [done: 1, ensure: 2]
   import Helper.ErrorCode
 
   import GroupherServer.CMS.Delegate.Helper, only: [mark_viewer_emotion_states: 3]
@@ -19,8 +19,6 @@ defmodule GroupherServer.CMS.Delegate.ArticleComment do
   alias CMS.Model.{ArticleComment, ArticlePinnedComment, Embeds}
   alias Ecto.Multi
 
-  @article_threads get_config(:article, :threads)
-
   @max_participator_count ArticleComment.max_participator_count()
   @default_emotions Embeds.ArticleCommentEmotion.default_emotions()
   @delete_hint ArticleComment.delete_hint()
@@ -383,7 +381,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleComment do
     Map.merge(paged_comments, %{entries: entries})
   end
 
-  defp set_question_flag_ifneed(%{is_question: true} = article, %ArticleComment{} = comment) do
+  defp set_question_flag_ifneed(%{is_question: true} = _article, %ArticleComment{} = comment) do
     ORM.update(comment, %{is_for_question: true})
   end
 
@@ -405,7 +403,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleComment do
   defp result({:ok, %{mark_solution: result}}), do: {:ok, result}
 
   defp result({:error, :create_article_comment, result, _steps}) do
-    raise_error(:create_comment, result)
+    raise_error(:create_article_comment, result)
   end
 
   defp result({:error, _, result, _steps}), do: {:error, result}

lib/groupher_server/cms/delegates/article_comment_action.ex

@@ -361,7 +361,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleCommentAction do
   defp result({:ok, %{delete_article_comment: result}}), do: {:ok, result}
 
   defp result({:error, :create_article_comment, result, _steps}) do
-    raise_error(:create_comment, result)
+    raise_error(:create_article_comment, result)
   end
 
   defp result({:error, :add_participator, result, _steps}) do