Skip to content
This repository was archived by the owner on Nov 8, 2022. It is now read-only.

Commit 7ad22ac

Browse files
committed
chore(clean up): private raw in mailer template, rm unsed fields in user
1 parent cae8898 commit 7ad22ac

File tree

5 files changed

+11
-9
lines changed

5 files changed

+11
-9
lines changed

lib/groupher_server/accounts/delegates/profile.ex

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -153,10 +153,12 @@ defmodule GroupherServer.Accounts.Delegate.Profile do
153153
defp register_github_result({:ok, %{create_user: create_user}}) do
154154
{:ok, user} = ORM.find(User, create_user.id, preload: :github_profile)
155155

156-
Email.welcome(user)
157-
Email.notify_admin(user, :new_register)
156+
with {:ok, result} <- gen_token(user) do
157+
Email.welcome(user)
158+
Email.notify_admin(user, :new_register)
158159

159-
gen_token(user)
160+
{:ok, result}
161+
end
160162
end
161163

162164
defp register_github_result({:error, :create_user, %Ecto.Changeset{} = result, _steps}),

lib/groupher_server/accounts/user.ex

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,9 @@ defmodule GroupherServer.Accounts.User do
6767

6868
has_many(:favorite_categories, {"favorite_categories", FavoriteCategory})
6969

70-
field(:sponsor_member, :boolean)
71-
field(:paid_member, :boolean)
72-
field(:platinum_member, :boolean)
70+
# field(:sponsor_member, :boolean)
71+
# field(:paid_member, :boolean)
72+
# field(:platinum_member, :boolean)
7373

7474
has_one(:customization, Customization)
7575
has_one(:purchase, Purchase)

lib/groupher_server/mailer/templates/admin_new_register.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ defmodule GroupherServer.Email.Templates.AdminNewRegister do
6969
"""
7070
end
7171

72-
def raw() do
72+
defp raw() do
7373
"""
7474
<mjml>
7575
<mj-head>

lib/groupher_server/mailer/templates/nofity_admin_register.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ defmodule GroupherServer.Email.Templates.NotifyAdminRegister do
6969
"""
7070
end
7171

72-
def raw() do
72+
defp raw() do
7373
"""
7474
<mjml>
7575
<mj-head>

lib/groupher_server/mailer/templates/notify_admin_payment.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -513,7 +513,7 @@ defmodule GroupherServer.Email.Templates.NotifyAdminPayment do
513513
"""
514514
end
515515

516-
def raw() do
516+
defp raw() do
517517
"""
518518
<mjml>
519519
<mj-head>

0 commit comments

Comments
 (0)