Skip to content
This repository was archived by the owner on Nov 8, 2022. It is now read-only.

Commit 5a31709

Browse files
authored
Merge pull request #261 from coderplanets/upgrade-absinthe
chore(deps): upgrade absinthe to latest (1.6)
2 parents b1db245 + d70888f commit 5a31709

30 files changed

+77
-82
lines changed

lib/groupher_server/mailer/email.ex

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,10 @@ defmodule GroupherServer.Email do
77
import Bamboo.Email
88
import Helper.Utils, only: [get_config: 2]
99

10-
alias GroupherServer.{Accounts, Billing, CMS, Email, Mailer}
10+
alias GroupherServer.{Accounts, Billing, Email, Mailer}
1111

1212
alias Accounts.User
1313
alias Billing.BillRecord
14-
# alias CMS.{Post, Job, Repo, Video}
1514
alias Email.Templates
1615
alias Mailer
1716

lib/groupher_server_web/controller/og_controller.ex

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ defmodule GroupherServerWeb.Controller.OG do
2626
error_response(conn, url)
2727
end
2828

29-
defp ok_response(conn, url, %OpenGraph{title: nil, description: description} = info)
29+
defp ok_response(conn, _url, %OpenGraph{title: nil, description: description} = info)
3030
when not is_nil(description) do
3131
json(conn, %{
3232
success: 1,
@@ -40,7 +40,7 @@ defmodule GroupherServerWeb.Controller.OG do
4040
})
4141
end
4242

43-
defp ok_response(conn, url, info) do
43+
defp ok_response(conn, _url, info) do
4444
json(conn, %{
4545
success: 1,
4646
meta: %{

lib/groupher_server_web/schema/account/account_queries.ex

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ defmodule GroupherServerWeb.Schema.Account.Queries do
7171
resolve(&R.Accounts.list_favorite_categories/3)
7272
end
7373

74-
@doc "paged stared posts"
74+
@desc "paged stared posts"
7575
field :stared_posts, :paged_posts do
7676
arg(:user_id, non_null(:id))
7777
arg(:filter, non_null(:paged_filter))
@@ -81,7 +81,7 @@ defmodule GroupherServerWeb.Schema.Account.Queries do
8181
resolve(&R.Accounts.stared_contents/3)
8282
end
8383

84-
@doc "paged stared jobs"
84+
@desc "paged stared jobs"
8585
field :stared_jobs, :paged_jobs do
8686
arg(:user_id, non_null(:id))
8787
arg(:filter, non_null(:paged_filter))
@@ -91,7 +91,7 @@ defmodule GroupherServerWeb.Schema.Account.Queries do
9191
resolve(&R.Accounts.stared_contents/3)
9292
end
9393

94-
@doc "paged stared videos"
94+
@desc "paged stared videos"
9595
field :stared_videos, :paged_videos do
9696
arg(:user_id, non_null(:id))
9797
arg(:filter, non_null(:paged_filter))

lib/groupher_server_web/schema/account/account_types.ex

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -100,23 +100,23 @@ defmodule GroupherServerWeb.Schema.Account.Types do
100100
resolve(&R.Accounts.editable_communities/3)
101101
end
102102

103-
@doc "get follower users count"
103+
@desc "get follower users count"
104104
field :followers_count, :integer do
105105
arg(:count, :count_type, default_value: :count)
106106

107107
resolve(dataloader(Accounts, :followers))
108108
middleware(M.ConvertToInt)
109109
end
110110

111-
@doc "get following users count"
111+
@desc "get following users count"
112112
field :followings_count, :integer do
113113
arg(:count, :count_type, default_value: :count)
114114

115115
resolve(dataloader(Accounts, :followings))
116116
middleware(M.ConvertToInt)
117117
end
118118

119-
@doc "wether viewer has followed"
119+
@desc "wether viewer has followed"
120120
field :viewer_has_followed, :boolean do
121121
arg(:viewer_did, :viewer_did_type, default_value: :viewer_did)
122122

@@ -126,7 +126,7 @@ defmodule GroupherServerWeb.Schema.Account.Types do
126126
middleware(M.ViewerDidConvert)
127127
end
128128

129-
@doc "paged stared posts"
129+
@desc "paged stared posts"
130130
field :stared_posts, :paged_posts do
131131
arg(:filter, non_null(:paged_filter))
132132
arg(:thread, :post_thread, default_value: :post)
@@ -135,7 +135,7 @@ defmodule GroupherServerWeb.Schema.Account.Types do
135135
resolve(&R.Accounts.stared_contents/3)
136136
end
137137

138-
@doc "paged stared jobs"
138+
@desc "paged stared jobs"
139139
field :stared_jobs, :paged_jobs do
140140
arg(:filter, non_null(:paged_filter))
141141
arg(:thread, :job_thread, default_value: :job)
@@ -144,7 +144,7 @@ defmodule GroupherServerWeb.Schema.Account.Types do
144144
resolve(&R.Accounts.stared_contents/3)
145145
end
146146

147-
@doc "paged stared videos"
147+
@desc "paged stared videos"
148148
field :stared_videos, :paged_videos do
149149
arg(:filter, non_null(:paged_filter))
150150
arg(:thread, :video_thread, default_value: :video)
@@ -153,7 +153,7 @@ defmodule GroupherServerWeb.Schema.Account.Types do
153153
resolve(&R.Accounts.stared_contents/3)
154154
end
155155

156-
@doc "paged favorited posts"
156+
@desc "paged favorited posts"
157157
field :favorited_posts, :paged_posts do
158158
arg(:filter, non_null(:paged_filter))
159159
arg(:thread, :post_thread, default_value: :post)
@@ -162,7 +162,7 @@ defmodule GroupherServerWeb.Schema.Account.Types do
162162
resolve(&R.Accounts.favorited_contents/3)
163163
end
164164

165-
@doc "paged favorited jobs"
165+
@desc "paged favorited jobs"
166166
field :favorited_jobs, :paged_jobs do
167167
arg(:filter, non_null(:paged_filter))
168168
arg(:thread, :job_thread, default_value: :job)
@@ -171,7 +171,7 @@ defmodule GroupherServerWeb.Schema.Account.Types do
171171
resolve(&R.Accounts.favorited_contents/3)
172172
end
173173

174-
@doc "paged favorited videos"
174+
@desc "paged favorited videos"
175175
field :favorited_videos, :paged_videos do
176176
arg(:filter, non_null(:paged_filter))
177177
arg(:thread, :video_thread, default_value: :video)
@@ -180,7 +180,7 @@ defmodule GroupherServerWeb.Schema.Account.Types do
180180
resolve(&R.Accounts.favorited_contents/3)
181181
end
182182

183-
@doc "paged favorited repos"
183+
@desc "paged favorited repos"
184184
field :favorited_repos, :paged_repos do
185185
arg(:filter, non_null(:paged_filter))
186186
arg(:thread, :repo_thread, default_value: :repo)
@@ -189,55 +189,55 @@ defmodule GroupherServerWeb.Schema.Account.Types do
189189
resolve(&R.Accounts.favorited_contents/3)
190190
end
191191

192-
@doc "total count of stared posts count"
192+
@desc "total count of stared posts count"
193193
field :stared_posts_count, :integer do
194194
arg(:count, :count_type, default_value: :count)
195195

196196
resolve(dataloader(Accounts, :stared_posts))
197197
middleware(M.ConvertToInt)
198198
end
199199

200-
@doc "total count of stared jobs count"
200+
@desc "total count of stared jobs count"
201201
field :stared_jobs_count, :integer do
202202
arg(:count, :count_type, default_value: :count)
203203

204204
resolve(dataloader(Accounts, :stared_jobs))
205205
middleware(M.ConvertToInt)
206206
end
207207

208-
@doc "total count of stared videos count"
208+
@desc "total count of stared videos count"
209209
field :stared_videos_count, :integer do
210210
arg(:count, :count_type, default_value: :count)
211211

212212
resolve(dataloader(Accounts, :stared_videos))
213213
middleware(M.ConvertToInt)
214214
end
215215

216-
@doc "total count of favorited posts count"
216+
@desc "total count of favorited posts count"
217217
field :favorited_posts_count, :integer do
218218
arg(:count, :count_type, default_value: :count)
219219

220220
resolve(dataloader(Accounts, :favorited_posts))
221221
middleware(M.ConvertToInt)
222222
end
223223

224-
@doc "total count of favorited jobs count"
224+
@desc "total count of favorited jobs count"
225225
field :favorited_jobs_count, :integer do
226226
arg(:count, :count_type, default_value: :count)
227227

228228
resolve(dataloader(Accounts, :favorited_jobs))
229229
middleware(M.ConvertToInt)
230230
end
231231

232-
@doc "total count of favorited videos count"
232+
@desc "total count of favorited videos count"
233233
field :favorited_videos_count, :integer do
234234
arg(:count, :count_type, default_value: :count)
235235

236236
resolve(dataloader(Accounts, :favorited_videos))
237237
middleware(M.ConvertToInt)
238238
end
239239

240-
@doc "total count of favorited videos count"
240+
@desc "total count of favorited videos count"
241241
field :favorited_repos_count, :integer do
242242
arg(:count, :count_type, default_value: :count)
243243

lib/groupher_server_web/schema/cms/cms_types.ex

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -267,16 +267,16 @@ defmodule GroupherServerWeb.Schema.CMS.Types do
267267
field(:threads, list_of(:thread), resolve: dataloader(CMS, :threads))
268268
field(:categories, list_of(:category), resolve: dataloader(CMS, :categories))
269269

270-
@doc "total count of post contents"
270+
@desc "total count of post contents"
271271
content_counts_field(:post, CMS.Post)
272272

273-
@doc "total count of job contents"
273+
@desc "total count of job contents"
274274
content_counts_field(:job, CMS.Job)
275275

276-
@doc "total count of video contents"
276+
@desc "total count of video contents"
277277
content_counts_field(:video, CMS.Video)
278278

279-
@doc "total count of repo contents"
279+
@desc "total count of repo contents"
280280
content_counts_field(:repo, CMS.Repo)
281281

282282
field :subscribers, list_of(:user) do

lib/groupher_server_web/schema/delivery/delivery_types.ex

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
defmodule GroupherServerWeb.Schema.Delivery.Types do
22
use Absinthe.Schema.Notation
3-
use Absinthe.Ecto, repo: GroupherServer.Repo
43

54
import GroupherServerWeb.Schema.Utils.Helper
65
import Helper.Utils, only: [get_config: 2]
@@ -34,16 +33,16 @@ defmodule GroupherServerWeb.Schema.Delivery.Types do
3433
field(:read, :boolean)
3534
end
3635

37-
object :sys_notification do
38-
field(:id, :id)
36+
# object :sys_notification do
37+
# field(:id, :id)
3938

40-
field(:source_id, :string)
41-
field(:source_title, :string)
42-
field(:source_preview, :string)
43-
field(:source_type, :string)
39+
# field(:source_id, :string)
40+
# field(:source_title, :string)
41+
# field(:source_preview, :string)
42+
# field(:source_type, :string)
4443

45-
field(:read, :boolean)
46-
end
44+
# field(:read, :boolean)
45+
# end
4746

4847
object :notification do
4948
field(:id, :id)

lib/groupher_server_web/schema/statistics/statistics_types.ex

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
defmodule GroupherServerWeb.Schema.Statistics.Types do
22
use Absinthe.Schema.Notation
3-
use Absinthe.Ecto, repo: GroupherServer.Repo
43

54
# import GroupherServerWeb.Schema.Utils.Helper
65

lib/groupher_server_web/schema/utils/common_types.ex

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ defmodule GroupherServerWeb.Schema.Utils.CommonTypes do
55
import GroupherServerWeb.Schema.Utils.Helper
66

77
use Absinthe.Schema.Notation
8-
use Absinthe.Ecto, repo: GroupherServer.Repo
98

109
object :status do
1110
field(:done, :boolean)

lib/helper/gql_schema_suite.ex

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ defmodule Helper.GqlSchemaSuite do
66
defmacro __using__(_opts) do
77
quote do
88
use Absinthe.Schema.Notation
9-
use Absinthe.Ecto, repo: GroupherServer.Repo
109

1110
alias GroupherServerWeb.Resolvers, as: R
1211
alias GroupherServerWeb.Middleware, as: M

mix.exs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,10 +62,9 @@ defmodule GroupherServer.Mixfile do
6262
{:plug_cowboy, "~> 2.4.1"},
6363
{:plug, "~> 1.11.0"},
6464
# GraphQl tool
65-
{:absinthe, "~> 1.4.16"},
66-
{:absinthe_ecto, "~> 0.1.3"},
65+
{:absinthe, "~> 1.6.1"},
6766
# Plug support for Absinthe
68-
{:absinthe_plug, "~> 1.4.6"},
67+
{:absinthe_plug, "~> 1.5.4"},
6968
# Password hashing lib
7069
{:comeonin, "~> 5.1.1"},
7170
# CORS
@@ -80,7 +79,7 @@ defmodule GroupherServer.Mixfile do
8079
# {:scrivener_ecto, "~> 2.0.0"},
8180
{:guardian, "~> 2.0"},
8281
{:timex, "~> 3.6.1"},
83-
{:dataloader, "~> 1.0.2"},
82+
{:dataloader, "~> 1.0.7"},
8483
{:mix_test_watch, "~> 1.0.2", only: :dev, runtime: false},
8584
{:ex_unit_notifier, "~> 0.1", only: :test},
8685
{:apollo_tracing, "~> 0.4.3"},

0 commit comments

Comments
 (0)