refactor(cms-mutations): missing delete test for CMS.Repo (#345)

Author: mydearxym

lib/groupher_server_web/schema/cms/mutations/repo.ex

@@ -73,17 +73,7 @@ defmodule GroupherServerWeb.Schema.CMS.Mutations.Repo do
     #############
     article_pin_mutation(:repo)
     article_trash_mutation(:repo)
+    article_delete_mutation(:repo)
     #############
-
-    @desc "delete a repo"
-    field :delete_repo, :repo do
-      arg(:id, non_null(:id))
-
-      middleware(M.Authorize, :login)
-      middleware(M.PassportLoader, source: :repo)
-      middleware(M.Passport, claim: "owner;cms->c?->repo.delete")
-
-      resolve(&R.CMS.delete_content/3)
-    end
   end
 end

test/groupher_server_web/mutation/cms/repo_test.exs

@@ -185,5 +185,57 @@ defmodule GroupherServer.Test.Mutation.Repo do
 
       assert rule_conn |> mutation_get_error?(@update_repo_query, variables, ecode(:passport))
     end
+
+    @query """
+    mutation($id: ID!){
+      deleteRepo(id: $id) {
+        id
+      }
+    }
+    """
+    @tag :wip2
+    test "delete a repo by repo's owner", ~m(owner_conn repo)a do
+      deleted = owner_conn |> mutation_result(@query, %{id: repo.id}, "deleteRepo")
+
+      assert deleted["id"] == to_string(repo.id)
+      assert {:error, _} = ORM.find(CMS.Repo, deleted["id"])
+    end
+
+    @tag :wip2
+    test "can delete a repo by auth user", ~m(repo)a do
+      belongs_community_title = repo.communities |> List.first() |> Map.get(:title)
+      rule_conn = simu_conn(:user, cms: %{belongs_community_title => %{"repo.delete" => true}})
+
+      deleted = rule_conn |> mutation_result(@query, %{id: repo.id}, "deleteRepo")
+
+      assert deleted["id"] == to_string(repo.id)
+      assert {:error, _} = ORM.find(CMS.Repo, deleted["id"])
+    end
+
+    @tag :wip2
+    test "delete a repo without login user fails", ~m(guest_conn repo)a do
+      assert guest_conn |> mutation_get_error?(@query, %{id: repo.id}, ecode(:account_login))
+    end
+
+    test "login user with auth passport delete a repo", ~m(repo)a do
+      repo_communities_0 = repo.communities |> List.first() |> Map.get(:title)
+      passport_rules = %{repo_communities_0 => %{"repo.delete" => true}}
+      rule_conn = simu_conn(:user, cms: passport_rules)
+
+      # assert conn |> mutation_get_error?(@query, %{id: repo.id})
+
+      deleted = rule_conn |> mutation_result(@query, %{id: repo.id}, "deleteRepo")
+
+      assert deleted["id"] == to_string(repo.id)
+    end
+
+    test "unauth user delete repo fails", ~m(user_conn guest_conn repo)a do
+      variables = %{id: repo.id}
+      rule_conn = simu_conn(:user, cms: %{"what.ever" => true})
+
+      assert user_conn |> mutation_get_error?(@query, variables, ecode(:passport))
+      assert guest_conn |> mutation_get_error?(@query, variables, ecode(:account_login))
+      assert rule_conn |> mutation_get_error?(@query, variables, ecode(:passport))
+    end
   end
 end