refactor(community): redesign (#364)

* refactor(community): rename table && clean up warnings

* refactor(community): re-org macro helper file

* refactor(community): wip

* refactor(community): wip

* refactor(community): more test

* refactor(community): wip

* refactor(community): wip

* refactor(community): add views to community

* refactor(community): move articles_count to outside field

* refactor(test): skip old post comment test

* chore: fmt

* fix(article): add viewer_has states when read

* refactor: sync subscribe count to community

* refactor: move subscribe count & viewer_has logic

* refactor(community): enhance read community & test

* refactor(community): fmt

* fix(community): meta nil edge-case

* fix(community): editor count & tests

* fix(community): remove editors subscribers in community fields

* fix(community): remove editors subscribers in community fields

* fix(community): error test

* fix(community): error test

* fix(community): error test

Author: mydearxym

cover/excoveralls.json

@@ -3,7 +3,7 @@ defmodule GroupherServer.Accounts.Delegate.CollectFolder do
   user collect folder related
   """
   import Ecto.Query, warn: false
-  import GroupherServer.CMS.Helper.Matcher2
+  import GroupherServer.CMS.Helper.Matcher
 
   alias Helper.Types, as: T
   alias Helper.QueryBuilder

lib/groupher_server/accounts/delegates/collect_folder.ex

@@ -7,7 +7,7 @@ defmodule GroupherServer.Accounts.Delegate.Publish do
   # import Helper.ErrorCode
   import ShortMaps
 
-  import GroupherServer.CMS.Helper.Matcher
+  import GroupherServer.CMS.Helper.MatcherOld
 
   alias Helper.{ORM, QueryBuilder}
   # alias GroupherServer.{Accounts, Repo}

lib/groupher_server/accounts/delegates/publish.ex

@@ -2,7 +2,6 @@ defmodule GroupherServer.Accounts.Delegate.UpvotedArticles do
   @moduledoc """
   get contents(posts, jobs ...) that user upvotes
   """
-  # import GroupherServer.CMS.Helper.Matcher
   import Ecto.Query, warn: false
   import Helper.Utils, only: [done: 1]
   import ShortMaps

lib/groupher_server/accounts/delegates/upvoted_articles.ex

@@ -31,6 +31,10 @@ defmodule GroupherServer.CMS do
   # see https://github.com/elixir-lang/elixir/issues/5306
 
   # Community CURD: editors, thread, tag
+  defdelegate read_community(args), to: CommunityCURD
+  defdelegate read_community(args, user), to: CommunityCURD
+  defdelegate create_community(args), to: CommunityCURD
+  defdelegate update_community(id, args), to: CommunityCURD
   # >> editor ..
   defdelegate update_editor(user, community, title), to: CommunityCURD
   # >> geo info ..
@@ -51,9 +55,6 @@ defmodule GroupherServer.CMS do
   defdelegate unset_article_tag(thread, article_id, tag_id), to: ArticleTag
   defdelegate paged_article_tags(filter), to: ArticleTag
 
-  defdelegate create_tag(community, thread, attrs, user), to: CommunityCURD
-  defdelegate update_tag(attrs), to: CommunityCURD
-
   # >> wiki & cheatsheet (sync with github)
   defdelegate get_wiki(community), to: CommunitySync
   defdelegate get_cheatsheet(community), to: CommunitySync
@@ -113,9 +114,6 @@ defmodule GroupherServer.CMS do
   defdelegate undo_pin_article(thread, id, community_id), to: ArticleCommunity
   defdelegate lock_article_comment(article), to: ArticleCommunity
 
-  # >> tag: set / unset
-  defdelegate set_tag(thread, tag, content_id), to: ArticleCommunity
-  defdelegate unset_tag(thread, tag, content_id), to: ArticleCommunity
   # >> community: set / unset
   defdelegate mirror_article(thread, article_id, community_id), to: ArticleCommunity
   defdelegate unmirror_article(thread, article_id, community_id), to: ArticleCommunity

lib/groupher_server/cms/cms.ex

@@ -9,6 +9,7 @@ defmodule GroupherServer.CMS.Community do
   alias GroupherServer.{Accounts, CMS}
 
   alias CMS.{
+    Embeds,
     Category,
     CommunityThread,
     CommunitySubscriber,
@@ -35,13 +36,22 @@ defmodule GroupherServer.CMS.Community do
     field(:raw, :string)
     field(:index, :integer)
     field(:geo_info, :map)
+    field(:views, :integer)
 
+    embeds_one(:meta, Embeds.CommunityMeta, on_replace: :delete)
     belongs_to(:author, Accounts.User, foreign_key: :user_id)
 
     has_many(:threads, {"communities_threads", CommunityThread})
     has_many(:subscribers, {"communities_subscribers", CommunitySubscriber})
     has_many(:editors, {"communities_editors", CommunityEditor})
 
+    field(:articles_count, :integer, default: 0)
+    field(:editors_count, :integer, default: 0)
+    field(:subscribers_count, :integer, default: 0)
+
+    field(:viewer_has_subscribed, :boolean, default: false, virtual: true)
+    field(:viewer_is_editor, :boolean, default: false, virtual: true)
+
     has_one(:wiki, CommunityWiki)
     has_one(:cheatsheet, CommunityCheatsheet)
 
@@ -68,6 +78,7 @@ defmodule GroupherServer.CMS.Community do
     community
     |> cast(attrs, @optional_fields ++ @required_fields)
     |> validate_required(@required_fields)
+    |> cast_embed(:meta, with: &Embeds.CommunityMeta.changeset/2)
     |> validate_length(:title, min: 1, max: 30)
     |> foreign_key_constraint(:user_id)
     |> unique_constraint(:title, name: :communities_title_index)
@@ -82,6 +93,7 @@ defmodule GroupherServer.CMS.Community do
     # |> unique_constraint(:title, name: :communities_title_index)
     community
     |> cast(attrs, @optional_fields ++ @required_fields)
+    |> cast_embed(:meta, with: &Embeds.CommunityMeta.changeset/2)
     |> validate_length(:title, min: 1, max: 30)
     |> foreign_key_constraint(:user_id)
     |> unique_constraint(:title, name: :communities_title_index)

lib/groupher_server/cms/community.ex

@@ -5,7 +5,7 @@ defmodule GroupherServer.CMS.Delegate.AbuseReport do
   import Ecto.Query, warn: false
   import Helper.Utils, only: [done: 1, strip_struct: 1, get_config: 2]
 
-  import GroupherServer.CMS.Helper.Matcher2
+  import GroupherServer.CMS.Helper.Matcher
   import ShortMaps
 
   alias Helper.ORM

lib/groupher_server/cms/delegates/abuse_report.ex

@@ -2,7 +2,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleCollect do
   @moduledoc """
   reaction[upvote, collect, watch ...] on article [post, job...]
   """
-  import GroupherServer.CMS.Helper.Matcher2
+  import GroupherServer.CMS.Helper.Matcher
   import Ecto.Query, warn: false
   import Helper.Utils, only: [done: 1]
 

lib/groupher_server/cms/delegates/article_collect.ex

@@ -7,7 +7,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleComment do
   import Helper.ErrorCode
 
   import GroupherServer.CMS.Delegate.Helper, only: [mark_viewer_emotion_states: 3]
-  import GroupherServer.CMS.Helper.Matcher2
+  import GroupherServer.CMS.Helper.Matcher
   import ShortMaps
 
   alias Helper.Types, as: T
@@ -106,7 +106,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleComment do
         add_participator_to_article(article, user)
       end)
       |> Repo.transaction()
-      |> upsert_comment_result()
+      |> result()
     end
   end
 
@@ -130,7 +130,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleComment do
       ORM.update(comment, %{body_html: @delete_hint, is_deleted: true})
     end)
     |> Repo.transaction()
-    |> upsert_comment_result()
+    |> result()
   end
 
   # add participator to article-like content (Post, Job ...) and update count
@@ -274,16 +274,16 @@ defmodule GroupherServer.CMS.Delegate.ArticleComment do
     Map.merge(paged_comments, %{entries: entries})
   end
 
-  defp upsert_comment_result({:ok, %{create_article_comment: result}}), do: {:ok, result}
-  defp upsert_comment_result({:ok, %{delete_article_comment: result}}), do: {:ok, result}
+  defp result({:ok, %{create_article_comment: result}}), do: {:ok, result}
+  defp result({:ok, %{delete_article_comment: result}}), do: {:ok, result}
 
-  defp upsert_comment_result({:error, :create_article_comment, result, _steps}) do
+  defp result({:error, :create_article_comment, result, _steps}) do
     raise_error(:create_comment, result)
   end
 
-  defp upsert_comment_result({:error, :add_participator, result, _steps}) do
+  defp result({:error, :add_participator, result, _steps}) do
     {:error, result}
   end
 
-  defp upsert_comment_result({:error, _, result, _steps}), do: {:error, result}
+  defp result({:error, _, result, _steps}), do: {:error, result}
 end

lib/groupher_server/cms/delegates/article_comment.ex

@@ -9,7 +9,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleCommentAction do
   import GroupherServer.CMS.Delegate.ArticleComment,
     only: [add_participator_to_article: 2, do_create_comment: 4, update_article_comments_count: 2]
 
-  import GroupherServer.CMS.Helper.Matcher2
+  import GroupherServer.CMS.Helper.Matcher
 
   alias Helper.Types, as: T
   alias Helper.ORM