fix: first transaction being silently dropped when its description merges with "Opening Unit Balance" line during PDF text extraction #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it Balance Some PDFs have their first transaction's description text extracted on the same line as "Opening Unit Balance" due to PDF internal structure differences. This caused the first transaction to be silently dropped since the parser couldn't match a line with date/amounts but no description. Example of problematic extraction: Line 1: 'NFO Purchase Opening Unit Balance: 0.000' <- description merged Line 2: '28-Apr-2020 2,000.00 200.000 10.0000 200.000' <- no description Fix: - Modified OPEN_UNITS_RE to capture optional description before "Opening Unit Balance" - Added TRANSACTION_RE5 to match transaction lines without description - Store pending description and apply it to the next transaction line Fixes orphan stamp duty issue where the corresponding purchase was missing.
iBalajiShanmugam
force-pushed
the
fix-first-transaction-parsing
branch
from
709b78b to
3db75bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some PDFs have their first transaction's description text extracted on the same line as "Opening Unit Balance" due to PDF internal structure differences. This caused the first transaction to be silently dropped since the parser couldn't match a line with date/amounts but no description.
Example of problematic extraction:
Line 1: 'NFO Purchase Opening Unit Balance: 0.000' <- description merged
Line 2: '20-Apr-2023 2,000.00 200.000 10.0000 200.000' <- no description
Fix:
Fixes orphan stamp duty issue where the corresponding purchase was missing.