Add shfmt and shellcheck

Author: nhooyr

Makefile

@@ -2,12 +2,6 @@ all: fmt lint test
 
 .SILENT:
 
-.PHONY: *
-
-.ONESHELL:
-SHELL = bash
-.SHELLFLAGS = -ceuo pipefail
-
 include ci/fmt.mk
 include ci/lint.mk
 include ci/test.mk

ci/ensure_fmt.sh

@@ -0,0 +1,23 @@
+#!/usr/bin/env bash
+
+set -euo pipefail
+
+main() {
+  local files
+  mapfile -t files < <(git ls-files --other --modified --exclude-standard)
+  if [[ ${files[*]} == "" ]]; then
+    return
+  fi
+
+  echo "Files need generation or are formatted incorrectly:"
+  for f in "${files[@]}"; do
+    echo "  $f"
+  done
+
+  echo
+  echo "Please run the following locally:"
+  echo "  make fmt"
+  exit 1
+}
+
+main "$@"

ci/fmt.mk

@@ -1,12 +1,6 @@
-fmt: modtidy gofmt goimports prettier
+fmt: modtidy gofmt goimports prettier shfmt
 ifdef CI
-	if [[ $$(git ls-files --other --modified --exclude-standard) != "" ]]; then
-	  echo "Files need generation or are formatted incorrectly:"
-	  git -c color.ui=always status | grep --color=no '\e\[31m'
-	  echo "Please run the following locally:"
-	  echo "  make fmt"
-	  exit 1
-	fi
+	./ci/ensure_fmt.sh
 endif
 
 modtidy: gen
@@ -23,3 +17,6 @@ prettier:
 
 gen:
 	stringer -type=opcode,MessageType,StatusCode -output=stringer.go
+
+shfmt:
+	shfmt -i 2 -w -s -sr $$(git ls-files "*.sh")

ci/image/Dockerfile

@@ -1,10 +1,12 @@
 FROM golang:1
 
 RUN apt-get update
-RUN apt-get install -y chromium npm
+RUN apt-get install -y chromium npm shellcheck
+
+ARG SHFMT_URL=https://github.com/mvdan/sh/releases/download/v3.0.1/shfmt_v3.0.1_linux_amd64
+RUN curl -L $SHFMT_URL > /usr/local/bin/shfmt && chmod +x /usr/local/bin/shfmt
 
 ENV GOFLAGS="-mod=readonly"
-ENV PAGER=cat
 ENV CI=true
 ENV MAKEFLAGS="--jobs=16 --output-sync=target"
 

ci/lint.mk

@@ -1,4 +1,4 @@
-lint: govet golint
+lint: govet golint govet-wasm golint-wasm shellcheck
 
 govet:
 	go vet ./...
@@ -11,3 +11,6 @@ golint:
 
 golint-wasm:
 	GOOS=js GOARCH=wasm golint -set_exit_status ./...
+
+shellcheck:
+	shellcheck $$(git ls-files "*.sh")