Skip to content

Commit d2ef6be

Browse files
author
Jonathan Yu
authored
chore: add update strategy configuration (#179)
Add the default update strategy settings, as these are checked by the kube-linter linter. This is not a behavior change, and simply encodes the default settings into our Chart.
1 parent b2d4210 commit d2ef6be

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

kube-linter.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ checks:
1919
- no-liveness-probe
2020
- no-read-only-root-fs
2121
- no-readiness-probe
22+
- no-rolling-update-strategy
2223
- non-existent-service-account
2324
- privilege-escalation-container
2425
- privileged-container
@@ -39,8 +40,6 @@ checks:
3940
- access-to-secrets
4041
# TODO: evaluate high availability by default
4142
- minimum-three-replicas
42-
# TODO: add update strategy
43-
- no-rolling-update-strategy
4443
# TODO: add network policy for coderd and timescale pods
4544
- non-isolated-pod
4645
- required-annotation-email

templates/coderd.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ metadata:
1616
spec:
1717
replicas: {{ include "movedValue" (dict "Values" .Values "Key" "coderd.replicas" 1) }}
1818
strategy:
19+
type: RollingUpdate
1920
rollingUpdate:
2021
maxSurge: "25%"
2122
maxUnavailable: "25%"

templates/timescale.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,10 @@ metadata:
3030
spec:
3131
serviceName: timescale
3232
replicas: 1
33+
updateStrategy:
34+
type: RollingUpdate
35+
rollingUpdate:
36+
partition: 0
3337
selector:
3438
matchLabels:
3539
app: timescale

0 commit comments

Comments
 (0)