Skip to content

Commit c283098

Browse files
author
Jonathan Yu
authored
Revert "Load balancer TLS termination (#144)" (#145)
This reverts commit be5b7f6.
1 parent be5b7f6 commit c283098

File tree

2 files changed

+7
-14
lines changed

2 files changed

+7
-14
lines changed

templates/coderd.yaml

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -247,22 +247,20 @@ spec:
247247
selector:
248248
coder.deployment: {{ include "coder.serviceName" . }}
249249
ports:
250-
- name: tcp-{{ include "coder.serviceName" . }}-https
251-
port: 443
252-
{{- if .Values.coderd.httpsToHttp }}¬
253-
targetPort: 8443
254-
protocol: TCP
255-
{{ if .Values.coderd.serviceNodePorts.https }}
256-
nodePort: {{ .Values.coderd.serviceNodePorts.https }}
257-
{{ end }}
258250
- name: tcp-{{ include "coder.serviceName" . }}
259251
port: 80
260-
{{- end }}
261252
targetPort: 8080
262253
protocol: TCP
263254
{{ if .Values.coderd.serviceNodePorts.http }}
264255
nodePort: {{ .Values.coderd.serviceNodePorts.http }}
265256
{{ end }}
257+
- name: tcp-{{ include "coder.serviceName" . }}-https
258+
port: 443
259+
targetPort: 8443
260+
protocol: TCP
261+
{{ if .Values.coderd.serviceNodePorts.https }}
262+
nodePort: {{ .Values.coderd.serviceNodePorts.https }}
263+
{{ end }}
266264
{{- else }}
267265
---
268266
apiVersion: v1

values.yaml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,6 @@ coderd:
3636
# coderd.serviceAnnotations -- Extra annotations to apply to the coderd service.
3737
serviceAnnotations: {}
3838

39-
# coderd.httpsToHttp -- eliminates the external http port and routes traffic from
40-
# the external https port to the internal http port. Useful for when the load balancer
41-
# performs TLS termination (like Amazon's ACM)
42-
httpsToHttp: false
43-
4439
# coderd.trustProxyIP -- Whether Coder should trust X-Real-IP and/or
4540
# X-Forwarded-For headers from your reverse proxy. This should only be turned
4641
# on if you're using a reverse proxy that sets both of these headers. This is

0 commit comments

Comments
 (0)