Only output password if it was generated

code-asher · code-asher · commit a3ac4567e391 · 2019-04-25T14:08:46.000-05:00
diff --git a/packages/server/src/cli.ts b/packages/server/src/cli.ts
@@ -216,6 +216,7 @@ const bold = (text: string | number): string | number => {
 	}
 
 	let password = options.password || process.env.PASSWORD;
+	const usingCustomPassword = !!password;
 	if (!password) {
 		// Generate a random password with a length of 24.
 		const buffer = Buffer.alloc(12);
@@ -304,7 +305,7 @@ const bold = (text: string | number): string | number => {
 		logger.warn("Documentation on securing your setup: https://github.com/codercom/code-server/blob/master/doc/security/ssl.md");
 	}
 
-	if (!options.noAuth) {
+	if (!options.noAuth && !usingCustomPassword) {
 		logger.info(" ");
 		logger.info(`Password:\u001B[1m ${password}`);
 	} else {

Original file line number	Diff line number	Diff line change
`@@ -216,6 +216,7 @@ const bold = (text: string \| number): string \| number => {`
`216`	`216`	`}`
`217`	`217`
`218`	`218`	`let password = options.password \|\| process.env.PASSWORD;`
	`219`	`+ const usingCustomPassword = !!password;`
`219`	`220`	`if (!password) {`
`220`	`221`	`// Generate a random password with a length of 24.`
`221`	`222`	`const buffer = Buffer.alloc(12);`
`@@ -304,7 +305,7 @@ const bold = (text: string \| number): string \| number => {`
`304`	`305`	`logger.warn("Documentation on securing your setup: https://github.com/codercom/code-server/blob/master/doc/security/ssl.md");`
`305`	`306`	`}`
`306`	`307`
`307`		`- if (!options.noAuth) {`
	`308`	`+ if (!options.noAuth && !usingCustomPassword) {`
`308`	`309`	`logger.info(" ");`
`309`	`310`	logger.info(`Password:\u001B[1m ${password}`);
`310`	`311`	`} else {`