Move contains to utils

This will be needed in the Artifactory storage impl.

Author: code-asher

cli/remove.go

@@ -69,7 +69,7 @@ func remove() *cobra.Command {
 			}
 
 			versionCount := len(allVersions)
-			if !all && version != "" && !contains(allVersions, version) {
+			if !all && version != "" && !util.Contains(allVersions, version) {
 				return xerrors.Errorf("%s does not exist", id)
 			} else if versionCount == 0 {
 				return xerrors.Errorf("%s.%s has no versions to delete", publisher, name)
@@ -108,12 +108,3 @@ func remove() *cobra.Command {
 
 	return cmd
 }
-
-func contains(a []string, b string) bool {
-	for _, astr := range a {
-		if astr == b {
-			return true
-		}
-	}
-	return false
-}

util/util.go

@@ -13,3 +13,12 @@ func Plural(count int, singular, plural string) string {
 	}
 	return strconv.Itoa(count) + " " + plural
 }
+
+func Contains(a []string, b string) bool {
+	for _, astr := range a {
+		if astr == b {
+			return true
+		}
+	}
+	return false
+}

util/util_test.go

@@ -19,3 +19,12 @@ func TestPlural(t *testing.T) {
 	require.Equal(t, "1 dependency", util.Plural(1, "dependency", "dependencies"))
 	require.Equal(t, "2 dependencies", util.Plural(2, "dependency", "dependencies"))
 }
+
+func TestContains(t *testing.T) {
+	t.Parallel()
+
+	require.True(t, util.Contains([]string{"foo", "bar"}, "foo"))
+	require.True(t, util.Contains([]string{"foo", "bar"}, "bar"))
+	require.False(t, util.Contains([]string{"foo", "bar"}, "baz"))
+	require.False(t, util.Contains([]string{"foo", "bar"}, "foobar"))
+}