Ensure iOS sample renders before screenshots

Author: shai-almog

scripts/ios/tests/HelloCodenameOneUITests.swift.tmpl

@@ -6,6 +6,7 @@ final class HelloCodenameOneUITests: XCTestCase {
     private var app: XCUIApplication!
     private var outputDirectory: URL!
     private var targetBundleIdentifier: String?
+    private var resolvedBundleIdentifier: String?
     private let codenameOneSurfaceIdentifier = "cn1.glview"
     private let chunkSize = 2000
     private let previewChannel = "PREVIEW"
@@ -40,6 +41,12 @@ final class HelloCodenameOneUITests: XCTestCase {
         let reportedBundleId = targetBundleIdentifier ?? "(scheme-default)"
         print("CN1SS:INFO:ui_test_target_bundle_id=\(reportedBundleId)")
         print("CN1SS:INFO:ui_test_launch_arguments=\(app.launchArguments.joined(separator: " "))")
+        if let resolved = resolveBundleIdentifier() {
+            resolvedBundleIdentifier = resolved
+            print("CN1SS:INFO:ui_test_resolved_bundle_id=\(resolved)")
+        } else {
+            print("CN1SS:WARN:ui_test_resolved_bundle_id_unavailable=true")
+        }
 
         let launchSurface = waitForCodenameOneSurface(timeout: 40, context: "post_launch")
         logSurfaceMetrics(launchSurface, context: "post_launch")
@@ -118,19 +125,21 @@ final class HelloCodenameOneUITests: XCTestCase {
         var attempts = 0
         while true {
             attempts += 1
-            let screenshot = XCUIScreen.main.screenshot()
-            let hasContent = screenshotHasRenderableContent(screenshot)
+            let screenshot = app.screenshot()
+            let analysis = analyzeScreenshot(screenshot)
+            let hasContent = analysis.hasRenderableContent
             if hasContent {
                 print("CN1SS:INFO:test=\(label) rendered_frame_detected_attempt=\(attempts)")
                 return (screenshot, true, attempts)
             }
 
             let now = Date()
             if now >= deadline {
+                print("CN1SS:INFO:test=\(label) rendered_frame_luma_variance=\(analysis.lumaVariance)")
                 return (screenshot, false, attempts)
             }
 
-            print("CN1SS:INFO:test=\(label) waiting_for_rendered_frame attempt=\(attempts)")
+            print("CN1SS:INFO:test=\(label) waiting_for_rendered_frame attempt=\(attempts) luma_variance=\(analysis.lumaVariance)")
             let nextInterval = min(poll, deadline.timeIntervalSince(now))
             RunLoop.current.run(until: Date(timeIntervalSinceNow: nextInterval))
         }
@@ -143,7 +152,7 @@ final class HelloCodenameOneUITests: XCTestCase {
         if exists {
             return surface
         }
-        let fallback = XCUIScreen.main.screenshot()
+        let fallback = app.screenshot()
         let screenshotAttachment = XCTAttachment(screenshot: fallback)
         screenshotAttachment.name = "\(context)_missing_surface_screen"
         screenshotAttachment.lifetime = .keepAlways
@@ -170,14 +179,14 @@ final class HelloCodenameOneUITests: XCTestCase {
         add(attachment)
     }
 
-    private func screenshotHasRenderableContent(_ screenshot: XCUIScreenshot) -> Bool {
+    private func analyzeScreenshot(_ screenshot: XCUIScreenshot) -> (hasRenderableContent: Bool, lumaVariance: Int) {
         guard let cgImage = screenshot.image.cgImage else {
-            return true
+            return (true, 255)
         }
         let width = cgImage.width
         let height = cgImage.height
         guard width > 0, height > 0 else {
-            return false
+            return (false, 0)
         }
 
         let insetX = max(0, width / 8)
@@ -189,7 +198,7 @@ final class HelloCodenameOneUITests: XCTestCase {
             height: max(1, height - insetY * 2)
         ).integral
         guard let cropped = cgImage.cropping(to: cropRect) else {
-            return true
+            return (true, 255)
         }
 
         let sampleWidth = 80
@@ -205,12 +214,12 @@ final class HelloCodenameOneUITests: XCTestCase {
             space: CGColorSpaceCreateDeviceRGB(),
             bitmapInfo: CGImageAlphaInfo.premultipliedLast.rawValue
         ) else {
-            return true
+            return (true, 255)
         }
         context.interpolationQuality = .high
         context.draw(cropped, in: CGRect(x: 0, y: 0, width: sampleWidth, height: sampleHeight))
         guard let data = context.data else {
-            return true
+            return (true, 255)
         }
 
         let buffer = data.bindMemory(to: UInt8.self, capacity: sampleHeight * bytesPerRow)
@@ -229,7 +238,23 @@ final class HelloCodenameOneUITests: XCTestCase {
             }
         }
 
-        return maxLuma - minLuma > 12
+        let variance = maxLuma - minLuma
+        return (variance > 12, variance)
+    }
+
+    private func resolveBundleIdentifier() -> String? {
+        if let explicit = targetBundleIdentifier, !explicit.isEmpty {
+            return explicit
+        }
+        do {
+            let value = try app.value(forKey: "bundleID")
+            if let actual = value as? String, !actual.isEmpty {
+                return actual
+            }
+        } catch {
+            print("CN1SS:WARN:ui_test_bundle_resolution_failed error=\(error)")
+        }
+        return nil
     }
 
     private func sanitizeTestName(_ name: String) -> String {

scripts/templates/HelloCodenameOne.java.tmpl

@@ -13,11 +13,18 @@ import com.codename1.ui.layouts.BoxLayout;
 public class @MAIN_NAME@ {
     private Form current;
     private Form mainForm;
+    private boolean initBootstrapScheduled;
 
     public void init(Object context) {
         System.out.println("CN1SS:INFO:codenameone_init context=" + (context == null ? "null" : context.getClass().getName()));
         System.out.println("CN1SS:INFO:codenameone_init_display_initialized=" + Display.isInitialized());
-        // No special initialization required for this sample
+        if (!initBootstrapScheduled) {
+            initBootstrapScheduled = true;
+            Display.getInstance().callSerially(() -> {
+                System.out.println("CN1SS:INFO:codenameone_init_serial_bootstrap begin=true");
+                ensureMainFormVisible("init_serial");
+            });
+        }
     }
 
     public void start() {
@@ -42,7 +49,7 @@ public class @MAIN_NAME@ {
             current.show();
             return;
         }
-        showMainForm();
+        ensureMainFormVisible("start");
     }
 
     public void stop() {
@@ -58,7 +65,7 @@ public class @MAIN_NAME@ {
         // Nothing to clean up for this sample
     }
 
-    private void showMainForm() {
+    private void buildMainFormIfNeeded() {
         if (mainForm == null) {
             System.out.println("CN1SS:INFO:codenameone_build_main_form start=true");
             mainForm = new Form("Main Screen", new BorderLayout());
@@ -89,6 +96,25 @@ public class @MAIN_NAME@ {
             mainForm.add(BorderLayout.CENTER, content);
             System.out.println("CN1SS:INFO:codenameone_build_main_form complete=true");
         }
+    }
+
+    private void ensureMainFormVisible(String reason) {
+        buildMainFormIfNeeded();
+        Display display = Display.getInstance();
+        Form visible = display.getCurrent();
+        if (visible != mainForm) {
+            current = mainForm;
+            mainForm.show();
+            System.out.println("CN1SS:INFO:codenameone_main_form_presented reason=" + reason);
+        } else {
+            current = mainForm;
+            System.out.println("CN1SS:INFO:codenameone_main_form_already_visible reason=" + reason);
+        }
+        Display.getInstance().callSerially(() -> logFormMetrics("codenameone_main_form_ready", Display.getInstance().getCurrent()));
+    }
+
+    private void showMainForm() {
+        buildMainFormIfNeeded();
         current = mainForm;
         mainForm.show();
         System.out.println("CN1SS:INFO:codenameone_main_form_shown title=" + mainForm.getTitle());
@@ -109,7 +135,7 @@ public class @MAIN_NAME@ {
                 FontImage.MATERIAL_ARROW_BACK,
                 evt -> {
                     System.out.println("CN1SS:INFO:codenameone_browser_back_action triggered=true");
-                    showMainForm();
+                    ensureMainFormVisible("browser_back");
                 }
         );