Apply Rector

Author: MGatner

.php-cs-fixer.dist.php

@@ -11,6 +11,7 @@
         __DIR__ . '/tests/',
     ])
     ->exclude('build')
+    ->exclude('Views/errors')
     ->append([__FILE__]);
 
 $overrides = [];

app/Libraries/Blog.php

@@ -253,10 +253,8 @@ protected function readPost(string $folder, string $filename)
             }
 
             if (! $inBody) {
-                $key   = substr($line, 0, strpos($line, ':'));
-                $value = trim(substr($line, strpos($line, ':') + 1));
-
-                $post->{$key} = $value;
+                $key          = substr($line, 0, strpos($line, ':'));
+                $post->{$key} = trim(substr($line, strpos($line, ':') + 1));
 
                 continue;
             }

tests/_support/Mock/MockGitHub.php

@@ -16,10 +16,8 @@ class MockGitHub extends GitHub
     /**
      * Whether the next API call should throw
      * an exception.
-     *
-     * @var bool
      */
-    private $throws = false;
+    private bool $throws = false;
 
     /**
      * Skips the need for parameters
@@ -133,10 +131,10 @@ private function repoReleasesAll(): array
                 'assets_url' => 'https://api.github.com/repos/codeigniter4/CodeIgniter4/releases/37193785/assets',
                 'upload_url' => 'https://uploads.github.com/repos/codeigniter4/CodeIgniter4/releases/37193785/assets{?name,label}',
                 'html_url'   => 'https://github.com/codeigniter4/CodeIgniter4/releases/tag/v4.1.1',
-                'id'         => 37193785,
+                'id'         => 37_193_785,
                 'author'     => [
                     'login'      => 'MGatner',
-                    'id'         => 17572847,
+                    'id'         => 17_572_847,
                     'node_id'    => 'MDQ6VXNlcjE3NTcyODQ3',
                     'avatar_url' => 'https://avatars.githubusercontent.com/u/17572847?v=4',
                     'url'        => 'https://api.github.com/users/MGatner',
@@ -162,10 +160,10 @@ private function repoReleasesAll(): array
                 'assets_url' => 'https://api.github.com/repos/codeigniter4/CodeIgniter4/releases/37155037/assets',
                 'upload_url' => 'https://uploads.github.com/repos/codeigniter4/CodeIgniter4/releases/37155037/assets{?name,label}',
                 'html_url'   => 'https://github.com/codeigniter4/CodeIgniter4/releases/tag/v4.1.0',
-                'id'         => 37155037,
+                'id'         => 37_155_037,
                 'author'     => [
                     'login'      => 'MGatner',
-                    'id'         => 17572847,
+                    'id'         => 17_572_847,
                     'node_id'    => 'MDQ6VXNlcjE3NTcyODQ3',
                     'avatar_url' => 'https://avatars.githubusercontent.com/u/17572847?v=4',
                     'url'        => 'https://api.github.com/users/MGatner',
@@ -197,7 +195,7 @@ private function repoContributors(): array
         return [
             [
                 'login'               => 'narfbg',
-                'id'                  => 1058011,
+                'id'                  => 1_058_011,
                 'node_id'             => 'MDQ6VXNlcjEwNTgwMTE=',
                 'avatar_url'          => 'https://avatars.githubusercontent.com/u/1058011?v=4',
                 'gravatar_id'         => '',
@@ -239,7 +237,7 @@ private function repoContributors(): array
             ],
             [
                 'login'               => 'jim-parry',
-                'id'                  => 3203951,
+                'id'                  => 3_203_951,
                 'node_id'             => 'MDQ6VXNlcjMyMDM5NTE=',
                 'avatar_url'          => 'https://avatars.githubusercontent.com/u/3203951?v=4',
                 'gravatar_id'         => '',
@@ -267,14 +265,14 @@ private function repoContributors(): array
     private function repoShow(): array
     {
         return [
-            'id'        => 205950333,
+            'id'        => 205_950_333,
             'node_id'   => 'MDEwOlJlcG9zaXRvcnkyMDU5NTAzMzM=',
             'name'      => 'website2',
             'full_name' => 'codeigniter4projects/website2',
             'private'   => false,
             'owner'     => [
                 'login'               => 'codeigniter4projects',
-                'id'                  => 53120982,
+                'id'                  => 53_120_982,
                 'node_id'             => 'MDEyOk9yZ2FuaXphdGlvbjUzMTIwOTgy',
                 'avatar_url'          => 'https://avatars.githubusercontent.com/u/53120982?v=4',
                 'gravatar_id'         => '',
@@ -368,7 +366,7 @@ private function repoShow(): array
             'temp_clone_token' => null,
             'organization'     => [
                 'login'               => 'codeigniter4projects',
-                'id'                  => 53120982,
+                'id'                  => 53_120_982,
                 'node_id'             => 'MDEyOk9yZ2FuaXphdGlvbjUzMTIwOTgy',
                 'avatar_url'          => 'https://avatars.githubusercontent.com/u/53120982?v=4',
                 'gravatar_id'         => '',

tests/libaries/GitHubTest.php

@@ -12,10 +12,7 @@
  */
 final class GitHubTest extends ProjectTestCase
 {
-    /**
-     * @var MockGitHub
-     */
-    private $github;
+    private MockGitHub $github;
 
     protected function setUp(): void
     {
@@ -112,7 +109,7 @@ public function testGetRepos()
         $result = $this->github->getRepos();
 
         $this->assertIsArray($result);
-        $this->assertCount(count(config('GitHub')->repos), $result);
+        $this->assertCount(is_countable(config('GitHub')->repos) ? count(config('GitHub')->repos) : 0, $result);
         $this->assertInstanceOf(Repo::class, $result['framework4']);
     }
 
@@ -121,7 +118,7 @@ public function testGetContributors()
         $result = $this->github->getContributors();
 
         $this->assertIsArray($result);
-        $this->assertCount(count(config('GitHub')->repos), $result);
+        $this->assertCount(is_countable(config('GitHub')->repos) ? count(config('GitHub')->repos) : 0, $result);
         $this->assertInstanceOf(Contributor::class, $result['framework4'][0]);
     }
 
@@ -165,7 +162,7 @@ public function testResolving()
         $this->assertInstanceOf('Closure', $result);
 
         // Force the resolver to run
-        $count  = count(cache()->getCacheInfo());
+        $count  = is_countable(cache()->getCacheInfo()) ? count(cache()->getCacheInfo()) : 0;
         $author = $release->author;
 
         $this->assertIsString($author);