Merge pull request #504 from kenjis/fix-UserModel-cannot-save-array

fix: UserModel cannot save an array

Author: kenjis

src/Models/UserModel.php

@@ -253,6 +253,11 @@ public function update($id = null, $data = null): bool
             /** @throws DataException */
             $result = parent::update($id, $data);
         } catch (DataException $e) {
+            // When $data is an array.
+            if ($this->tempUser === null) {
+                throw $e;
+            }
+
             $messages = [
                 lang('Database.emptyDataset', ['update']),
             ];

tests/Unit/UserModelTest.php

@@ -4,6 +4,7 @@
 
 namespace Tests\Unit;
 
+use CodeIgniter\Database\Exceptions\DataException;
 use CodeIgniter\Shield\Entities\User;
 use CodeIgniter\Shield\Exceptions\LogicException;
 use CodeIgniter\Shield\Models\UserModel;
@@ -239,4 +240,18 @@ public function testUpdateUserObjectWithoutUserDataToUpdate(): void
             'secret'  => 'bar@bar.com',
         ]);
     }
+
+    /**
+     * @see https://github.com/codeigniter4/shield/issues/471
+     */
+    public function testSaveArrayNoDataToUpdate(): void
+    {
+        $this->expectException(DataException::class);
+        $this->expectExceptionMessage('There is no data to update.');
+
+        $users = $this->createUserModel();
+        $user  = fake(UserModel::class);
+
+        $users->save(['id' => $user->id]);
+    }
 }