Skip to content

Commit 336e2b5

Browse files
authored
Merge pull request #342 from kenjis/fix-checkQueryReturn
refactor: fix incorrect types
2 parents e2ab992 + 47f987f commit 336e2b5

File tree

4 files changed

+7
-4
lines changed

4 files changed

+7
-4
lines changed

src/Authentication/Authenticators/AccessTokens.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public function attempt(array $credentials): Result
4444
$request = service('request');
4545

4646
$ipAddress = $request->getIPAddress();
47-
$userAgent = $request->getUserAgent();
47+
$userAgent = (string) $request->getUserAgent();
4848

4949
$result = $this->check($credentials);
5050

src/Authentication/Authenticators/Session.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ public function attempt(array $credentials): Result
9898
$request = service('request');
9999

100100
$ipAddress = $request->getIPAddress();
101-
$userAgent = $request->getUserAgent();
101+
$userAgent = (string) $request->getUserAgent();
102102

103103
$result = $this->check($credentials);
104104

src/Controllers/MagicLinkController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ private function recordLoginAttempt(
178178
$identifier,
179179
$success,
180180
$this->request->getIPAddress(),
181-
$this->request->getUserAgent(),
181+
(string) $this->request->getUserAgent(),
182182
$userId
183183
);
184184
}

src/Models/CheckQueryReturnTrait.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,10 @@ trait CheckQueryReturnTrait
1010
{
1111
private ?bool $currentDBDebug = null;
1212

13-
private function checkQueryReturn(bool $return): void
13+
/**
14+
* @param bool|int|string $return insert() returns insert ID.
15+
*/
16+
private function checkQueryReturn($return): void
1417
{
1518
$this->restoreDBDebug();
1619

0 commit comments

Comments
 (0)