Skip to content

Commit 057bc17

Browse files
committed
new phpstan errors fixed
1 parent 714bdd1 commit 057bc17

File tree

5 files changed

+17
-17
lines changed

5 files changed

+17
-17
lines changed

src/Filters/GroupFilter.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010
use CodeIgniter\HTTP\Response;
1111
use CodeIgniter\HTTP\ResponseInterface;
1212

13-
use CodeIgniter\Shield\Exceptions\GroupException;
14-
1513
/**
1614
* Group Authorization Filter.
1715
*/

src/Filters/PermissionFilter.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010
use CodeIgniter\HTTP\Response;
1111
use CodeIgniter\HTTP\ResponseInterface;
1212

13-
use CodeIgniter\Shield\Exceptions\PermissionException;
14-
1513
/**
1614
* Permission Authorization Filter.
1715
*/

tests/Authentication/Filters/AbstractFilterTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@
55
namespace Tests\Authentication\Filters;
66

77
use CodeIgniter\Config\Factories;
8+
use CodeIgniter\Shield\Test\AuthenticationTesting;
89
use CodeIgniter\Test\FeatureTestTrait;
910
use Config\Services;
1011
use Tests\Support\TestCase;
11-
use CodeIgniter\Shield\Test\AuthenticationTesting;
1212

1313
/**
1414
* @internal

tests/Authentication/Filters/GroupFilterTest.php

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,15 @@
99
use CodeIgniter\Shield\Models\UserModel;
1010
use CodeIgniter\Test\DatabaseTestTrait;
1111

12+
/**
13+
* @internal
14+
*/
1215
final class GroupFilterTest extends AbstractFilterTest
1316
{
1417
use DatabaseTestTrait;
1518

16-
protected string $alias = 'group';
17-
protected string $classname = GroupFilter::class;
19+
protected string $alias = 'group';
20+
protected string $classname = GroupFilter::class;
1821
protected string $routeFilter = 'group:admin';
1922

2023
public function testFilterNotAuthorized(): void
@@ -28,7 +31,7 @@ public function testFilterNotAuthorized(): void
2831
$result->assertSee('Open');
2932
}
3033

31-
public function testFilterSuccess()
34+
public function testFilterSuccess(): void
3235
{
3336
/** @var User */
3437
$user = fake(UserModel::class);
@@ -45,7 +48,7 @@ public function testFilterSuccess()
4548
$this->assertSame($user->id, auth('session')->user()->id);
4649
}
4750

48-
public function testFilterIncorrectGroupNoPrevious()
51+
public function testFilterIncorrectGroupNoPrevious(): void
4952
{
5053
/** @var User */
5154
$user = fake(UserModel::class);
@@ -61,7 +64,7 @@ public function testFilterIncorrectGroupNoPrevious()
6164
$result->assertSessionHas('error');
6265
}
6366

64-
public function testFilterIncorrectGroupWithPrevious()
67+
public function testFilterIncorrectGroupWithPrevious(): void
6568
{
6669
/** @var User */
6770
$user = fake(UserModel::class);
@@ -77,5 +80,4 @@ public function testFilterIncorrectGroupWithPrevious()
7780

7881
$result->assertSessionHas('error');
7982
}
80-
8183
}

tests/Authentication/Filters/PermissionFilterTest.php

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,15 @@
99
use CodeIgniter\Shield\Models\UserModel;
1010
use CodeIgniter\Test\DatabaseTestTrait;
1111

12+
/**
13+
* @internal
14+
*/
1215
final class PermissionFilterTest extends AbstractFilterTest
1316
{
1417
use DatabaseTestTrait;
1518

16-
protected string $alias = 'permission';
17-
protected string $classname = PermissionFilter::class;
19+
protected string $alias = 'permission';
20+
protected string $classname = PermissionFilter::class;
1821
protected string $routeFilter = 'permission:admin.access';
1922

2023
public function testFilterNotAuthorized(): void
@@ -28,7 +31,7 @@ public function testFilterNotAuthorized(): void
2831
$result->assertSee('Open');
2932
}
3033

31-
public function testFilterSuccess()
34+
public function testFilterSuccess(): void
3235
{
3336
/** @var User */
3437
$user = fake(UserModel::class);
@@ -45,7 +48,7 @@ public function testFilterSuccess()
4548
$this->assertSame($user->id, auth('session')->user()->id);
4649
}
4750

48-
public function testFilterIncorrectGroupNoPrevious()
51+
public function testFilterIncorrectGroupNoPrevious(): void
4952
{
5053
/** @var User */
5154
$user = fake(UserModel::class);
@@ -61,7 +64,7 @@ public function testFilterIncorrectGroupNoPrevious()
6164
$result->assertSessionHas('error');
6265
}
6366

64-
public function testFilterIncorrectGroupWithPrevious()
67+
public function testFilterIncorrectGroupWithPrevious(): void
6568
{
6669
/** @var User */
6770
$user = fake(UserModel::class);
@@ -77,5 +80,4 @@ public function testFilterIncorrectGroupWithPrevious()
7780

7881
$result->assertSessionHas('error');
7982
}
80-
8183
}

0 commit comments

Comments
 (0)