fix: Forge::modifyColumn() for SQLSRV handler

Author: michalsn

system/Database/SQLSRV/Forge.php

@@ -253,8 +253,27 @@ protected function _alterTable(string $alterType, string $table, $processedField
             }
 
             if (! empty($field['default'])) {
-                $sqls[] = $sql . ' ALTER COLUMN ADD CONSTRAINT ' . $this->db->escapeIdentifiers($field['name']) . '_def'
-                    . " DEFAULT {$field['default']} FOR " . $this->db->escapeIdentifiers($field['name']);
+                $fullTable = $this->db->escapeIdentifiers($this->db->schema) . '.' . $this->db->escapeIdentifiers($table);
+                $colName   = $field['name']; // bare, for sys.columns lookup
+
+                // find the existing default constraint name for this column
+                $findSql = <<<SQL
+                    SELECT dc.name AS constraint_name
+                    FROM sys.default_constraints dc
+                    JOIN sys.columns c
+                        ON dc.parent_object_id = c.object_id
+                        AND dc.parent_column_id = c.column_id
+                    WHERE dc.parent_object_id = OBJECT_ID(N'{$fullTable}')
+                        AND c.name = N'{$colName}';
+                    SQL;
+
+                $toDrop = $this->db->query($findSql)->getRowArray();
+                if (isset($toDrop['constraint_name']) && $toDrop['constraint_name'] !== '') {
+                    $sqls[] = $sql . ' DROP CONSTRAINT ' . $this->db->escapeIdentifiers($toDrop['constraint_name']);
+                }
+
+                $sqls[] = $sql . ' ADD CONSTRAINT ' . $this->db->escapeIdentifiers($field['name'] . '_def')
+                    . "{$field['default']} FOR " . $this->db->escapeIdentifiers($field['name']);
             }
 
             $nullable = true; // Nullable by default.

utils/phpstan-baseline/loader.neon

@@ -1,4 +1,4 @@
-# total 2836 errors
+# total 2837 errors
 includes:
     - argument.type.neon
     - assign.propertyType.neon

utils/phpstan-baseline/property.notFound.neon

@@ -1,4 +1,4 @@
-# total 58 errors
+# total 59 errors
 
 parameters:
     ignoreErrors:
@@ -14,7 +14,7 @@ parameters:
 
         -
             message: '#^Access to an undefined property CodeIgniter\\Database\\BaseConnection\:\:\$schema\.$#'
-            count: 13
+            count: 14
             path: ../../system/Database/SQLSRV/Forge.php
 
         -