Correctly set up image tag

Author: codeguru42

.github/workflows/deploy.yaml

@@ -24,11 +24,19 @@ jobs:
           role-to-assume: arn:aws:iam::200049542062:role/gocapture/GithubRole
           aws-region: us-west-1
 
+      - name: Login to Amazon ECR
+        id: login-ecr
+        uses: aws-actions/amazon-ecr-login@v1
+
       - name: Deploy ECS Cluster
+        env:
+          REGISTRY: ${{ steps.login-ecr.outputs.registry }}
+          REPOSITORY: go-capture
+          IMAGE_TAG: ${{ github.sha }}
         uses: aws-actions/aws-cloudformation-github-deploy@v1
         with:
           name: GoCaptureECSCluster
           capabilities: CAPABILITY_NAMED_IAM
-          parameter-overrides: "TaskImage=$REGISTRY/$REPOSITORY:$IMAGE_TAG"
+          parameter-overrides: "TaskImage=${{ env.REGISTRY }}/${{ env.REPOSITORY }}:${{ env.IMAGE_TAG }}"
           template: cloud-formation/ecs.yaml
           no-fail-on-empty-changeset: 1

cloud-formation/github-role.yaml

@@ -51,7 +51,6 @@ Resources:
                   iam:GetRole,
                   iam:GetUser,
                   iam:ListAccessKeys,
-                  iam:PassRole,
                   iam:PutRolePolicy,
                   iam:PutRoleRole,
                   iam:PutUserPolicy,
@@ -96,7 +95,8 @@ Resources:
                 "Action": [
                   "ecs:CreateCluster",
                   "ecs:DescribeClusters",
-                  "ecs:RegisterTaskDefinition"
+                  "ecs:RegisterTaskDefinition",
+                  "iam:PassRole"
                 ],
                 "Resource": "*"
               }