Use anchor by default

Author: garronej

src/lib/routing.tsx

@@ -1,6 +1,5 @@
 import React, { createContext, useContext } from "react";
 import type { ReactNode } from "react";
-import { assert } from "tsafe/assert";
 import type { DetailedHTMLProps, AnchorHTMLAttributes } from "react";
 
 type HTMLAnchorProps = DetailedHTMLProps<
@@ -17,14 +16,12 @@ export type RegisteredLinkProps = RegisterLink extends {
     Link: (props: infer LinkProps) => any;
 }
     ? Omit<LinkProps, "children">
-    : RegisterLink extends { Link: "a" }
-    ? Omit<HTMLAnchorProps, "children">
-    : React.AriaAttributes & { className?: string };
+    : Omit<HTMLAnchorProps, "children">;
 
-const context = createContext<CreateLinkProviderPrams["Link"] | undefined>(undefined);
+const context = createContext<CreateLinkProviderPrams["Link"]>(props => <a {...props} />);
 
 type CreateLinkProviderPrams = {
-    Link: ((props: RegisteredLinkProps & { children: ReactNode }) => ReturnType<React.FC>) | "a";
+    Link: (props: RegisteredLinkProps & { children: ReactNode }) => ReturnType<React.FC>;
 };
 
 export function createDsfrLinkProvider(params: CreateLinkProviderPrams) {
@@ -44,16 +41,7 @@ export function createDsfrLinkProvider(params: CreateLinkProviderPrams) {
 }
 
 export function useLink() {
-    let Link = useContext(context);
-
-    assert(
-        Link !== undefined,
-        "You need to specify what routing library is in use in your project, see: https://react-dsfr.etalab.studio/routing"
-    );
-
-    if (Link === "a") {
-        Link = props => <a {...props} />;
-    }
+    const Link = useContext(context);
 
     return { Link };
 }

stories/getStory.tsx

@@ -4,12 +4,6 @@ import type { ArgType } from "@storybook/addons";
 import { symToStr } from "tsafe/symToStr";
 import { id } from "tsafe/id";
 import { useIsDark, DsfrLangProvider } from "../dist/lib";
-import type { HTMLAnchorProps } from "../dist/lib";
-
-declare module "../dist" {
-    // eslint-disable-next-line @typescript-eslint/no-empty-interface
-    export interface LinkProps extends HTMLAnchorProps {}
-}
 
 export function getStoryFactory<Props extends Record<string, any>>(params: {
     sectionName: string;

test/integration/cra/src/index.tsx

@@ -7,17 +7,6 @@ import { useRoute, RouteProvider } from "./router";
 import { Header } from "@codegouvfr/react-dsfr/Header";
 import { fr } from "@codegouvfr/react-dsfr";
 import { routes } from "./router";
-import { createDsfrLinkProvider } from "@codegouvfr/react-dsfr";
-
-declare module "@codegouvfr/react-dsfr" {
-    interface RegisterLink { 
-        Link: "a";
-    }
-}
-
-const { DsfrLinkProvider } = createDsfrLinkProvider({
-    "Link": "a"
-});
 
 startReactDsfr({
     "defaultColorScheme": "system"
@@ -36,7 +25,7 @@ function Root() {
     const route = useRoute();
 
     return (
-        <DsfrLinkProvider>
+        <>
             <Header
                 brandTop={<>INTITULE<br />OFFICIEL</>}
                 serviceTitle="Nom du site / service"
@@ -67,7 +56,7 @@ function Root() {
                     }
                 })()}
             </div>
-        </DsfrLinkProvider>
+        </>
     );