#135: Common should be applied to the variant

Author: garronej

src/AgentConnectButton.tsx

@@ -6,19 +6,20 @@ import { assert, type Equals } from "tsafe/assert";
 import "./assets/agentconnect.css";
 import { cx } from "./tools/cx";
 
-export type AgentConnectButtonProps = AgentConnectButtonProps.Common &
-    (AgentConnectButtonProps.WithUrl | AgentConnectButtonProps.WithOnClick);
+export type AgentConnectButtonProps =
+    | AgentConnectButtonProps.WithUrl
+    | AgentConnectButtonProps.WithOnClick;
 
 export namespace AgentConnectButtonProps {
-    export type Common = {
+    type Common = {
         className?: string;
         style?: CSSProperties;
     };
-    export type WithUrl = {
+    export type WithUrl = Common & {
         url: string;
         onClick?: never;
     };
-    export type WithOnClick = {
+    export type WithOnClick = Common & {
         url?: never;
         onClick: React.MouseEventHandler<HTMLButtonElement>;
     };

src/FranceConnectButton.tsx

@@ -5,22 +5,23 @@ import { fr } from "./fr";
 import { assert, type Equals } from "tsafe/assert";
 import { cx } from "./tools/cx";
 
-export type FranceConnectButtonProps = FranceConnectButtonProps.Common &
-    (FranceConnectButtonProps.WithUrl | FranceConnectButtonProps.WithOnClick);
+export type FranceConnectButtonProps =
+    | FranceConnectButtonProps.WithUrl
+    | FranceConnectButtonProps.WithOnClick;
 
 export namespace FranceConnectButtonProps {
-    export type Common = {
+    type Common = {
         className?: string;
         /** Default: false */
         plus?: boolean;
         classes?: Partial<Record<"root" | "login" | "brand", string>>;
         style?: CSSProperties;
     };
-    export type WithUrl = {
+    export type WithUrl = Common & {
         url: string;
         onClick?: never;
     };
-    export type WithOnClick = {
+    export type WithOnClick = Common & {
         url?: never;
         onClick: React.MouseEventHandler<HTMLButtonElement>;
     };

src/MonCompteProButton.tsx

@@ -6,20 +6,21 @@ import { assert, type Equals } from "tsafe/assert";
 import { cx } from "./tools/cx";
 import "./assets/moncomptepro.css";
 
-export type FranceConnectButtonProps = FranceConnectButtonProps.Common &
-    (FranceConnectButtonProps.WithUrl | FranceConnectButtonProps.WithOnClick);
+export type FranceConnectButtonProps =
+    | FranceConnectButtonProps.WithUrl
+    | FranceConnectButtonProps.WithOnClick;
 
 export namespace FranceConnectButtonProps {
-    export type Common = {
+    type Common = {
         className?: string;
         classes?: Partial<Record<"root" | "login" | "brand", string>>;
         style?: CSSProperties;
     };
-    export type WithUrl = {
+    export type WithUrl = Common & {
         url: string;
         onClick?: never;
     };
-    export type WithOnClick = {
+    export type WithOnClick = Common & {
         url?: never;
         onClick: React.MouseEventHandler<HTMLButtonElement>;
     };