Skip to content

Commit 9f2928a

Browse files
authored
Merge pull request #227 from codegouvfr/fix-urls
2 parents 5bb5fa1 + a827545 commit 9f2928a

File tree

6 files changed

+17
-17
lines changed

6 files changed

+17
-17
lines changed

CONTRIBUTING.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@ A few things:
1818
- 🙏🏻 Don't be afraid to push even if you aren't 100% happy with your code or [if it's still WIP](https://github.com/codegouvfr/react-dsfr/blob/1fdcf15cb085c67d37c31badf6ffa4725795ba0f/stories/Accordion.stories.tsx#L6).
1919
- 📣 Let everyone know what component you are working on by [oppening an issue](https://github.com/codegouvfr/react-dsfr/issues).
2020
- 📚 You can draw inspiration from [`dataesr/react-dsfr`](https://github.com/dataesr/react-dsfr/tree/master/src/components/interface) and the implementation of [france connect](https://github.com/france-connect/sources/tree/main/front/libs/dsfr).
21-
- 🔗 Use the component returned by `getLink()` instead of `<a />`. [Example in the `<Header />` component](https://github.com/codegouvfr/react-dsfr/blob/bbaf4a81d78de08d6fdcb059a9f4cb8a78ce4d5a/src/Header.tsx#L84-L87). We want to [play nice with all routing libraries](https://guides.react-dsfr.fr/integration-with-routing-libraries).
21+
- 🔗 Use the component returned by `getLink()` instead of `<a />`. [Example in the `<Header />` component](https://github.com/codegouvfr/react-dsfr/blob/bbaf4a81d78de08d6fdcb059a9f4cb8a78ce4d5a/src/Header.tsx#L84-L87). We want to [play nice with all routing libraries](https://react-dsfr.codegouv.studio/integration-with-routing-libraries).
2222
- 🕹️ When it's relevant, try to enable components to be used either in controlled or uncontrolled mode. [Example with <Tabs />](https://components.react-dsfr.codegouv.studio/?path=/docs/components-tabs--default).
23-
- 🌎 Avoid hard coding text in JSX, use [the i18n mechanism](https://guides.react-dsfr.fr/i18n) instead. [Here is an example](https://github.com/codegouvfr/react-dsfr/blob/bbaf4a81d78de08d6fdcb059a9f4cb8a78ce4d5a/src/DarkModeSwitch.tsx#L162-L199). (Don't worry about providing translations other than French.)
24-
- 🍳 If you have to arbitrate between ease of use and customisability I'd encourage you to favor ease of use. People that would need a greater level of customizability can always fall back to making their own wrapper from the reference documentation using [`fr.cx()`](https://guides.react-dsfr.fr/cx).
23+
- 🌎 Avoid hard coding text in JSX, use [the i18n mechanism](https://react-dsfr.codegouv.studio/i18n) instead. [Here is an example](https://github.com/codegouvfr/react-dsfr/blob/bbaf4a81d78de08d6fdcb059a9f4cb8a78ce4d5a/src/DarkModeSwitch.tsx#L162-L199). (Don't worry about providing translations other than French.)
24+
- 🍳 If you have to arbitrate between ease of use and customisability I'd encourage you to favor ease of use. People that would need a greater level of customizability can always fall back to making their own wrapper from the reference documentation using [`fr.cx()`](https://react-dsfr.codegouv.studio/cx).
2525

2626
## PR Reviews
2727

README.fr.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,20 +46,20 @@ DSFR en pur JavaScript/CSS.
4646
- [x] exactement le même aspect et ressenti qu'avec [@gouvfr/dsfr](https://www.npmjs.com/package/@gouvfr/dsfr), il s'agit d'une couche de compatibilité et non pas d'une implémentation alternative.
4747
- [x] pas de [flash d'écran blanc lors du basculement automatique du thème clair vers le thème sombre](https://github.com/codegouvfr/@codegouvfr/react-dsfr/issues/2#issuecomment-1257263480).
4848
- [x] la plupart des composants peuvent être rendus directement sur le serveur (voir [RSC](https://reactjs.org/blog/2020/12/21/data-fetching-with-react-server-components.html)). Les autres sont étiquetés `"use client";`.
49-
- [x] [Intégration clef en main pour les différents frameworks de développement: vite, Next.js, y compris la version beta de Next 13 (configuration AppDir) et Create React App](https://guides.react-dsfr.fr/) si votre
49+
- [x] [Intégration clef en main pour les différents frameworks de développement: vite, Next.js, y compris la version beta de Next 13 (configuration AppDir) et Create React App](https://react-dsfr.codegouv.studio/) si votre
5050
framework n'est pas supporté, il suffit de demander notre **il manque un mot là** , nous avons pour but de couvrir tous les cas d'usage effectifs.
5151
- [x] (Presque) tout [les composants de référence](https://www.systeme-de-design.gouv.fr/elements-d-interface) sont [implémenté](https://components.react-dsfr.codegouv.studio/).
5252
- [x] seulement le code des composants que vous utilisez effectivement sera inclus dans votre projet final.
5353
- [x] Intégration facultative avec [MUI](https://mui.com/). Si vous utilisez des composants MUI ils seront automatiquement adaptés pour ressembler à des composants DSFR.
54-
Voir la [documentation](https://guides.react-dsfr.fr/mui-integration).
54+
Voir la [documentation](https://react-dsfr.codegouv.studio/mui-integration).
5555
- [x] permet de développer à l'aide d'outil de CSS-in-JS comme [Styled component](https://styled-components.com/), [Emotion](https://emotion.sh/docs/introduction) ou [TSS](https://www.tss-react.dev/).
5656
- [x] prévoit un système de traduction pour les textes présents dans les composants (i18n).
57-
- [x] [s'intègre avec les librairies de routing](https://guides.react-dsfr.fr/routing) comme [React Router](https://reactrouter.com/en/main), [TanStack Router](https://tanstack.com/router/v1) ou encore [Type route](https://type-route.zilch.dev/).
57+
- [x] [s'intègre avec les librairies de routing](https://react-dsfr.codegouv.studio/routing) comme [React Router](https://reactrouter.com/en/main), [TanStack Router](https://tanstack.com/router/v1) ou encore [Type route](https://type-route.zilch.dev/).
5858

5959
> 💡 Besoin de pages de connexion au DSFR? Allez voir [keycloak-theme-dsfr](https://github.com/codegouvfr/keycloak-theme-dsfr).
6060
6161
<p align="center">
62-
<a href="https://guides.react-dsfr.fr/">🚀 Commencer maintenant 🚀 </a>
62+
<a href="https://react-dsfr.codegouv.studio/">🚀 Commencer maintenant 🚀 </a>
6363
</p>
6464

6565
# Gouvernance du projet

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,20 +45,20 @@ This module is an advanced toolkit that leverages [@gouvfr/dsfr](https://github.
4545
- [x] Exactly the same look and feel than with [@gouvfr/dsfr](https://www.npmjs.com/package/@gouvfr/dsfr).
4646
- [x] No [white flash when reloading in SSR setup](https://github.com/codegouvfr/@codegouvfr/react-dsfr/issues/2#issuecomment-1257263480).
4747
- [x] Most components are server component ready. The others are labeled with `"use client";`
48-
- [x] [Perfect integration with all major React framework: Next.js (PagesDir and AppDir), Create React App, Vue](https://guides.react-dsfr.fr/).
48+
- [x] [Perfect integration with all major React framework: Next.js (PagesDir and AppDir), Create React App, Vue](https://react-dsfr.codegouv.studio/).
4949
- [x] (Almost) All [the components](https://www.systeme-de-design.gouv.fr/elements-d-interface) are [implemented](https://components.react-dsfr.codegouv.studio/)
5050
- [x] Three shakable distribution, cherry pick the components you import. (It's not all in a big .js bundle)
5151
- [x] Optional integration with [MUI](https://mui.com/). If you use MUI components they will
52-
be automatically adapted to look like [DSFR components](https://www.systeme-de-design.gouv.fr/elements-d-interface). See [documentation](https://guides.react-dsfr.fr/mui-integration).
52+
be automatically adapted to look like [DSFR components](https://www.systeme-de-design.gouv.fr/elements-d-interface). See [documentation](https://react-dsfr.codegouv.studio/mui-integration).
5353
- [x] Enable CSS in JS by providing a `useColors()` hooks that exposes the correct colors options and decision
5454
for the currently enabled color scheme.
5555
- [x] Opt-in i18n, built in text can be displayed in multiple languages and user can provide extra translations.
56-
- [x] [Support routing libraries](https://guides.react-dsfr.fr/routing) like react-router.
56+
- [x] [Support routing libraries](https://react-dsfr.codegouv.studio/routing) like react-router.
5757

5858
> 💡 Need ready to use, DSFR compliant login and register pages? Checkout [keycloak-theme-dsfr](https://github.com/codegouvfr/keycloak-theme-dsfr).
5959
6060
<p align="center">
61-
<a href="https://guides.react-dsfr.fr/">🚀 Get started 🚀 </a>
61+
<a href="https://react-dsfr.codegouv.studio/">🚀 Get started 🚀 </a>
6262
</p>
6363

6464
# Governance

publiccode.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ it:
3131
gdpr: true
3232
description:
3333
en:
34-
documentation: 'https://guides.react-dsfr.fr/'
34+
documentation: 'https://react-dsfr.codegouv.studio/'
3535
shortDescription: French State Design System React integration
3636
longDescription: |
3737
This module is a wrapper/compatibility layer for
@@ -56,7 +56,7 @@ description:
5656
`"use client";`
5757
5858
- [Perfect integration with all major React framework: Next.js (PagesDir
59-
and AppDir), Create React App, Vue](https://guides.react-dsfr.fr/).
59+
and AppDir), Create React App, Vue](https://react-dsfr.codegouv.studio/).
6060
6161
- All [the
6262
components](https://www.systeme-de-design.gouv.fr/elements-d-interface)
@@ -69,7 +69,7 @@ description:
6969
- Optional integration with [MUI](https://mui.com/). If you use MUI
7070
components they will be automatically adapted to look like [DSFR
7171
components](https://www.systeme-de-design.gouv.fr/elements-d-interface).
72-
See [documentation](https://guides.react-dsfr.fr/mui-integration).
72+
See [documentation](https://react-dsfr.codegouv.studio/mui-integration).
7373
7474
- Enable CSS in JS by providing a `useTheme()` hooks that exposes the
7575
correct colors options and decision for the currently enabled color
@@ -78,7 +78,7 @@ description:
7878
- Opt-in i18n, built in text can be displayed in multiple languages and
7979
user can provide extra translations.
8080
81-
- [Support routing libraries](https://guides.react-dsfr.fr/routing)
81+
- [Support routing libraries](https://react-dsfr.codegouv.studio/routing)
8282
like react-router.
8383
8484

stories/ConsentManagement.stories.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ Refer to [this section of the Guides](https://react-dsfr.codegouv.studio/analyti
2222
mandated solution for analytics in your project.
2323
2424
You can find a complete example setup in [the Demo repo for Next.js App Router](https://github.com/garronej/react-dsfr-next-appdir-demo/blob/main/ui/consentManagement.tsx)
25-
which is live [here](https://next-demo.react-dsfr.fr/). You should be able to easily adapt it to other meta frameworks (Vite, Next Pages Router, CRA).
25+
which is live [here](https://stackblitz.com/edit/nextjs-j2wba3?file=pages/index.tsx). You should be able to easily adapt it to other meta frameworks (Vite, Next Pages Router, CRA).
2626
2727
\`\`\`tsx
2828
"use client";

stories/intro.stories.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import { RotatingLogo } from "./RotatingLogo";
2323
🇫🇷 <i>The <a href="https://www.systeme-de-design.gouv.fr/">French State Design System</a> React toolkit</i> 🇫🇷
2424
<br/>
2525

26-
[Github](https://github.com/codegouvfr/react-dsfr) - [Documentation](https://guides.react-dsfr.fr/)
26+
[Github](https://github.com/codegouvfr/react-dsfr) - [Documentation](https://react-dsfr.codegouv.studio/)
2727

2828
<iframe width="560" height="315" src="https://www.youtube.com/embed/5q88JgXUAY4" title="YouTube video player" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" allowfullscreen></iframe>
2929

0 commit comments

Comments
 (0)