Skip to content

Commit 059a21d

Browse files
committed
Update CONTRIBUTING
1 parent 4b606f8 commit 059a21d

File tree

1 file changed

+12
-1
lines changed

1 file changed

+12
-1
lines changed

CONTRIBUTING.md

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
Hello friends 👋,
1+
`Hello friends 👋,
22

33
Would you help us implement [the components](https://www.systeme-de-design.gouv.fr/elements-d-interface/composants/accordeon)?
44
Thank you so much to anyone that would!
@@ -23,6 +23,17 @@ A few things:
2323
- 🌎 Avoid hard coding text in JSX, use [the i18n mechanism](https://react-dsfr.etalab.studio/i18n) instead. [Here is an example](https://github.com/codegouvfr/react-dsfr/blob/bbaf4a81d78de08d6fdcb059a9f4cb8a78ce4d5a/src/DarkModeSwitch.tsx#L162-L199). (Don't worry about providing translations other than French.)
2424
- 🍳 If you have to arbitrate between ease of use and customisability I'd encourage you to favor ease of use. People that would need a greater level of customizability can always fall back to making their own wrapper from the reference documentation using [`fr.cx()`](https://react-dsfr.etalab.studio/cx).
2525

26+
## Getting TypeScript error in VSCode but the console says everything's right?
27+
28+
Because of how this project is setup TypeScript unaware that files have changed.
29+
You don't need to restart VSCode, just restart the TypeScript server.
30+
31+
https://user-images.githubusercontent.com/6702424/206942271-0dc9b94a-1c2b-4073-99d7-96f7fe862bc4.mov
32+
33+
Assets imports error in Storybook can be solved by opening the `stories/global.d.ts` file:
34+
35+
https://user-images.githubusercontent.com/6702424/206940923-8d2d1113-8b81-4f61-8c4e-66101c9fe67e.mov
36+
2637
Thank You Very Much ❤️
2738

2839
PS: If you want to contribute to the Doc website. You can edit [the source Markdown](https://github.com/codegouvfr/react-dsfr/tree/v1_docs) or ask me for access to our GitBook. (We'll migrate to Docusaurus once we have the DSFR theme for it ready.)

0 commit comments

Comments
 (0)