self review

Author: lsagetlethias

src/gdpr/types.ts

@@ -1,16 +1,19 @@
 /**
  * format: `<serviceName>: never`
+ *
+ * The value can be anything (or `never`), but you can set `true`
+ * as a reminder that this service is mandatory.
  * @example
  * ```ts
  * declare module "@codegouvfr/react-dsfr/gdpr" {
  *   interface RegisterGdprServices {
- *     matomo: never;
+ *     matomo: true;
  *     youtube: never;
  *   }
  * }
  * ```
  */
-// eslint-disable-next-line @typescript-eslint/no-empty-interface
+// eslint-disable-next-line @typescript-eslint/no-empty-interface -- for later augment
 export interface RegisterGdprServices {}
 export type GdprServiceName = keyof RegisterGdprServices extends never
     ? string

stories/ConsentBanner.stories.tsx

@@ -25,6 +25,16 @@ the consent state.
 import { Footer } from "@codegouvfr/react-dsfr/Footer";
 import { ConsentBanner, consentModalButtonProps } from "@codegouvfr/react-dsfr/ConsentBanner";
 
+// You can augment the service registry to have autocomplete when using useGdprStore
+declare module "@codegouvfr/react-dsfr/gdpr" {
+    interface RegisterGdprServices {
+        // the value can be anything (or never), but you can set true
+        // as a reminder that this service is mandatory
+        mandatory-cookie-consumer: true;
+        cookie-consumer: never;
+    }
+}
+
 function App(){
 
     return (

test/integration/next-appdir/app/layout.tsx

@@ -11,15 +11,14 @@ import { Footer } from "@codegouvfr/react-dsfr/Footer";
 import { Display, headerFooterDisplayItem } from "@codegouvfr/react-dsfr/Display";
 import { fr } from "@codegouvfr/react-dsfr";
 import { Navigation } from "./Navigation";
-import Link from 'next/link';
 
 const brandTop = <>INTITULE<br />OFFICIEL</>;
 
 const homeLinkPops = { "href": "/", "title": "Accueil - Nom de l’entité (ministère, secrétariat d‘état, gouvernement)" };
 
 declare module "@codegouvfr/react-dsfr/gdpr" {
     interface RegisterGdprServices { 
-        matomo: true;
+        matomo: never;
     }
 }