feat: add error handling and search redirect for software not found

Author: JeromeBu

api/src/rpc/translations/en_default.json

@@ -238,7 +238,13 @@
         "stop being referent": "Stop being referent",
         "become referent": "Become referent",
         "please provide a reason for unreferencing this software": "Please provide a reason why you think this software should not be in the $t(common.appAccronym) anymore",
-        "unreference software": "Dereference the software"
+        "unreference software": "Dereference the software",
+        "error": {
+            "title": "Software not found",
+            "notFound": "The requested software could not be found in the catalog. It may have been removed or the name might be incorrect.",
+            "generic": "An unexpected error occurred while loading the software details.",
+            "searchInCatalog": "Look for it in the catalog"
+        }
     },
     "headerDetailCard": {
         "authors": "Authors : ",

api/src/rpc/translations/fr_default.json

@@ -241,7 +241,13 @@
         "stop being referent": "Ne plus être référent",
         "become referent": "Devenir référent",
         "please provide a reason for unreferencing this software": "Merci de préciser la raison pour laquelle vous estimez que ce logiciel ne devrait plus être référencé dans le $t(common.appAccronym)",
-        "unreference software": "Dé-référencer le logiciel"
+        "unreference software": "Dé-référencer le logiciel",
+        "error": {
+            "title": "Logiciel introuvable",
+            "notFound": "Le logiciel demandé n'a pas pu être trouvé dans le catalogue. Il a peut-être été supprimé ou le nom pourrait être incorrect.",
+            "generic": "Une erreur inattendue s'est produite lors du chargement des détails du logiciel.",
+            "searchInCatalog": "Le chercher dans le catalogue"
+        }
     },
     "headerDetailCard": {
         "authors": "Auteurs : ",

api/src/rpc/translations/schema.json

@@ -972,6 +972,26 @@
                 },
                 "unreference software": {
                     "type": "string"
+                },
+                "error": {
+                    "type": "object",
+                    "properties": {
+                        "title": {
+                            "type": "string",
+                            "description": "Title text"
+                        },
+                        "notFound": {
+                            "type": "string"
+                        },
+                        "generic": {
+                            "type": "string"
+                        },
+                        "searchInCatalog": {
+                            "type": "string"
+                        }
+                    },
+                    "additionalProperties": false,
+                    "required": ["title", "notFound", "generic", "searchInCatalog"]
                 }
             },
             "additionalProperties": false,
@@ -1005,7 +1025,8 @@
                 "stop being referent",
                 "become referent",
                 "please provide a reason for unreferencing this software",
-                "unreference software"
+                "unreference software",
+                "error"
             ]
         },
         "headerDetailCard": {

web/src/core/usecases/softwareDetails/selectors.ts

@@ -17,8 +17,20 @@ const readyState = (rootState: RootState) => {
     return state;
 };
 
+const errorState = (rootState: RootState) => {
+    const state = rootState[name];
+
+    if (state.stateDescription !== "error") {
+        return undefined;
+    }
+
+    return state;
+};
+
 const isReady = createSelector(readyState, state => state !== undefined);
 
+const error = createSelector(errorState, state => state?.error);
+
 const software = createSelector(readyState, readyState => readyState?.software);
 
 const userDeclaration = createSelector(readyState, state => state?.userDeclaration);
@@ -33,7 +45,15 @@ const main = createSelector(
     software,
     userDeclaration,
     isUnreferencingOngoing,
-    (isReady, software, userDeclaration, isUnreferencingOngoing) => {
+    error,
+    (isReady, software, userDeclaration, isUnreferencingOngoing, error) => {
+        if (error) {
+            return {
+                isReady: false as const,
+                error
+            };
+        }
+
         if (!isReady) {
             return {
                 isReady: false as const

web/src/core/usecases/softwareDetails/state.ts

@@ -10,7 +10,7 @@ import type { ApiTypes } from "api";
 
 export const name = "softwareDetails";
 
-export type State = State.NotReady | State.Ready;
+export type State = State.NotReady | State.Ready | State.Error;
 
 export namespace State {
     export type SimilarSoftwareNotRegistered =
@@ -21,6 +21,11 @@ export namespace State {
         isInitializing: boolean;
     };
 
+    export type Error = {
+        stateDescription: "error";
+        error: globalThis.Error;
+    };
+
     export type Ready = {
         stateDescription: "ready";
         software: Software;
@@ -134,6 +139,13 @@ export const { reducer, actions } = createUsecaseActions({
             stateDescription: "not ready" as const,
             isInitializing: false
         }),
+        initializationFailed: (
+            _state,
+            { payload }: { payload: { error: globalThis.Error } }
+        ) => ({
+            stateDescription: "error" as const,
+            error: payload.error
+        }),
         unreferencingStarted: state => {
             assert(state.stateDescription === "ready");
             state.isUnreferencingOngoing = true;

web/src/core/usecases/softwareDetails/thunks.ts

@@ -64,12 +64,19 @@ export const thunks = {
                 sillApi.getInstances()
             ]);
 
-            const software = apiSoftwareToSoftware({
-                apiSoftwares,
-                apiInstances,
-                softwareName,
-                mainSource
-            });
+            let software: State.Software;
+
+            try {
+                software = apiSoftwareToSoftware({
+                    apiSoftwares,
+                    apiInstances,
+                    softwareName,
+                    mainSource
+                });
+            } catch (error) {
+                dispatch(actions.initializationFailed({ error: error as Error }));
+                return;
+            }
 
             const userDeclaration: { isReferent: boolean; isUser: boolean } | undefined =
                 await (async () => {
@@ -169,7 +176,9 @@ function apiSoftwareToSoftware(params: {
         apiSoftware => apiSoftware.softwareName === softwareName
     );
 
-    assert(apiSoftware !== undefined);
+    if (!apiSoftware) {
+        throw new Error(`Software "${softwareName}" not found`);
+    }
 
     const {
         softwareId,

web/src/ui/pages/softwareDetails/SoftwareDetails.tsx

@@ -16,6 +16,7 @@ import { SimilarSoftwareTab } from "ui/pages/softwareDetails/AlikeSoftwareTab";
 import { PublicationTab } from "./PublicationTab";
 import { ActionsFooter } from "ui/shared/ActionsFooter";
 import { DetailUsersAndReferents } from "ui/shared/DetailUsersAndReferents";
+import { Alert } from "@codegouvfr/react-dsfr/Alert";
 import { Button } from "@codegouvfr/react-dsfr/Button";
 import type { PageRoute } from "./route";
 import softwareLogoPlaceholder from "ui/assets/software_logo_placeholder.png";
@@ -44,10 +45,8 @@ export default function SoftwareDetails(props: Props) {
 
     const { t } = useTranslation();
 
-    const { isReady, software, userDeclaration, isUnreferencingOngoing } = useCoreState(
-        "softwareDetails",
-        "main"
-    );
+    const { isReady, error, software, userDeclaration, isUnreferencingOngoing } =
+        useCoreState("softwareDetails", "main");
 
     useEffect(() => {
         softwareDetails.initialize({
@@ -57,12 +56,21 @@ export default function SoftwareDetails(props: Props) {
         return () => softwareDetails.clear();
     }, [route.params.name]);
 
+    if (error) {
+        return (
+            <SoftwareDetailsErrorFallback
+                error={error}
+                softwareName={route.params.name}
+            />
+        );
+    }
+
     if (!isReady) {
         return <LoadingFallback />;
     }
 
     const getLogoUrl = (): string | undefined => {
-        if (software.logoUrl) return software.logoUrl;
+        if (software?.logoUrl) return software.logoUrl;
         if (uiConfig?.softwareDetails.defaultLogo) return softwareLogoPlaceholder;
     };
 
@@ -438,6 +446,49 @@ const ServiceProviderRow = ({
         </li>
     );
 };
+
+function SoftwareDetailsErrorFallback({
+    error,
+    softwareName
+}: {
+    error: Error;
+    softwareName: string;
+}) {
+    const { t } = useTranslation();
+
+    return (
+        <div
+            style={{
+                padding: fr.spacing("4v"),
+                display: "flex",
+                flexDirection: "column",
+                alignItems: "center",
+                gap: fr.spacing("4v")
+            }}
+        >
+            <Alert
+                severity="error"
+                title={t("softwareDetails.error.title")}
+                description={
+                    error.message.includes("not found")
+                        ? t("softwareDetails.error.notFound")
+                        : t("softwareDetails.error.generic")
+                }
+            />
+            <div style={{ display: "flex", gap: fr.spacing("2v") }}>
+                <Button
+                    priority="primary"
+                    onClick={() => {
+                        routes.softwareCatalog({ search: softwareName }).push();
+                    }}
+                >
+                    {t("softwareDetails.error.searchInCatalog")}
+                </Button>
+            </div>
+        </div>
+    );
+}
+
 const useStyles = tss.withName({ SoftwareDetails }).create({
     breadcrumb: {
         marginBottom: fr.spacing("4v")