fix: fix error when updating a software without providing similar software

Author: JeromeBu

api/src/core/adapters/dbApi/kysely/createPgSoftwareRepository.ts

@@ -184,19 +184,21 @@ export const createPgSoftwareRepository = (db: Kysely<Database>): SoftwareReposi
                 }));
             });
 
-            await db
-                .insertInto("software_external_datas")
-                .values(
-                    dataToInsert.map(({ similarExternalId, sourceSlug }) => ({
-                        externalId: similarExternalId,
-                        sourceSlug,
-                        label: JSON.stringify(""),
-                        description: JSON.stringify(""),
-                        developers: JSON.stringify([])
-                    }))
-                )
-                .onConflict(oc => oc.doNothing())
-                .execute();
+            if (dataToInsert.length > 0) {
+                await db
+                    .insertInto("software_external_datas")
+                    .values(
+                        dataToInsert.map(({ similarExternalId, sourceSlug }) => ({
+                            externalId: similarExternalId,
+                            sourceSlug,
+                            label: JSON.stringify(""),
+                            description: JSON.stringify(""),
+                            developers: JSON.stringify([])
+                        }))
+                    )
+                    .onConflict(oc => oc.doNothing())
+                    .execute();
+            }
 
             await db.transaction().execute(async trx => {
                 await trx
@@ -208,11 +210,13 @@ export const createPgSoftwareRepository = (db: Kysely<Database>): SoftwareReposi
                     )
                     .execute();
 
-                await trx
-                    .insertInto("softwares__similar_software_external_datas")
-                    .values(dataToInsert)
-                    .onConflict(oc => oc.columns(["softwareId", "sourceSlug", "similarExternalId"]).doNothing())
-                    .execute();
+                if (dataToInsert.length > 0) {
+                    await trx
+                        .insertInto("softwares__similar_software_external_datas")
+                        .values(dataToInsert)
+                        .onConflict(oc => oc.columns(["softwareId", "sourceSlug", "similarExternalId"]).doNothing())
+                        .execute();
+                }
             });
         },
         getSimilarSoftwareExternalDataPks: async ({ softwareId }) => {

api/src/core/usecases/updateSoftware.test.ts

@@ -142,5 +142,21 @@ describe("Create software, than updates it adding a similar software", () => {
             { sourceSlug: testSource.slug, externalId: "Q111590996", softwareId: undefined },
             { sourceSlug: testSource.slug, externalId: "Q56062435", softwareId: undefined }
         ]);
+
+        // than update the software again, removing all similar software:
+        const formDataWithNoSimilarSoftware: SoftwareFormData = {
+            ...craSoftwareFormData,
+            similarSoftwareExternalDataIds: []
+        };
+        await updateSoftware({
+            formData: formDataWithNoSimilarSoftware,
+            softwareId: craSoftwareId,
+            userId
+        });
+
+        const finalSimilarSofts = await dbApi.software.getSimilarSoftwareExternalDataPks({
+            softwareId: craSoftwareId
+        });
+        expectToMatchObject(finalSimilarSofts, []);
     });
 });