Fix rule texts parsing #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They weren't using expect() so rspec wasn't testing anything.
It was using squeeze method without any parameter which will squeeze all characters. Texts like "Message-Id is not valid, according to RFC 2822" were parsed as "Mesage-Id is not valid, acording to RFC 282". Note that Message-Id was changed to Mesage-Id and RFC 2822 was changed to RFC 282.
|
Ping. I could use this as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was using squeeze method without any parameter which will squeeze all characters.
Texts like
were parsed as
Note that Message-Id was changed to Mesage-Id and RFC 2822 was changed to RFC 282.
As a bonus I corrected the tests in https://github.com/codefriar/RubySpamAssassin/blob/af6d81bdfe0a1438a1911f46d68b1ec3a5e262b6/spec/RubySpamAssassin/report_parser_spec.rb which weren't testing anything since they didn't used expect() method.