add registry data source

Author: yaroslav-codefresh

client/registry.go

@@ -44,8 +44,9 @@ func (registry *Registry) GetID() string {
 	return registry.Id
 }
 
-func (client *Client) GetRegistry(name string) (*Registry, error) {
-	fullPath := fmt.Sprintf("/registries/%s?includePrivate=true", url.PathEscape(name))
+// GetRegistry identifier is ObjectId or name
+func (client *Client) GetRegistry(identifier string) (*Registry, error) {
+	fullPath := fmt.Sprintf("/registries/%s", url.PathEscape(identifier))
 	opts := RequestOptions{
 		Path:   fullPath,
 		Method: "GET",

codefresh/data_registry.go

@@ -0,0 +1,89 @@
+package codefresh
+
+import (
+	"fmt"
+
+	cfClient "github.com/codefresh-io/terraform-provider-codefresh/client"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+)
+
+func dataSourceRegistry() *schema.Resource {
+	return &schema.Resource{
+		Read: dataSourceRegistryRead,
+		Schema: map[string]*schema.Schema{
+			"name": {
+				Type:     schema.TypeString,
+				Required: true,
+			},
+			"kind": {
+				Type:     schema.TypeString,
+				Computed: true,
+			},
+			"domain": {
+				Type:     schema.TypeString,
+				Computed: true,
+			},
+			"registry_provider": {
+				Type:     schema.TypeString,
+				Computed: true,
+			},
+			"default": {
+				Type:     schema.TypeBool,
+				Computed: true,
+			},
+			"primary": {
+				Type:     schema.TypeBool,
+				Computed: true,
+			},
+			"fallback_registry": {
+				Type:     schema.TypeString,
+				Computed: true,
+			},
+			"repository_prefix": {
+				Type:     schema.TypeString,
+				Computed: true,
+			},
+		},
+	}
+}
+
+func dataSourceRegistryRead(d *schema.ResourceData, meta interface{}) error {
+
+	client := meta.(*cfClient.Client)
+	var registry *cfClient.Registry
+	var err error
+
+	if name, nameOk := d.GetOk("name"); nameOk {
+		registry, err = client.GetRegistry(name.(string))
+	} else {
+		return fmt.Errorf("data.codefresh_registry - must specify name")
+	}
+	if err != nil {
+		return err
+	}
+
+	if registry == nil {
+		return fmt.Errorf("data.codefresh_registry - cannot find registry")
+	}
+
+	return mapDataRegistryToResource(registry, d)
+}
+
+func mapDataRegistryToResource(registry *cfClient.Registry, d *schema.ResourceData) error {
+
+	if registry == nil || registry.Name == "" {
+		return fmt.Errorf("data.codefresh_registry - failed to mapDataRegistryToResource")
+	}
+	d.SetId(registry.Id)
+
+	d.Set("name", registry.Name)
+	d.Set("registry_provider", registry.Provider)
+	d.Set("kind", registry.Kind)
+	d.Set("domain", registry.Domain)
+	d.Set("primary", registry.Primary)
+	d.Set("default", registry.Default)
+	d.Set("fallback_registry", registry.FallbackRegistry)
+	d.Set("repository_prefix", registry.RepositoryPrefix)
+
+	return nil
+}

codefresh/provider.go

@@ -35,6 +35,7 @@ func Provider() *schema.Provider {
 			"codefresh_team":            dataSourceTeam(),
 			"codefresh_user":            dataSourceUser(),
 			"codefresh_users":           dataSourceUsers(),
+			"codefresh_registry":        dataSourceRegistry(),
 		},
 		ResourcesMap: map[string]*schema.Resource{
 			"codefresh_account":        resourceAccount(),

codefresh/resource_registry.go

@@ -256,6 +256,7 @@ func resourceRegistry() *schema.Resource {
 									"behind_firewall": {
 										Type:     schema.TypeBool,
 										Optional: true,
+										Default:  false,
 										ForceNew: true,
 									},
 								},

examples/registries/main.tf

@@ -20,6 +20,7 @@ provider "codefresh" {
 
 resource "codefresh_registry" "acr" {
   name = "acr"
+  default = true
   spec {
     acr {
       domain            = "acr.io"
@@ -32,6 +33,8 @@ resource "codefresh_registry" "acr" {
 
 resource "codefresh_registry" "gcr" {
   name = "gcr"
+  #  all registries SHOULD be dependent on each other to be created/updated sequentially
+  depends_on = [codefresh_registry.acr]
   spec {
     gcr {
       domain            = "gcr.io"
@@ -43,6 +46,7 @@ resource "codefresh_registry" "gcr" {
 
 resource "codefresh_registry" "gar" {
   name = "gar"
+  depends_on = [codefresh_registry.gcr]
   spec {
     gar {
       domain            = "asia"
@@ -52,19 +56,27 @@ resource "codefresh_registry" "gar" {
   }
 }
 
-resource "codefresh_registry" "dockerhub" {
+data "codefresh_registry" "dockerhub" {
+  name = "dockerhub"
+}
+
+# example with using data reference to existing registry, not managed by terraform
+resource "codefresh_registry" "dockerhub1" {
   name    = "dockerhub1"
-  primary = false
+  primary = !data.codefresh_registry.dockerhub.primary
+  depends_on = [codefresh_registry.gar]
   spec {
     dockerhub {
       username = "test"
       password = "test"
     }
   }
+  fallback_registry = data.codefresh_registry.dockerhub.id
 }
 
 resource "codefresh_registry" "bintray" {
   name = "bintray"
+  depends_on = [codefresh_registry.dockerhub1]
   spec {
     bintray {
       domain   = "bintray.io"
@@ -76,7 +88,8 @@ resource "codefresh_registry" "bintray" {
 
 resource "codefresh_registry" "other" {
   name    = "other"
-  primary = true
+  depends_on = [codefresh_registry.bintray]
+  primary = false
   spec {
     other {
       domain   = "other.io"
@@ -86,9 +99,14 @@ resource "codefresh_registry" "other" {
   }
 }
 
+# when you have multiple registries under the same domain
+# they MUST be dependant on each other and `primary`
+# MUST be specified at least and only for one registry
+# as `true`
 resource "codefresh_registry" "other1" {
   name    = "other1"
-  primary = false
+  primary = true
+  depends_on = [codefresh_registry.other]
   spec {
     other {
       domain   = "other.io"
@@ -101,11 +119,13 @@ resource "codefresh_registry" "other1" {
 resource "codefresh_registry" "other2" {
   name    = "other2"
   primary = false
+  depends_on = [codefresh_registry.other1, codefresh_registry.bintray]
   spec {
     other {
       domain   = "other.io"
       username = "test"
       password = "test"
     }
   }
+  fallback_registry = codefresh_registry.bintray.id
 }