close connections

Author: pasha-codefresh

pkg/codefresh/argo.go

@@ -102,6 +102,8 @@ func (a *argo) GetIntegrations() ([]*IntegrationPayload, error) {
 		return nil, err
 	}
 
+	defer resp.Body.Close()
+
 	return result, nil
 }
 
@@ -123,6 +125,8 @@ func (a *argo) GetIntegrationByName(name string) (*IntegrationPayload, error) {
 		return nil, err
 	}
 
+	defer resp.Body.Close()
+
 	return &result, nil
 }
 
@@ -150,7 +154,7 @@ func (a *argo) HeartBeat(error string, version string, integration string) error
 		body.AgentVersion = version
 	}
 
-	_, err := a.codefresh.requestAPI(&requestOptions{
+	resp, err := a.codefresh.requestAPI(&requestOptions{
 		method: "POST",
 		path:   fmt.Sprintf("/api/argo-agent/%s/heartbeat", integration),
 		body:   body,
@@ -159,6 +163,8 @@ func (a *argo) HeartBeat(error string, version string, integration string) error
 		return err
 	}
 
+	defer resp.Body.Close()
+
 	return nil
 }
 
@@ -167,7 +173,7 @@ func (a *argo) SendResources(kind string, items interface{}, amount int, integra
 		return nil
 	}
 
-	_, err := a.codefresh.requestAPI(&requestOptions{
+	resp, err := a.codefresh.requestAPI(&requestOptions{
 		method: "POST",
 		path:   fmt.Sprintf("/api/argo-agent/%s", integration),
 		body:   &AgentState{Kind: kind, Items: items},
@@ -176,5 +182,7 @@ func (a *argo) SendResources(kind string, items interface{}, amount int, integra
 		return err
 	}
 
+	defer resp.Body.Close()
+
 	return nil
 }

pkg/codefresh/cluster.go

@@ -42,6 +42,9 @@ func (p *cluster) GetClusterCredentialsByAccountId(selector string) (*Cluster, e
 		method: "GET",
 	})
 	err = p.codefresh.decodeResponseInto(resp, &r)
+
+	defer resp.Body.Close()
+
 	return r, err
 }
 
@@ -52,5 +55,8 @@ func (p *cluster) GetAccountClusters() ([]*ClusterMinified, error) {
 		method: "GET",
 	})
 	err = p.codefresh.decodeResponseInto(resp, &r)
+
+	defer resp.Body.Close()
+
 	return r, err
 }

pkg/codefresh/contexts.go

@@ -64,6 +64,8 @@ func (c context) GetGitContexts() (error, *[]ContextPayload) {
 
 	err = c.codefresh.decodeResponseInto(resp, &result)
 
+	defer resp.Body.Close()
+
 	return err, &result
 }
 
@@ -84,6 +86,8 @@ func (c context) GetGitContextByName(name string) (error, *ContextPayload) {
 
 	err = c.codefresh.decodeResponseInto(resp, &result)
 
+	defer resp.Body.Close()
+
 	return nil, &result
 }
 
@@ -101,5 +105,7 @@ func (c context) GetDefaultGitContext() (error, *ContextPayload) {
 
 	err = c.codefresh.decodeResponseInto(resp, &result)
 
+	defer resp.Body.Close()
+
 	return err, &result
 }

pkg/codefresh/gitops.go

@@ -134,7 +134,7 @@ func newGitopsAPI(codefresh *codefresh) GitopsAPI {
 }
 
 func (a *gitops) CreateEnvironment(name string, project string, application string, integration string, namespace string) error {
-	_, err := a.codefresh.requestAPI(&requestOptions{
+	resp, err := a.codefresh.requestAPI(&requestOptions{
 		method: "POST",
 		path:   "/api/gitops/application",
 		body: &EnvironmentPayload{
@@ -155,6 +155,8 @@ func (a *gitops) CreateEnvironment(name string, project string, application stri
 		return err
 	}
 
+	defer resp.Body.Close()
+
 	return nil
 }
 
@@ -171,17 +173,20 @@ func (a *gitops) SendEnvironment(environment Environment) (map[string]interface{
 		return nil, err
 	}
 
+	defer resp.Body.Close()
+
 	return result, nil
 }
 
 func (a *gitops) DeleteEnvironment(name string) error {
-	_, err := a.codefresh.requestAPI(&requestOptions{
+	resp, err := a.codefresh.requestAPI(&requestOptions{
 		method: "DELETE",
 		path:   fmt.Sprintf("/api/environments-v2/%s", name),
 	})
 	if err != nil {
 		return err
 	}
+	defer resp.Body.Close()
 
 	return nil
 }
@@ -196,6 +201,8 @@ func (a *gitops) GetEnvironments() ([]CFEnvironment, error) {
 		return nil, err
 	}
 
+	defer resp.Body.Close()
+
 	err = a.codefresh.decodeResponseInto(resp, &result)
 
 	if err != nil {
@@ -208,7 +215,7 @@ func (a *gitops) GetEnvironments() ([]CFEnvironment, error) {
 func (a *gitops) SendEvent(name string, props map[string]string) error {
 	event := CodefreshEvent{Event: name, Props: props}
 
-	_, err := a.codefresh.requestAPI(&requestOptions{
+	resp, err := a.codefresh.requestAPI(&requestOptions{
 		method: "POST",
 		path:   "/api/gitops/system/events",
 		body:   event,
@@ -217,17 +224,20 @@ func (a *gitops) SendEvent(name string, props map[string]string) error {
 		return err
 	}
 
+	defer resp.Body.Close()
+
 	return nil
 }
 
 func (a *gitops) SendApplicationResources(resources *ApplicationResources) error {
-	_, err := a.codefresh.requestAPI(&requestOptions{
+	resp, err := a.codefresh.requestAPI(&requestOptions{
 		method: "POST",
 		path:   fmt.Sprintf("/api/gitops/resources"),
 		body:   &resources,
 	})
 	if err != nil {
 		return err
 	}
+	defer resp.Body.Close()
 	return nil
 }