Skip to content

fix: update namespace handling in cluster resource reporter #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from
Closed

fix: update namespace handling in cluster resource reporter #974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
45176da
chore: update app version and chart version in Chart.yaml to 1.0.0-rc…
dmaizel Nov 10, 2025
3c1f240
dummy PR (#909)
eti-codefresh Nov 11, 2025
d65791d
fix: retry on notFound before updating resource status (#914)
codefresh-v2-pipelines[bot] Nov 13, 2025
03999e5
[gitops-operator]fix: set transient error (#923)
codefresh-v2-pipelines[bot] Nov 16, 2025
9d8270b
feat: disable Argo Rollouts by default and enable namespace-scoped Ar…
dmaizel Nov 17, 2025
9c22249
feat: add branch data to pullrequest info (#932)
codefresh-v2-pipelines[bot] Nov 17, 2025
7f6b6da
[cf-argocd-extras]chore: update depencencies (argo-cd 3.2) (#930)
codefresh-v2-pipelines[bot] Nov 18, 2025
1b011d7
feat: checksum annotations (#938) (#942)
mikhail-klimko Nov 19, 2025
ebf0de0
[app-proxy]fix(app-proxy): update autoDetectArgoCd to use new values …
codefresh-v2-pipelines[bot] Nov 19, 2025
f72f319
feat: multi-runtime installation (#939) (#946)
shirtabachii Nov 19, 2025
e0a6c22
[gitops-operator]fix: remove git commit statuses (monthly/25.11) (#947)
codefresh-v2-pipelines[bot] Nov 19, 2025
90b0d32
feat: ensure default-git-source exists on every app-proxy restart (#956)
codefresh-v2-pipelines[bot] Nov 23, 2025
ba36208
fix: remove nonResourceURLs from RBAC rules for event reporters
ATGardner Nov 26, 2025
cf8bb7e
fix: add IS_NAMESPACED_RUNTIME variable to environment variables for …
ATGardner Nov 27, 2025
49c2b7e
[cf-argocd-extras]fix: update namespace handling in cluster resource …
codefresh-v2-pipelines[bot] Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions charts/gitops-runtime/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
apiVersion: v2
appVersion: 0.1.72
appVersion: 1.0.0-rc.1
description: A Helm chart for Codefresh gitops runtime
name: gitops-runtime
version: 0.0.0
version: 25.11-0
home: https://github.com/codefresh-io/gitops-runtime-helm
icon: https://avatars1.githubusercontent.com/u/11412079?v=3
keywords:
Expand All @@ -24,7 +24,7 @@ dependencies:
condition: argo-events.enabled
- name: argo-workflows
repository: https://codefresh-io.github.io/argo-helm
version: 0.45.17-v3.6.7-cap-CR-31761
version: 0.45.16-v3.6.7-cap-CR-30835
condition: argo-workflows.enabled
- name: argo-rollouts
repository: https://codefresh-io.github.io/argo-helm
Expand Down
1 change: 1 addition & 0 deletions charts/gitops-runtime/templates/event-reporters/cluster-event-reporter/_env.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
HTTP_PROXY: {{ .Values.global.httpProxy | squote}}
HTTPS_PROXY: {{ .Values.global.httpsProxy | squote }}
NO_PROXY: {{ .Values.global.noProxy | squote }}
IS_NAMESPACED_RUNTIME: {{ .Values.global.runtime.singleNamespace }}

{{- if and (eq (index .Values "global" "integrations" "argo-cd" "server" "auth" "type") "token") }}
{{- if not (index .Values "global" "integrations" "argo-cd" "server" "auth" "token") }}
Expand Down
4 changes: 0 additions & 4 deletions charts/gitops-runtime/templates/event-reporters/cluster-event-reporter/rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,6 @@ rules:
- '*'
verbs:
- '*'
- nonResourceURLs:
- '*'
verbs:
- '*'
---
apiVersion: rbac.authorization.k8s.io/v1
kind: {{ $context.Values.global.runtime.singleNamespace | ternary "RoleBinding" "ClusterRoleBinding" }}
Expand Down
1 change: 1 addition & 0 deletions charts/gitops-runtime/templates/event-reporters/runtime-event-reporter/_env.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
HTTP_PROXY: {{ .Values.global.httpProxy | squote}}
HTTPS_PROXY: {{ .Values.global.httpsProxy | squote }}
NO_PROXY: {{ .Values.global.noProxy | squote }}
IS_NAMESPACED_RUNTIME: {{ .Values.global.runtime.singleNamespace }}

{{- if and (eq (index .Values "global" "integrations" "argo-cd" "server" "auth" "type") "token") }}
{{- if not (index .Values "global" "integrations" "argo-cd" "server" "auth" "token") }}
Expand Down
4 changes: 0 additions & 4 deletions charts/gitops-runtime/templates/event-reporters/runtime-event-reporter/rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,6 @@ rules:
- '*'
verbs:
- '*'
- nonResourceURLs:
- '*'
verbs:
- '*'
---
apiVersion: rbac.authorization.k8s.io/v1
kind: {{ $context.Values.global.runtime.singleNamespace | ternary "RoleBinding" "ClusterRoleBinding" }}
Expand Down
29 changes: 29 additions & 0 deletions charts/gitops-runtime/tests/checksum_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# yaml-language-server: $schema=https://raw.githubusercontent.com/helm-unittest/helm-unittest/main/schema/helm-testsuite.json
suite: checksum tests
templates:
- event-reporters/**/deployment.yaml
- event-reporters/**/configmap.yaml
- argo-gateway/deployment.yaml
- argo-gateway/configmap.yaml
- app-proxy/deployment.yaml
- app-proxy/config.yaml
- _components/cap-app-proxy/_deployment.yaml
- _components/cap-app-proxy/_config.yaml
- codefresh-cm.yaml
tests:
- it: default checksum annotations is present
values:
- ./values/mandatory-values-ingress.yaml
asserts:
- exists:
path: spec.template.metadata.annotations["checksum/config-argo-gateway"]
template: argo-gateway/deployment.yaml
- exists:
path: spec.template.metadata.annotations["checksum/config-event-reporter"]
template: event-reporters/cluster-event-reporter/deployment.yaml
- exists:
path: spec.template.metadata.annotations["checksum/config-argocd"]
template: event-reporters/cluster-event-reporter/deployment.yaml
- exists:
path: spec.template.metadata.annotations["checksum/config-cap-app-proxy"]
template: app-proxy/deployment.yaml
10 changes: 5 additions & 5 deletions charts/gitops-runtime/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ global:
image:
registry: quay.io
repository: codefresh/cf-argocd-extras
tag: 2cb6f85
tag: e6944d6
nodeSelector: {}
tolerations: []
affinity: {}
Expand Down Expand Up @@ -495,14 +495,14 @@ app-proxy:
tag: 1.1.17-main
image:
repository: quay.io/codefresh/cap-app-proxy
tag: 1.3953.0
tag: 0afa16e
pullPolicy: IfNotPresent
# -- Extra volume mounts for main container
extraVolumeMounts: []
initContainer:
image:
repository: quay.io/codefresh/cap-app-proxy-init
tag: 1.3953.0
tag: 0afa16e
pullPolicy: IfNotPresent
command:
- ./init.sh
Expand Down Expand Up @@ -683,7 +683,7 @@ gitops-operator:
image:
registry: quay.io
repository: codefresh/codefresh-gitops-operator
tag: "7bcd56b"
tag: "ff25956"
env:
!!merge <<:
- *otel-config
Expand Down Expand Up @@ -715,7 +715,7 @@ argo-gateway:
image:
registry: quay.io
repository: codefresh/cf-argocd-extras
tag: 2cb6f85
tag: e6944d6
nodeSelector: {}
tolerations: []
affinity: {}
Expand Down