Skip to content

feat: set fullnameoverride for argocd #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 10, 2025
Merged

feat: set fullnameoverride for argocd #907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dd41726
feat: set fullnameoverride for argocd
mikhail-klimko Nov 10, 2025
e5bbb2b
Revert "feat: set fullnameoverride for argocd"
mikhail-klimko Nov 10, 2025
a6bf3ce
feat: set fullnameoverride for argocd
mikhail-klimko Nov 10, 2025
09e1ae0
feat: set fullnameoverride for argocd
mikhail-klimko Nov 10, 2025
1f44b91
feat: set fullnameoverride for argocd
mikhail-klimko Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/gitops-runtime/tests/argo-api-gateway_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@ tests:
asserts:
- equal:
path: data["argocd.server"]
value: argocd-server:80
value: argo-cd-server:80
- equal:
path: data["redis.server"]
value: runtime-redis:6379
- equal:
path: data["repo.server"]
value: argocd-repo-server:8081
value: argo-cd-repo-server:8081

- it: Argo Api Gateway Deployment should have valid matchLabel selectors
template: argo-gateway/deployment.yaml
Expand Down
4 changes: 2 additions & 2 deletions charts/gitops-runtime/tests/event-reporters_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,13 @@ tests:
asserts:
- equal:
path: data["argocd.server"]
value: argocd-server:80
value: argo-cd-server:80
- equal:
path: data["redis.server"]
value: runtime-redis:6379
- equal:
path: data["repo.server"]
value: argocd-repo-server:8081
value: argo-cd-repo-server:8081

- it: Runtime Reporter ConfigMap should have valid redis-ha url
template: event-reporters/runtime-event-reporter/configmap.yaml
Expand Down
6 changes: 3 additions & 3 deletions charts/gitops-runtime/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ global:
# name: argocd-token
# key: token
# -- Service name of the ArgoCD server
svc: argocd-server
svc: argo-cd-server
# -- Port of the ArgoCD server
port: 80
# -- Set if Argo CD is running behind reverse proxy under subpath different from /
Expand All @@ -115,7 +115,7 @@ global:
rootpath: ''
repoServer:
# -- Service name of the ArgoCD repo server
svc: argocd-repo-server
svc: argo-cd-repo-server
# -- Port of the ArgoCD repo server
port: 8081
# -- Configuration for external Argo Rollouts
Expand Down Expand Up @@ -264,7 +264,7 @@ sealed-secrets:
#-----------------------------------------------------------------------------------------------------------------------
argo-cd:
enabled: true
fullnameOverride: argocd
fullnameOverride: argo-cd
notifications:
enabled: false
redis:
Expand Down