Fix CLI wizard summary & text (#655)

* Fix CLI wizard summary & text

* bump

Author: danielm-codefresh

Makefile

@@ -1,4 +1,4 @@
-VERSION=v0.1.16
+VERSION=v0.1.17
 
 OUT_DIR=dist
 YEAR?=$(shell date +"%Y")

cmd/commands/common.go

@@ -521,7 +521,7 @@ func getAccessModeFromUserSelect(accessMode *platmodel.AccessMode) error {
 
 	prompt := promptui.Select{
 		Label:     labelStr,
-		Items:     []string{"Codefresh Tunnel Based", "Ingress Based"},
+		Items:     []string{"Codefresh tunnel-based", "Ingress-based"},
 		Templates: templates,
 	}
 

cmd/commands/runtime.go

@@ -576,13 +576,16 @@ func runRuntimeUninstall(ctx context.Context, opts *RuntimeUninstallOptions) err
 		cfConfig.GetCurrentContext().DefaultRuntime = ""
 	}
 
-	err = runPostUninstallCleanup(ctx, opts.KubeFactory, opts.RuntimeName)
-	if err != nil {
-		errorMsg := fmt.Sprintf("failed to do post uninstall cleanup: %v", err)
-		if !opts.Force {
-			return fmt.Errorf(errorMsg)
+
+	if !opts.Managed {
+		err = runPostUninstallCleanup(ctx, opts.KubeFactory, opts.RuntimeName)
+		if err != nil {
+			errorMsg := fmt.Sprintf("failed to do post uninstall cleanup: %v", err)
+			if !opts.Force {
+				return fmt.Errorf(errorMsg)
+			}
+			log.G().Warn(errorMsg)
 		}
-		log.G().Warn(errorMsg)
 	}
 
 	uninstallDoneStr := fmt.Sprintf("Done uninstalling runtime \"%s\"", opts.RuntimeName)

cmd/commands/runtime_install.go

@@ -223,13 +223,16 @@ func NewRuntimeInstallCommand() *cobra.Command {
 				"Repository URL":            installationOpts.InsCloneOpts.Repo,
 				"Ingress class":             installationOpts.IngressClass,
 				"Installing demo resources": strconv.FormatBool(installationOpts.InstallDemoResources),
+				"Git provider":              string(installationOpts.gitProvider.Type()),
 			}
 
 			if installationOpts.AccessMode == platmodel.AccessModeTunnel {
 				finalParameters["Tunnel URL"] = installationOpts.IngressHost
+				finalParameters["Access mode"] = "Codefresh tunnel-based"
 			} else {
 				finalParameters["Ingress host"] = installationOpts.IngressHost
 				finalParameters["Internal ingress host"] = installationOpts.InternalIngressHost
+				finalParameters["Access mode"] = "Ingress-based"
 			}
 
 			if err := getApprovalFromUser(ctx, finalParameters, "runtime install"); err != nil {

docs/releases/release_notes.md

@@ -23,7 +23,7 @@ cf version
 
 ```bash
 # download and extract the binary
-curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.1.16/cf-linux-amd64.tar.gz | tar zx
+curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.1.17/cf-linux-amd64.tar.gz | tar zx
 
 # move the binary to your $PATH
 mv ./cf-linux-amd64 /usr/local/bin/cf
@@ -36,7 +36,7 @@ cf version
 
 ```bash
 # download and extract the binary
-curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.1.16/cf-darwin-amd64.tar.gz | tar zx
+curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.1.17/cf-darwin-amd64.tar.gz | tar zx
 
 # move the binary to your $PATH
 mv ./cf-darwin-amd64 /usr/local/bin/cf

pkg/git/provider.go

@@ -97,8 +97,8 @@ func GetProvider(providerType ProviderType, baseURL, certFile string) (Provider,
 func getGitProviderFromUserSelect(baseURL string, client *http.Client) (Provider) {
 	var providers = map[string]func(string, *http.Client) (Provider, error){
 		"Bitbucket": NewBitbucketServerProvider,
-		"Github":    NewGithubProvider,
-		"Gitlab":    NewGitlabProvider,
+		"GitHub":    NewGithubProvider,
+		"GitLab":    NewGitlabProvider,
 	}
 
 	templates := &promptui.SelectTemplates{
@@ -109,7 +109,7 @@ func getGitProviderFromUserSelect(baseURL string, client *http.Client) (Provider
 
 	prompt := promptui.Select{
 		Label:     labelStr,
-		Items:     []string{"Github", "Gitlab", "Bitbucket"},
+		Items:     []string{"GitHub", "GitLab", "Bitbucket"},
 		Templates: templates,
 	}
 

pkg/reporter/reporter.go

@@ -207,8 +207,6 @@ func (r *segmentAnalyticsReporter) Close(status CliStepStatus, err error) {
 		}
 	}
 
-	log.G().Infof("Closing with status %s", status)
-
 	r.ReportStep(CliStepData{
 		Step:        FINISH,
 		Status:      status,