Cr 14126- fix (#551)

* support bitbucket cloud

* bump

* generic retry

* lint fix

* lint fix

* add one sec sleep between retries

* wip

* bump

Author: kim-codefresh

Makefile

@@ -1,4 +1,4 @@
-VERSION=v0.0.494
+VERSION=v0.0.495
 
 OUT_DIR=dist
 YEAR?=$(shell date +"%Y")

cmd/commands/runtime_install.go

@@ -687,7 +687,7 @@ func runRuntimeInstall(ctx context.Context, opts *RuntimeInstallOptions) error {
 				return updateCodefreshCM(ctx, opts, rt, server)
 			}
 		},
-		Sleep: 2,
+		Sleep: 2 * time.Second,
 	})
 	handleCliStep(reporter.InstallStepCreateOrUpdateConfigMap, "Creating/Updating codefresh-cm", err, false, true)
 	if err != nil {

docs/releases/release_notes.md

@@ -23,7 +23,7 @@ cf version
 
 ```bash
 # download and extract the binary
-curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.494/cf-linux-amd64.tar.gz | tar zx
+curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.495/cf-linux-amd64.tar.gz | tar zx
 
 # move the binary to your $PATH
 mv ./cf-linux-amd64 /usr/local/bin/cf
@@ -36,7 +36,7 @@ cf version
 
 ```bash
 # download and extract the binary
-curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.494/cf-darwin-amd64.tar.gz | tar zx
+curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.495/cf-darwin-amd64.tar.gz | tar zx
 
 # move the binary to your $PATH
 mv ./cf-darwin-amd64 /usr/local/bin/cf

manifests/runtime.yaml

@@ -5,7 +5,7 @@ metadata:
   namespace: "{{ namespace }}"
 spec:
   defVersion: 1.0.1
-  version: 0.0.494
+  version: 0.0.495
   bootstrapSpecifier: github.com/codefresh-io/cli-v2/manifests/argo-cd
   components:
     - name: events

pkg/util/util.go

@@ -42,7 +42,7 @@ import (
 type RetryOptions struct {
 	Func    func() error
 	Retries int
-	Sleep   int
+	Sleep   time.Duration
 }
 
 const (
@@ -368,7 +368,13 @@ func Retry(ctx context.Context, opts *RetryOptions) error {
 		log.G(ctx).WithFields(log.Fields{
 			"retry": try,
 			"err":   err.Error(),
-		}).Warn("Failed to create event reporter, trying again")
+		}).Warn("Function call failed, trying again")
+
+		if opts.Sleep != 0 {
+			time.Sleep(opts.Sleep)
+		} else {
+			time.Sleep(time.Second)
+		}
 	}
 
 	return err