[BE]:Add runtime install validation (#414)

* Handle validation check

* Fix

* Fix

* Update

* Refactor

* Refactor

* Fix bug related with silent mode

* Up version

* Lint

* Add ingress validation

* Add ingress validation

* Add repository validation

* Up version

* Valid ingressHost protocol

* Valid ingressHost protocol

* Update message

Author: PhilippPlotnikov

Makefile

@@ -1,4 +1,4 @@
-VERSION=v0.0.365
+VERSION=v0.0.366
 
 OUT_DIR=dist
 YEAR?=$(shell date +"%Y")

cmd/commands/common.go

@@ -34,6 +34,7 @@ import (
 	"github.com/codefresh-io/cli-v2/pkg/util"
 
 	"github.com/argoproj-labs/argocd-autopilot/pkg/git"
+	autoPilotUtil "github.com/argoproj-labs/argocd-autopilot/pkg/util"
 	"github.com/manifoldco/promptui"
 	"github.com/spf13/cobra"
 	"github.com/spf13/pflag"
@@ -83,7 +84,11 @@ func IsValidName(s string) (bool, error) {
 }
 
 func isValidIngressHost(ingressHost string) (bool, error) {
-	return regexp.MatchString(`^(http|https)://`, ingressHost)
+	pattern := `^https://`
+	if store.Get().InsecureIngressHost {
+		pattern = `^(http|https)://`
+	}
+	return regexp.MatchString(pattern, ingressHost)
 }
 
 func askUserIfToInstallDemoResources(cmd *cobra.Command, sampleInstall *bool) error {
@@ -149,6 +154,13 @@ func ensureRepo(cmd *cobra.Command, runtimeName string, cloneOpts *git.CloneOpti
 func getRepoFromUserInput(cmd *cobra.Command) error {
 	repoPrompt := promptui.Prompt{
 		Label: "Repository URL",
+		Validate: func(value string) error {
+			host, orgRepo, _, _, _, _, _ := autoPilotUtil.ParseGitUrl(value)
+			if host != "" && orgRepo != "" {
+				return nil
+			}
+			return fmt.Errorf("Invalid URL for Git repository")
+		},
 	}
 	repoInput, err := repoPrompt.Run()
 	if err != nil {
@@ -225,7 +237,7 @@ func validateRuntimeName(runtime string) error {
 		return fmt.Errorf("failed to validate runtime name: %w", err)
 	}
 	if !isValid {
-		return fmt.Errorf("runtime name cannot have any uppercase letters, must start with a character, end with character or number, and be shorter than 63 chars")
+		return fmt.Errorf("Runtime name must start with a lower-case character, and can include up to 62 lower-case characters and numbers")
 	}
 	return nil
 }
@@ -276,10 +288,10 @@ func inferProviderFromRepo(opts *git.CloneOptions) {
 }
 
 func ensureGitToken(cmd *cobra.Command, cloneOpts *git.CloneOptions, verify bool) error {
-	errMessage := "Value from environment variable TOKEN is not valid, enter another value"
+	errMessage := "Value stored in environment variable TOKEN is invalid; enter a valid runtime token"
 	if cloneOpts.Auth.Password == "" && !store.Get().Silent {
 		err := getGitTokenFromUserInput(cmd)
-		errMessage = "Entered git token is not valid, enter another value please"
+		errMessage = "Invalid runtime token; enter a valid token"
 		if err != nil {
 			return err
 		}
@@ -440,7 +452,7 @@ func validateIngressHost(ingressHost string) error {
 	if err != nil {
 		err = fmt.Errorf("could not verify ingress host: %w", err)
 	} else if !isValid {
-		err = fmt.Errorf("ingress host must begin with protocol 'http://' or 'https://'")
+		err = fmt.Errorf("Ingress host must begin with a protocol, either http:// or https://")
 	}
 
 	return err
@@ -484,6 +496,11 @@ func setIngressHost(ctx context.Context, opts *RuntimeInstallOptions) error {
 		if err != nil {
 			return err
 		}
+		_, err := http.Get(opts.IngressHost)
+		if err != nil {
+			opts.IngressHost = ""
+			return err
+		}
 	}
 
 	if opts.IngressHost == "" {

cmd/commands/runtime.go

@@ -332,7 +332,7 @@ func runtimeInstallCommandPreRunHandler(cmd *cobra.Command, opts *RuntimeInstall
 		return err
 	}
 
-	err = ensureIngressHost(cmd, opts)
+	err = getIngressHost(cmd, opts)
 	handleCliStep(reporter.InstallStepPreCheckEnsureIngressHost, "Getting ingressHost", err, true, false)
 	if err != nil {
 		return err
@@ -393,14 +393,31 @@ func runtimeInstallCommandPreRunHandler(cmd *cobra.Command, opts *RuntimeInstall
 	return nil
 }
 
+func getIngressHost(cmd *cobra.Command, opts *RuntimeInstallOptions) error {
+	var err error
+	if store.Get().Silent {
+		err = ensureIngressHost(cmd, opts)
+	} else {
+		handleValidationFailsWithRepeat(func() error {
+			err = ensureIngressHost(cmd, opts)
+			if isValidationError(err) {
+				fmt.Println("Could not resolve the URL for ingress host; enter a valid URL")
+				return err
+			}
+			return nil
+		})
+	}
+	return err
+}
+
 func getGitToken(cmd *cobra.Command, opts *RuntimeInstallOptions) error {
 	var err error
 	if store.Get().Silent {
 		err = ensureGitToken(cmd, opts.InsCloneOpts, true)
 	} else {
 		handleValidationFailsWithRepeat(func() error {
 			err = ensureGitToken(cmd, opts.InsCloneOpts, true)
-			if isValidationError(err) && !store.Get().Silent {
+			if isValidationError(err) {
 				fmt.Println(err)
 				return err
 			}

docs/releases/release_notes.md

@@ -23,7 +23,7 @@ cf version
 
 ```bash
 # download and extract the binary
-curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.365/cf-linux-amd64.tar.gz | tar zx
+curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.366/cf-linux-amd64.tar.gz | tar zx
 
 # move the binary to your $PATH
 mv ./cf-linux-amd64 /usr/local/bin/cf
@@ -36,7 +36,7 @@ cf version
 
 ```bash
 # download and extract the binary
-curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.365/cf-darwin-amd64.tar.gz | tar zx
+curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.366/cf-darwin-amd64.tar.gz | tar zx
 
 # move the binary to your $PATH
 mv ./cf-darwin-amd64 /usr/local/bin/cf

manifests/runtime.yaml

@@ -5,7 +5,7 @@ metadata:
   namespace: "{{ namespace }}"
 spec:
   defVersion: 1.0.1
-  version: 0.0.365
+  version: 0.0.366
   bootstrapSpecifier: github.com/codefresh-io/cli-v2/manifests/argo-cd
   components:
     - name: events