CR-5968-failure-report (#149)

* report errors

* report installation errors to platform

* wip

* bump version

* go mod tidy

* improvement

* removed unused func

* error fix

* error fix

Author: rotem-codefresh

Makefile

@@ -1,4 +1,4 @@
-VERSION=v0.0.139
+VERSION=v0.0.140
 
 OUT_DIR=dist
 YEAR?=$(shell date +"%Y")

cmd/commands/runtime.go

@@ -337,6 +337,10 @@ func RunRuntimeInstall(ctx context.Context, opts *RuntimeInstallOptions) error {
 	rt.Spec.IngressHost = opts.IngressHost
 	rt.Spec.Repo = opts.InsCloneOpts.Repo
 
+	var installationErr error
+	
+	defer reportInstallationErrorToPlatform(ctx, opts.RuntimeName, &installationErr)
+	
 	log.G(ctx).WithField("version", rt.Spec.Version).Infof("Installing runtime '%s'", opts.RuntimeName)
 	err = apcmd.RunRepoBootstrap(ctx, &apcmd.RepoBootstrapOptions{
 		AppSpecifier: rt.Spec.FullSpecifier(),
@@ -349,7 +353,8 @@ func RunRuntimeInstall(ctx context.Context, opts *RuntimeInstallOptions) error {
 		},
 	})
 	if err != nil {
-		return fmt.Errorf("failed to bootstrap repository: %w", err)
+		installationErr = fmt.Errorf("failed to bootstrap repository: %w", err)
+		return installationErr
 	}
 
 	err = apcmd.RunProjectCreate(ctx, &apcmd.ProjectCreateOptions{
@@ -360,25 +365,29 @@ func RunRuntimeInstall(ctx context.Context, opts *RuntimeInstallOptions) error {
 		},
 	})
 	if err != nil {
-		return fmt.Errorf("failed to create project: %w", err)
+		installationErr = fmt.Errorf("failed to create project: %w", err)
+		return installationErr
 	}
 
 	// persists codefresh-cm, this must be created before events-reporter eventsource
 	// otherwise it will not start and no events will get to the platform.
 	if err = persistRuntime(ctx, opts.InsCloneOpts, rt, opts.CommonConfig); err != nil {
-		return fmt.Errorf("failed to create codefresh-cm: %w", err)
+		installationErr = fmt.Errorf("failed to create codefresh-cm: %w", err)
+		return installationErr
 	}
 
 	for _, component := range rt.Spec.Components {
 		log.G(ctx).Infof("Creating component '%s'", component.Name)
 		if err = component.CreateApp(ctx, opts.KubeFactory, opts.InsCloneOpts, opts.RuntimeName, store.Get().CFComponentType, "", ""); err != nil {
-			return fmt.Errorf("failed to create '%s' application: %w", component.Name, err)
+			installationErr = fmt.Errorf("failed to create '%s' application: %w", component.Name, err)
+			return installationErr
 		}
 	}
 
 	err = installComponents(ctx, opts, rt)
 	if err != nil {
-		return err
+		installationErr = fmt.Errorf("failed to install components: %s", err)
+		return installationErr
 	}
 
 	if err = RunGitSourceCreate(ctx, &GitSourceCreateOptions{
@@ -388,7 +397,8 @@ func RunRuntimeInstall(ctx context.Context, opts *RuntimeInstallOptions) error {
 		RuntimeName:         opts.RuntimeName,
 		CreateDemoResources: opts.SampleInstall,
 	}); err != nil {
-		return fmt.Errorf("failed to create `%s`: %w", store.Get().GitSourceName, err)
+		installationErr = fmt.Errorf("failed to create `%s`: %w", store.Get().GitSourceName, err)
+		return installationErr
 	}
 
 	mpCloneOpts := &git.CloneOptions{
@@ -405,22 +415,44 @@ func RunRuntimeInstall(ctx context.Context, opts *RuntimeInstallOptions) error {
 		CreateDemoResources: false,
 		Include:             "**/workflowTemplate.yaml",
 	}); err != nil {
-		return fmt.Errorf("failed to create `%s`: %w", store.Get().MarketplaceGitSourceName, err)
+		installationErr = fmt.Errorf("failed to create `%s`: %w", store.Get().MarketplaceGitSourceName, err)
+		return installationErr
 	}
 
 	var wg sync.WaitGroup
 
 	wg.Add(1)
 	err = intervalCheckIsRuntimePersisted(ctx, opts.RuntimeName, &wg)
 	if err != nil {
-		return fmt.Errorf("failed to complete installation: %w", err)
+		installationErr = fmt.Errorf("failed to complete installation: %w", err)
+		return installationErr
 	}
 	wg.Wait()
 
 	log.G(ctx).Infof("Done installing runtime '%s'", opts.RuntimeName)
+	
 	return nil
 }
 
+func reportInstallationErrorToPlatform(ctx context.Context, runtime string, err *error) {
+	if *err == nil {
+		return
+	}
+
+	installationError := &model.HealthErrorInput{
+		Level:   model.ErrorLevelsError,
+		Message: (*err).Error(),
+	}
+	_, err1 := cfConfig.NewClient().V2().Runtime().ReportErrors(ctx, &model.ReportRuntimeErrorsArgs{
+		Runtime: runtime,
+		Errors:  []*model.HealthErrorInput{installationError},
+	})
+
+	if err1 != nil {
+		log.G(ctx).Error("failed to report installation errors of runtime: %s. Error: %s", runtime, err1)
+	}
+}
+
 func installComponents(ctx context.Context, opts *RuntimeInstallOptions, rt *runtime.Runtime) error {
 	var err error
 	if opts.IngressHost != "" {
@@ -515,7 +547,7 @@ func checkExistingRuntimes(ctx context.Context, runtime string) error {
 }
 
 func intervalCheckIsRuntimePersisted(ctx context.Context, runtimeName string, wg *sync.WaitGroup) error {
-	maxRetries := 180           // up to 30 min
+	maxRetries := 180          // up to 30 min
 	longerThanUsualCount := 30 // after 5 min
 	waitMsg := "Waiting for the runtime installation to complete"
 	longetThanUsualMsg := waitMsg + " (this is taking longer than usual, you might need to check your cluster for errors)"

docs/releases/release_notes.md

@@ -20,7 +20,7 @@ cf version
 ### Linux
 ```bash
 # download and extract the binary
-curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.139/cf-linux-amd64.tar.gz | tar zx
+curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.140/cf-linux-amd64.tar.gz | tar zx
 
 # move the binary to your $PATH
 mv ./cf-linux-amd64 /usr/local/bin/cf
@@ -32,7 +32,7 @@ cf version
 ### Mac
 ```bash
 # download and extract the binary
-curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.139/cf-darwin-amd64.tar.gz | tar zx
+curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/140/cf-darwin-amd64.tar.gz | tar zx
 
 # move the binary to your $PATH
 mv ./cf-darwin-amd64 /usr/local/bin/cf

go.mod

@@ -10,7 +10,7 @@ require (
 	github.com/argoproj/argo-events v1.4.0
 	github.com/argoproj/argo-workflows/v3 v3.1.6
 	github.com/briandowns/spinner v1.16.0
-	github.com/codefresh-io/go-sdk v0.35.1
+	github.com/codefresh-io/go-sdk v0.35.4
 	github.com/fatih/color v1.12.0
 	github.com/ghodss/yaml v1.0.1-0.20190212211648-25d852aebe32
 	github.com/go-git/go-billy/v5 v5.3.1

go.sum

@@ -265,8 +265,8 @@ github.com/clusterhq/flocker-go v0.0.0-20160920122132-2b8b7259d313/go.mod h1:P1w
 github.com/cncf/udpa/go v0.0.0-20191209042840-269d4d468f6f/go.mod h1:M8M6+tZqaGXZJjfX53e64911xZQV5JYwmTeXPW+k8Sc=
 github.com/cockroachdb/datadriven v0.0.0-20190809214429-80d97fb3cbaa/go.mod h1:zn76sxSg3SzpJ0PPJaLDCu+Bu0Lg3sKTORVIj19EIF8=
 github.com/codahale/hdrhistogram v0.0.0-20161010025455-3a0bb77429bd/go.mod h1:sE/e/2PUdi/liOCUjSTXgM1o87ZssimdTWN964YiIeI=
-github.com/codefresh-io/go-sdk v0.35.1 h1:4gLZh08WcNpH2MtFrXqy1kFhtbom5O8aKZhMCrU4VS8=
-github.com/codefresh-io/go-sdk v0.35.1/go.mod h1:CcoVmTFWHGkbrSW8LyOGB/vJe5Vzr3iC/pNE2QIBTyg=
+github.com/codefresh-io/go-sdk v0.35.4 h1:7j9Jk8tCaxERXVIxBc5yHdMgSC9uvgxlNXGT7HP/smM=
+github.com/codefresh-io/go-sdk v0.35.4/go.mod h1:CcoVmTFWHGkbrSW8LyOGB/vJe5Vzr3iC/pNE2QIBTyg=
 github.com/colinmarc/hdfs v1.1.4-0.20180802165501-48eb8d6c34a9/go.mod h1:0DumPviB681UcSuJErAbDIOx6SIaJWj463TymfZG02I=
 github.com/colinmarc/hdfs v1.1.4-0.20180805212432-9746310a4d31/go.mod h1:vSBumefK4HA5uiRSwNP+3ofgrEoScpCS2MMWcWXEuQ4=
 github.com/container-storage-interface/spec v1.3.0/go.mod h1:6URME8mwIBbpVyZV93Ce5St17xBiQJQY67NDsuohiy4=

manifests/runtime.yaml

@@ -5,7 +5,7 @@ metadata:
   namespace: "{{ namespace }}"
 spec:
   defVersion: 1.0.0
-  version: 0.0.139
+  version: 0.0.140
   bootstrapSpecifier: github.com/codefresh-io/cli-v2/manifests/argo-cd
   components:
     - name: events