[CLI]:Fix ingress validation (#436)

* Fix ingress validation

* Up version

* Bump

Author: PhilippPlotnikov

Makefile

@@ -1,4 +1,4 @@
-VERSION=v0.0.387
+VERSION=v0.0.388
 
 OUT_DIR=dist
 YEAR?=$(shell date +"%Y")

cmd/commands/common.go

@@ -84,11 +84,7 @@ func IsValidName(s string) (bool, error) {
 }
 
 func isValidIngressHost(ingressHost string) (bool, error) {
-	pattern := `^https://`
-	if store.Get().InsecureIngressHost {
-		pattern = `^(http|https)://`
-	}
-	return regexp.MatchString(pattern, ingressHost)
+	return regexp.MatchString(`^(http|https)://`, ingressHost)
 }
 
 func askUserIfToInstallDemoResources(cmd *cobra.Command, sampleInstall *bool) error {
@@ -496,11 +492,12 @@ func setIngressHost(ctx context.Context, opts *RuntimeInstallOptions) error {
 		if err != nil {
 			return err
 		}
-		_, err := http.Get(opts.IngressHost)
+		response, err := http.Get(opts.IngressHost)
 		if err != nil {
 			opts.IngressHost = ""
 			return err
 		}
+		response.Body.Close()
 	}
 
 	if opts.IngressHost == "" {

docs/releases/release_notes.md

@@ -23,7 +23,7 @@ cf version
 
 ```bash
 # download and extract the binary
-curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.387/cf-linux-amd64.tar.gz | tar zx
+curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.388/cf-linux-amd64.tar.gz | tar zx
 
 # move the binary to your $PATH
 mv ./cf-linux-amd64 /usr/local/bin/cf
@@ -36,7 +36,7 @@ cf version
 
 ```bash
 # download and extract the binary
-curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.387/cf-darwin-amd64.tar.gz | tar zx
+curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.388/cf-darwin-amd64.tar.gz | tar zx
 
 # move the binary to your $PATH
 mv ./cf-darwin-amd64 /usr/local/bin/cf

manifests/runtime.yaml

@@ -5,7 +5,7 @@ metadata:
   namespace: "{{ namespace }}"
 spec:
   defVersion: 1.0.1
-  version: 0.0.387
+  version: 0.0.388
   bootstrapSpecifier: github.com/codefresh-io/cli-v2/manifests/argo-cd
   components:
     - name: events