Installation rollback isc bug (#439)

* pass IscCloneOpts when installation rollback

* bug fix

* bump

* small fix

Author: rotem-codefresh

Makefile

@@ -1,4 +1,4 @@
-VERSION=v0.0.389
+VERSION=v0.0.390
 
 OUT_DIR=dist
 YEAR?=$(shell date +"%Y")

cmd/commands/runtime.go

@@ -2696,14 +2696,30 @@ func postInstallationHandler(ctx context.Context, opts *RuntimeInstallOptions, e
 	if err != nil && !*disableRollback {
 		summaryArr = append(summaryArr, summaryLog{"----------Uninstalling runtime----------", Info})
 		log.G(ctx).Warnf("installation failed due to error : %s, performing installation rollback", err.Error())
+		iscCloneOpts := &git.CloneOptions{
+			FS:               fs.Create(memfs.New()),
+			CreateIfNotExist: false,
+		}
+		iscCloneOpts.Repo, err = getIscRepo(ctx)
+		handleCliStep(reporter.UninstallStepGetIscRepoFromPlatform, "Getting isc repo from platform before rollback", err, false, true)
+		if err != nil {
+			log.G(ctx).Errorf("failed to get isc repo from platform before installation rollback: %s", err.Error())
+		}
+
+		inferProviderFromRepo(opts.InsCloneOpts)
+		iscCloneOpts.Auth = opts.InsCloneOpts.Auth
+		iscCloneOpts.Progress = opts.InsCloneOpts.Progress
+		iscCloneOpts.Parse()
+
 		err := RunRuntimeUninstall(ctx, &RuntimeUninstallOptions{
-			RuntimeName: opts.RuntimeName,
-			Timeout:     store.Get().WaitTimeout,
-			CloneOpts:   opts.InsCloneOpts,
-			KubeFactory: opts.KubeFactory,
-			SkipChecks:  true,
-			Force:       true,
-			FastExit:    false,
+			RuntimeName:  opts.RuntimeName,
+			Timeout:      store.Get().WaitTimeout,
+			CloneOpts:    opts.InsCloneOpts,
+			IscCloneOpts: iscCloneOpts,
+			KubeFactory:  opts.KubeFactory,
+			SkipChecks:   true,
+			Force:        true,
+			FastExit:     false,
 		})
 		handleCliStep(reporter.UninstallPhaseFinish, "Uninstall phase finished after rollback", err, false, true)
 		if err != nil {

docs/releases/release_notes.md

@@ -23,7 +23,7 @@ cf version
 
 ```bash
 # download and extract the binary
-curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.389/cf-linux-amd64.tar.gz | tar zx
+curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.390/cf-linux-amd64.tar.gz | tar zx
 
 # move the binary to your $PATH
 mv ./cf-linux-amd64 /usr/local/bin/cf
@@ -36,7 +36,7 @@ cf version
 
 ```bash
 # download and extract the binary
-curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.389/cf-darwin-amd64.tar.gz | tar zx
+curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.390/cf-darwin-amd64.tar.gz | tar zx
 
 # move the binary to your $PATH
 mv ./cf-darwin-amd64 /usr/local/bin/cf

manifests/runtime.yaml

@@ -5,7 +5,7 @@ metadata:
   namespace: "{{ namespace }}"
 spec:
   defVersion: 1.0.1
-  version: 0.0.389
+  version: 0.0.390
   bootstrapSpecifier: github.com/codefresh-io/cli-v2/manifests/argo-cd
   components:
     - name: events

pkg/reporter/reporter.go

@@ -110,6 +110,7 @@ const (
 	UninstallStepRemoveGitIntegrations         CliStep = "uninstall.run.step.remove-git-integrations"
 	UninstallStepRemoveRuntimeIsc              CliStep = "uninstall.run.step.remove-runtime-isc"
 	UninstallStepDeleteRuntimeFromPlatform     CliStep = "uninstall.run.step.delete-runtime-from-platform"
+	UninstallStepGetIscRepoFromPlatform        CliStep = "uninstall.run.step.get-isc-repo-from-platform"
 	UninstallPhaseFinish                       CliStep = "uninstall.run.phase.finish"
 
 	// Upgrade