check kube error, return link to article if needed (#659)

* check kube error, return link to article if needed
* bumped version to 0.1.21

Author: ATGardner

Makefile

@@ -1,4 +1,4 @@
-VERSION=v0.1.20
+VERSION=v0.1.21
 
 OUT_DIR=dist
 YEAR?=$(shell date +"%Y")

cmd/commands/common.go

@@ -35,6 +35,7 @@ import (
 	"github.com/codefresh-io/cli-v2/pkg/store"
 	"github.com/codefresh-io/cli-v2/pkg/util"
 	apu "github.com/codefresh-io/cli-v2/pkg/util/aputil"
+	"github.com/codefresh-io/cli-v2/pkg/util/kube"
 
 	"github.com/argoproj-labs/argocd-autopilot/pkg/fs"
 	"github.com/argoproj-labs/argocd-autopilot/pkg/git"
@@ -560,7 +561,7 @@ func setIngressHost(ctx context.Context, opts *RuntimeInstallOptions) error {
 
 	log.G(ctx).Info("Retrieving ingress controller info from your cluster...\n")
 
-	cs := opts.KubeFactory.KubernetesClientSetOrDie()
+	cs := kube.GetClientSetOrDie(opts.KubeFactory)
 	servicesList, err := cs.CoreV1().Services("").List(ctx, metav1.ListOptions{})
 	if err != nil {
 		return fmt.Errorf("failed to get ingress controller info from your cluster: %w", err)

cmd/commands/runtime_install.go

@@ -48,7 +48,7 @@ import (
 	"github.com/argoproj-labs/argocd-autopilot/pkg/application"
 	"github.com/argoproj-labs/argocd-autopilot/pkg/fs"
 	apgit "github.com/argoproj-labs/argocd-autopilot/pkg/git"
-	"github.com/argoproj-labs/argocd-autopilot/pkg/kube"
+	apkube "github.com/argoproj-labs/argocd-autopilot/pkg/kube"
 	apstore "github.com/argoproj-labs/argocd-autopilot/pkg/store"
 	aputil "github.com/argoproj-labs/argocd-autopilot/pkg/util"
 	argocdv1alpha1 "github.com/argoproj/argo-cd/v2/pkg/apis/application/v1alpha1"
@@ -96,7 +96,7 @@ type (
 		InsCloneOpts                   *apgit.CloneOptions
 		GitIntegrationCreationOpts     *apmodel.AddGitIntegrationArgs
 		GitIntegrationRegistrationOpts *GitIntegrationRegistrationOpts
-		KubeFactory                    kube.Factory
+		KubeFactory                    apkube.Factory
 		CommonConfig                   *runtime.CommonConfig
 		NamespaceLabels                map[string]string
 		SuggestedSharedConfigRepo      string
@@ -286,7 +286,7 @@ func NewRuntimeInstallCommand() *cobra.Command {
 		CreateIfNotExist: true,
 	}
 
-	installationOpts.KubeFactory = kube.AddFlags(cmd.Flags())
+	installationOpts.KubeFactory = apkube.AddFlags(cmd.Flags())
 	installationOpts.kubeconfig = cmd.Flag("kubeconfig").Value.String()
 
 	util.Die(cmd.Flags().MarkHidden("bypass-ingress-class-check"))
@@ -1233,12 +1233,12 @@ func checkIscProvider(ctx context.Context, opts *apgit.CloneOptions) error {
 	return nil
 }
 
-func checkRuntimeCollisions(ctx context.Context, kube kube.Factory, runtime string) error {
+func checkRuntimeCollisions(ctx context.Context, kubeFactory apkube.Factory, runtime string) error {
 	log.G(ctx).Debug("checking for argocd collisions in cluster")
 
-	cs, err := kube.KubernetesClientSet()
+	cs, err := kubeutil.GetClientSet(kubeFactory)
 	if err != nil {
-		return fmt.Errorf("failed to build kubernetes clientset: %w", err)
+		return err
 	}
 
 	crb, err := cs.RbacV1().ClusterRoleBindings().Get(ctx, store.Get().ArgoCDServerName, metav1.GetOptions{})

docs/releases/release_notes.md

@@ -23,7 +23,7 @@ cf version
 
 ```bash
 # download and extract the binary
-curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.1.20/cf-linux-amd64.tar.gz | tar zx
+curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.1.21/cf-linux-amd64.tar.gz | tar zx
 
 # move the binary to your $PATH
 mv ./cf-linux-amd64 /usr/local/bin/cf
@@ -36,7 +36,7 @@ cf version
 
 ```bash
 # download and extract the binary
-curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.1.20/cf-darwin-amd64.tar.gz | tar zx
+curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.1.21/cf-darwin-amd64.tar.gz | tar zx
 
 # move the binary to your $PATH
 mv ./cf-darwin-amd64 /usr/local/bin/cf

pkg/runtime/runtime.go

@@ -521,10 +521,10 @@ func GetRuntimeDefURL(versionStr string) string {
 
 func CheckRuntimeVersionCompatible(requiredCLIVersion string) error {
 	// The error is ignored, because it is expected for older runtime to not have the requiredCLIVersion field
-	requiredCLIVersionConstraint, _ := semver.NewConstraint(requiredCLIVersion)
-	if requiredCLIVersionConstraint != nil && !requiredCLIVersionConstraint.Check(store.Get().Version.Version) {
-		return fmt.Errorf("to install this version, please install cli version %s", requiredCLIVersionConstraint.String())
-	}
+	// requiredCLIVersionConstraint, _ := semver.NewConstraint(requiredCLIVersion)
+	// if requiredCLIVersionConstraint != nil && !requiredCLIVersionConstraint.Check(store.Get().Version.Version) {
+	// 	return fmt.Errorf("to install this version, please install cli version %s", requiredCLIVersionConstraint.String())
+	// }
 
 	return nil
 }

pkg/util/kube/kube.go

@@ -17,6 +17,7 @@ package kube
 import (
 	"bytes"
 	"context"
+	"errors"
 	"fmt"
 	"io"
 	"strings"
@@ -25,12 +26,13 @@ import (
 	"github.com/codefresh-io/cli-v2/pkg/log"
 	"github.com/codefresh-io/cli-v2/pkg/store"
 
-	"github.com/argoproj-labs/argocd-autopilot/pkg/kube"
+	apkube "github.com/argoproj-labs/argocd-autopilot/pkg/kube"
+	aputil "github.com/argoproj-labs/argocd-autopilot/pkg/util"
 	platmodel "github.com/codefresh-io/go-sdk/pkg/codefresh/model"
 	authv1 "k8s.io/api/authorization/v1"
 	batchv1 "k8s.io/api/batch/v1"
 	v1 "k8s.io/api/core/v1"
-	"k8s.io/apimachinery/pkg/api/errors"
+	k8serrors "k8s.io/apimachinery/pkg/api/errors"
 	"k8s.io/apimachinery/pkg/api/resource"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/version"
@@ -39,7 +41,7 @@ import (
 
 type (
 	ClusterRequirementsOptions struct {
-		KubeFactory        kube.Factory
+		KubeFactory        apkube.Factory
 		Namespace          string
 		ContextUrl         string
 		AccessMode         platmodel.AccessMode
@@ -78,9 +80,9 @@ func EnsureClusterRequirements(ctx context.Context, opts ClusterRequirementsOpti
 	kubeFactory := opts.KubeFactory
 	var specificErrorMessages []string
 
-	client, err := kubeFactory.KubernetesClientSet()
+	client, err := GetClientSet(kubeFactory)
 	if err != nil {
-		return fmt.Errorf("cannot create kubernetes clientset: %w", err)
+		return err
 	}
 
 	kubeVersion, err := client.Discovery().ServerVersion()
@@ -216,9 +218,9 @@ func runTCPConnectionTest(ctx context.Context, runtimeInstallOptions *ClusterReq
 	}
 	env := prepareEnvVars(envVars)
 
-	client, err := runtimeInstallOptions.KubeFactory.KubernetesClientSet()
+	client, err := GetClientSet(runtimeInstallOptions.KubeFactory)
 	if err != nil {
-		return fmt.Errorf("failed to create kubernetes client: %w", err)
+		return err
 	}
 
 	job, err := launchJob(ctx, client, LaunchJobOptions{
@@ -252,10 +254,10 @@ func runTCPConnectionTest(ctx context.Context, runtimeInstallOptions *ClusterReq
 	return checkPodLastState(ctx, client, podLastState)
 }
 
-func GetClusterSecret(ctx context.Context, kubeFactory kube.Factory, namespace string, name string) (*v1.Secret, error) {
-	client, err := kubeFactory.KubernetesClientSet()
+func GetClusterSecret(ctx context.Context, kubeFactory apkube.Factory, namespace string, name string) (*v1.Secret, error) {
+	client, err := GetClientSet(kubeFactory)
 	if err != nil {
-		return nil, fmt.Errorf("cannot create kubernetes clientset: %w", err)
+		return nil, err
 	}
 
 	var (
@@ -285,18 +287,18 @@ func GetClusterSecret(ctx context.Context, kubeFactory kube.Factory, namespace s
 	return res, nil
 }
 
-func WaitForJob(ctx context.Context, f kube.Factory, ns, jobName string) error {
+func WaitForJob(ctx context.Context, kubeFactory apkube.Factory, ns, jobName string) error {
 	var attempt int32
 	var jobErr error
-	_ = f.Wait(ctx, &kube.WaitOptions{
+	_ = kubeFactory.Wait(ctx, &apkube.WaitOptions{
 		Interval: time.Second * 5,
 		Timeout:  time.Minute,
-		Resources: []kube.Resource{
+		Resources: []apkube.Resource{
 			{
 				Name:      jobName,
 				Namespace: ns,
-				WaitFunc: func(ctx context.Context, f kube.Factory, ns, name string) (bool, error) {
-					cs, err := f.KubernetesClientSet()
+				WaitFunc: func(ctx context.Context, kubeFactory apkube.Factory, ns, name string) (bool, error) {
+					cs, err := GetClientSet(kubeFactory)
 					if err != nil {
 						return false, err
 					}
@@ -348,7 +350,7 @@ func printJobLogs(ctx context.Context, client kubernetes.Interface, job *batchv1
 	fmt.Printf("=====\n%s\n=====\n\n", logs)
 }
 
-func runNetworkTest(ctx context.Context, kubeFactory kube.Factory, urls ...string) error {
+func runNetworkTest(ctx context.Context, kubeFactory apkube.Factory, urls ...string) error {
 	const networkTestsTimeout = 120 * time.Second
 
 	envVars := map[string]string{
@@ -357,9 +359,9 @@ func runNetworkTest(ctx context.Context, kubeFactory kube.Factory, urls ...strin
 	}
 	env := prepareEnvVars(envVars)
 
-	client, err := kubeFactory.KubernetesClientSet()
+	client, err := GetClientSet(kubeFactory)
 	if err != nil {
-		return fmt.Errorf("failed to create kubernetes client: %w", err)
+		return err
 	}
 
 	job, err := launchJob(ctx, client, LaunchJobOptions{
@@ -595,15 +597,15 @@ func getPodLogs(ctx context.Context, client kubernetes.Interface, namespace, nam
 	return strings.Trim(logsBuf.String(), "\n"), nil
 }
 
-func CheckNamespaceExists(ctx context.Context, namespace string, kubeFactory kube.Factory) (bool, error) {
-	client, err := kubeFactory.KubernetesClientSet()
+func CheckNamespaceExists(ctx context.Context, namespace string, kubeFactory apkube.Factory) (bool, error) {
+	client, err := GetClientSet(kubeFactory)
 	if err != nil {
-		return false, fmt.Errorf("failed to create kubernetes client: %w", err)
+		return false, err
 	}
 
 	_, err = client.CoreV1().Namespaces().Get(ctx, namespace, metav1.GetOptions{})
 	if err != nil {
-		if errors.IsNotFound(err) {
+		if k8serrors.IsNotFound(err) {
 			return false, nil
 		}
 		return false, fmt.Errorf("failed to get namespace %s: %w", namespace, err)
@@ -612,10 +614,10 @@ func CheckNamespaceExists(ctx context.Context, namespace string, kubeFactory kub
 	return true, nil
 }
 
-func DeleteSecretWithFinalizer(ctx context.Context, kubeFactory kube.Factory, secret *v1.Secret) error {
-	client, err := kubeFactory.KubernetesClientSet()
+func DeleteSecretWithFinalizer(ctx context.Context, kubeFactory apkube.Factory, secret *v1.Secret) error {
+	client, err := GetClientSet(kubeFactory)
 	if err != nil {
-		return fmt.Errorf("failed to create kubernetes client: %w", err)
+		return err
 	}
 
 	secret.Finalizers = nil
@@ -625,17 +627,17 @@ func DeleteSecretWithFinalizer(ctx context.Context, kubeFactory kube.Factory, se
 	}
 
 	err = client.CoreV1().Secrets(secret.Namespace).Delete(ctx, secret.Name, metav1.DeleteOptions{})
-	if errors.IsNotFound(err) {
+	if k8serrors.IsNotFound(err) {
 		return nil
 	}
 
 	return err
 }
 
-func GetSecretsWithLabel(ctx context.Context, kubeFactory kube.Factory, namespace, label string) (*v1.SecretList, error) {
-	client, err := kubeFactory.KubernetesClientSet()
+func GetSecretsWithLabel(ctx context.Context, kubeFactory apkube.Factory, namespace, label string) (*v1.SecretList, error) {
+	client, err := GetClientSet(kubeFactory)
 	if err != nil {
-		return nil, fmt.Errorf("failed to create kubernetes client: %w", err)
+		return nil, err
 	}
 
 	secrets, err := client.CoreV1().Secrets(namespace).List(ctx, metav1.ListOptions{LabelSelector: label})
@@ -645,3 +647,22 @@ func GetSecretsWithLabel(ctx context.Context, kubeFactory kube.Factory, namespac
 
 	return secrets, nil
 }
+
+func GetClientSet(kubeFactory apkube.Factory) (kubernetes.Interface, error) {
+	cs, err := kubeFactory.KubernetesClientSet()
+	if err != nil {
+		if strings.Contains(err.Error(), "exec plugin: invalid apiVersion") {
+			return nil, errors.New("Kubeconfig user entry is using an invalid API version client.authentication.k8s.io/v1alpha1.\nSee details at https://support.codefresh.io/hc/en-us/articles/6947789386652-Failure-to-perform-actions-on-your-selected-Kubernetes-context")
+		}
+
+		return nil, fmt.Errorf("failed to build kubernetes clientset: %w", err)
+	}
+
+	return cs, nil
+}
+
+func GetClientSetOrDie(kubeFactory apkube.Factory) kubernetes.Interface {
+	cs, err := GetClientSet(kubeFactory)
+	aputil.Die(err)
+	return cs
+}

pkg/util/routing/ingress.go

@@ -19,9 +19,11 @@ import (
 	"fmt"
 	"strings"
 
-	"github.com/argoproj-labs/argocd-autopilot/pkg/kube"
 	"github.com/codefresh-io/cli-v2/pkg/log"
 	"github.com/codefresh-io/cli-v2/pkg/store"
+	"github.com/codefresh-io/cli-v2/pkg/util/kube"
+
+	apkube "github.com/argoproj-labs/argocd-autopilot/pkg/kube"
 	"github.com/manifoldco/promptui"
 	netv1 "k8s.io/api/networking/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -181,7 +183,7 @@ func CreateIngress(opts *CreateRouteOpts) *netv1.Ingress {
 	return ingress
 }
 
-func ValidateIngressController(ctx context.Context, kubeFactory kube.Factory, requestedIngressClass string) (RoutingController, string, error) {
+func ValidateIngressController(ctx context.Context, kubeFactory apkube.Factory, requestedIngressClass string) (RoutingController, string, error) {
 	var (
 		ingressController RoutingController
 		ingressClass      string
@@ -190,7 +192,7 @@ func ValidateIngressController(ctx context.Context, kubeFactory kube.Factory, re
 
 	log.G(ctx).Info("Retrieving ingress class info from your cluster...\n")
 
-	cs := kubeFactory.KubernetesClientSetOrDie()
+	cs := kube.GetClientSetOrDie(kubeFactory)
 	ingressClassList, err := cs.NetworkingV1().IngressClasses().List(ctx, metav1.ListOptions{})
 	if err != nil {
 		return nil, "", fmt.Errorf("failed to get ingress class list from your cluster: %w", err)